[INFO] updating cached repository gtestault/cdma-decoder [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gtestault/cdma-decoder [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gtestault/cdma-decoder" "work/ex/clippy-test-run/sources/stable/gh/gtestault/cdma-decoder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gtestault/cdma-decoder'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gtestault/cdma-decoder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gtestault/cdma-decoder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gtestault/cdma-decoder'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 74a73f861667d4b08f02584222bbf4e3efc3cb5d [INFO] sha for GitHub repo gtestault/cdma-decoder: 74a73f861667d4b08f02584222bbf4e3efc3cb5d [INFO] validating manifest of gtestault/cdma-decoder on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gtestault/cdma-decoder on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gtestault/cdma-decoder [INFO] finished frobbing gtestault/cdma-decoder [INFO] frobbed toml for gtestault/cdma-decoder written to work/ex/clippy-test-run/sources/stable/gh/gtestault/cdma-decoder/Cargo.toml [INFO] started frobbing gtestault/cdma-decoder [INFO] finished frobbing gtestault/cdma-decoder [INFO] frobbed toml for gtestault/cdma-decoder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gtestault/cdma-decoder/Cargo.toml [INFO] crate gtestault/cdma-decoder has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gtestault/cdma-decoder against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gtestault/cdma-decoder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08c5005e1c94f8c3cbe303d4ca6aa3a1970ce6d9e73f20e6361fe7e50f8133c5 [INFO] running `"docker" "start" "-a" "08c5005e1c94f8c3cbe303d4ca6aa3a1970ce6d9e73f20e6361fe7e50f8133c5"` [INFO] [stderr] Checking cdma-decoder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unary minus has lower precedence than method call [INFO] [stderr] --> src/main.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | -2i32.pow((12)/2) - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider adding parentheses to clarify your intent: `-(2i32.pow((12)/2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | *reg &= !(1u16 << ShiftRegGPS::reg_size() - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u16 << (ShiftRegGPS::reg_size() - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | *reg |= bit << ShiftRegGPS::reg_size() - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bit << (ShiftRegGPS::reg_size() - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unary minus has lower precedence than method call [INFO] [stderr] --> src/main.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | -2i32.pow((12)/2) - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider adding parentheses to clarify your intent: `-(2i32.pow((12)/2))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | *reg &= !(1u16 << ShiftRegGPS::reg_size() - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u16 << (ShiftRegGPS::reg_size() - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | *reg |= bit << ShiftRegGPS::reg_size() - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `bit << (ShiftRegGPS::reg_size() - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "08c5005e1c94f8c3cbe303d4ca6aa3a1970ce6d9e73f20e6361fe7e50f8133c5"` [INFO] running `"docker" "rm" "-f" "08c5005e1c94f8c3cbe303d4ca6aa3a1970ce6d9e73f20e6361fe7e50f8133c5"` [INFO] [stdout] 08c5005e1c94f8c3cbe303d4ca6aa3a1970ce6d9e73f20e6361fe7e50f8133c5