[INFO] updating cached repository gregoryalary/rust_binaryheap [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gregoryalary/rust_binaryheap [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gregoryalary/rust_binaryheap" "work/ex/clippy-test-run/sources/stable/gh/gregoryalary/rust_binaryheap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gregoryalary/rust_binaryheap'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gregoryalary/rust_binaryheap" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregoryalary/rust_binaryheap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregoryalary/rust_binaryheap'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bb16aeb8f728171f9d0724a4352cdf22d5ec8d38 [INFO] sha for GitHub repo gregoryalary/rust_binaryheap: bb16aeb8f728171f9d0724a4352cdf22d5ec8d38 [INFO] validating manifest of gregoryalary/rust_binaryheap on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gregoryalary/rust_binaryheap on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gregoryalary/rust_binaryheap [INFO] finished frobbing gregoryalary/rust_binaryheap [INFO] frobbed toml for gregoryalary/rust_binaryheap written to work/ex/clippy-test-run/sources/stable/gh/gregoryalary/rust_binaryheap/Cargo.toml [INFO] started frobbing gregoryalary/rust_binaryheap [INFO] finished frobbing gregoryalary/rust_binaryheap [INFO] frobbed toml for gregoryalary/rust_binaryheap written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregoryalary/rust_binaryheap/Cargo.toml [INFO] crate gregoryalary/rust_binaryheap has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gregoryalary/rust_binaryheap against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregoryalary/rust_binaryheap:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b5b5318c784cb0d4cc2f04cd325178f76982b2a490643cb268680c3e18754bb8 [INFO] running `"docker" "start" "-a" "b5b5318c784cb0d4cc2f04cd325178f76982b2a490643cb268680c3e18754bb8"` [INFO] [stderr] Checking binaryheap v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | return self.heap.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.heap.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | / return if !self.heap.is_empty() { [INFO] [stderr] 34 | | let temp = self.heap[0]; [INFO] [stderr] 35 | | self.heap[0] = x; [INFO] [stderr] 36 | | self.percolate_down(0); [INFO] [stderr] ... | [INFO] [stderr] 39 | | Some(x) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | if !self.heap.is_empty() { [INFO] [stderr] 34 | let temp = self.heap[0]; [INFO] [stderr] 35 | self.heap[0] = x; [INFO] [stderr] 36 | self.percolate_down(0); [INFO] [stderr] 37 | Some(temp) [INFO] [stderr] 38 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | return (i * 2) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(i * 2) + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return self.left(i) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.left(i) + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / return if i > 0 { [INFO] [stderr] 55 | | Some((i - 1) / 2) [INFO] [stderr] 56 | | } else { [INFO] [stderr] 57 | | None [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | if i > 0 { [INFO] [stderr] 55 | Some((i - 1) / 2) [INFO] [stderr] 56 | } else { [INFO] [stderr] 57 | None [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return b_heap; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `b_heap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `self.heap` manually [INFO] [stderr] --> src/lib.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | / let temp = self.heap[index]; [INFO] [stderr] 70 | | self.heap[index] = self.heap[m]; [INFO] [stderr] 71 | | self.heap[m] = temp; [INFO] [stderr] | |___________________________________^ help: try: `self.heap.swap(index, m)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `self.heap` manually [INFO] [stderr] --> src/lib.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | / let temp = self.heap[parent]; [INFO] [stderr] 82 | | self.heap[parent] = self.heap[index]; [INFO] [stderr] 83 | | self.heap[index] = temp; [INFO] [stderr] | |___________________________________________^ help: try: `self.heap.swap(parent, index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | return self.heap.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.heap.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | / return if !self.heap.is_empty() { [INFO] [stderr] 34 | | let temp = self.heap[0]; [INFO] [stderr] 35 | | self.heap[0] = x; [INFO] [stderr] 36 | | self.percolate_down(0); [INFO] [stderr] ... | [INFO] [stderr] 39 | | Some(x) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | if !self.heap.is_empty() { [INFO] [stderr] 34 | let temp = self.heap[0]; [INFO] [stderr] 35 | self.heap[0] = x; [INFO] [stderr] 36 | self.percolate_down(0); [INFO] [stderr] 37 | Some(temp) [INFO] [stderr] 38 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | return (i * 2) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(i * 2) + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return self.left(i) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.left(i) + 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / return if i > 0 { [INFO] [stderr] 55 | | Some((i - 1) / 2) [INFO] [stderr] 56 | | } else { [INFO] [stderr] 57 | | None [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | if i > 0 { [INFO] [stderr] 55 | Some((i - 1) / 2) [INFO] [stderr] 56 | } else { [INFO] [stderr] 57 | None [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return b_heap; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `b_heap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `self.heap` manually [INFO] [stderr] --> src/lib.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | / let temp = self.heap[index]; [INFO] [stderr] 70 | | self.heap[index] = self.heap[m]; [INFO] [stderr] 71 | | self.heap[m] = temp; [INFO] [stderr] | |___________________________________^ help: try: `self.heap.swap(index, m)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `self.heap` manually [INFO] [stderr] --> src/lib.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | / let temp = self.heap[parent]; [INFO] [stderr] 82 | | self.heap[parent] = self.heap[index]; [INFO] [stderr] 83 | | self.heap[index] = temp; [INFO] [stderr] | |___________________________________________^ help: try: `self.heap.swap(parent, index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `"docker" "inspect" "b5b5318c784cb0d4cc2f04cd325178f76982b2a490643cb268680c3e18754bb8"` [INFO] running `"docker" "rm" "-f" "b5b5318c784cb0d4cc2f04cd325178f76982b2a490643cb268680c3e18754bb8"` [INFO] [stdout] b5b5318c784cb0d4cc2f04cd325178f76982b2a490643cb268680c3e18754bb8