[INFO] updating cached repository gregorholzmann/rust-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gregorholzmann/rust-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gregorholzmann/rust-playground" "work/ex/clippy-test-run/sources/stable/gh/gregorholzmann/rust-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gregorholzmann/rust-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gregorholzmann/rust-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregorholzmann/rust-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregorholzmann/rust-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6e44145369c9374ccf0e294cbae2934d301387e2 [INFO] sha for GitHub repo gregorholzmann/rust-playground: 6e44145369c9374ccf0e294cbae2934d301387e2 [INFO] validating manifest of gregorholzmann/rust-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gregorholzmann/rust-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gregorholzmann/rust-playground [INFO] finished frobbing gregorholzmann/rust-playground [INFO] frobbed toml for gregorholzmann/rust-playground written to work/ex/clippy-test-run/sources/stable/gh/gregorholzmann/rust-playground/Cargo.toml [INFO] started frobbing gregorholzmann/rust-playground [INFO] finished frobbing gregorholzmann/rust-playground [INFO] frobbed toml for gregorholzmann/rust-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregorholzmann/rust-playground/Cargo.toml [INFO] crate gregorholzmann/rust-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gregorholzmann/rust-playground against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gregorholzmann/rust-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e45f13f769fbd738f8dc2c3dcde051a0868ff904029dbb4f662afbd808626cc [INFO] running `"docker" "start" "-a" "2e45f13f769fbd738f8dc2c3dcde051a0868ff904029dbb4f662afbd808626cc"` [INFO] [stderr] Checking rust-playground v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/deck_generator.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | suit: suit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/deck_generator.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | suit: suit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | new_hand [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:137:20 [INFO] [stderr] | [INFO] [stderr] 137 | let new_hand = readable_hand.join(", "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | new_hand [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:137:20 [INFO] [stderr] | [INFO] [stderr] 137 | let new_hand = readable_hand.join(", "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | for x in 0..number_of_cards { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `num_value` is never read [INFO] [stderr] --> src/main.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | let mut num_value: u8 = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:101:51 [INFO] [stderr] | [INFO] [stderr] 101 | fn end_game(player_hand: Hand, dealer_hand: Hand, mut deck: &mut Vec) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / let mut num_value: u8 = 0; [INFO] [stderr] 26 | | if face_cards.contains(&card.value) { [INFO] [stderr] 27 | | num_value = 10; [INFO] [stderr] 28 | | } else { [INFO] [stderr] 29 | | num_value = card.value.parse::().unwrap(); [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let num_value = if face_cards.contains(&card.value) { 10 } else { card.value.parse::().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | self.total_value = self.total_value + num_value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.total_value += num_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/main.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if player_hand.total_value > BUST_THRESHOLD || player_hand.total_value == BUST_THRESHOLD { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `player_hand.total_value >= BUST_THRESHOLD` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / for x in 0..number_of_cards { [INFO] [stderr] 87 | | let drawn_card = deck.pop(); [INFO] [stderr] 88 | | match drawn_card { [INFO] [stderr] 89 | | Some(x) => { [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-playground`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | for x in 0..number_of_cards { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `num_value` is never read [INFO] [stderr] --> src/main.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | let mut num_value: u8 = 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:101:51 [INFO] [stderr] | [INFO] [stderr] 101 | fn end_game(player_hand: Hand, dealer_hand: Hand, mut deck: &mut Vec) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / let mut num_value: u8 = 0; [INFO] [stderr] 26 | | if face_cards.contains(&card.value) { [INFO] [stderr] 27 | | num_value = 10; [INFO] [stderr] 28 | | } else { [INFO] [stderr] 29 | | num_value = card.value.parse::().unwrap(); [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let num_value = if face_cards.contains(&card.value) { 10 } else { card.value.parse::().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | self.total_value = self.total_value + num_value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.total_value += num_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/main.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if player_hand.total_value > BUST_THRESHOLD || player_hand.total_value == BUST_THRESHOLD { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `player_hand.total_value >= BUST_THRESHOLD` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / for x in 0..number_of_cards { [INFO] [stderr] 87 | | let drawn_card = deck.pop(); [INFO] [stderr] 88 | | match drawn_card { [INFO] [stderr] 89 | | Some(x) => { [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-playground`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2e45f13f769fbd738f8dc2c3dcde051a0868ff904029dbb4f662afbd808626cc"` [INFO] running `"docker" "rm" "-f" "2e45f13f769fbd738f8dc2c3dcde051a0868ff904029dbb4f662afbd808626cc"` [INFO] [stdout] 2e45f13f769fbd738f8dc2c3dcde051a0868ff904029dbb4f662afbd808626cc