[INFO] updating cached repository grantlindberg4/wsu-crypt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/grantlindberg4/wsu-crypt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/grantlindberg4/wsu-crypt" "work/ex/clippy-test-run/sources/stable/gh/grantlindberg4/wsu-crypt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/grantlindberg4/wsu-crypt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/grantlindberg4/wsu-crypt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grantlindberg4/wsu-crypt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grantlindberg4/wsu-crypt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 932fed3333b312e6a2da714935c24962bca1df75 [INFO] sha for GitHub repo grantlindberg4/wsu-crypt: 932fed3333b312e6a2da714935c24962bca1df75 [INFO] validating manifest of grantlindberg4/wsu-crypt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grantlindberg4/wsu-crypt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grantlindberg4/wsu-crypt [INFO] finished frobbing grantlindberg4/wsu-crypt [INFO] frobbed toml for grantlindberg4/wsu-crypt written to work/ex/clippy-test-run/sources/stable/gh/grantlindberg4/wsu-crypt/Cargo.toml [INFO] started frobbing grantlindberg4/wsu-crypt [INFO] finished frobbing grantlindberg4/wsu-crypt [INFO] frobbed toml for grantlindberg4/wsu-crypt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grantlindberg4/wsu-crypt/Cargo.toml [INFO] crate grantlindberg4/wsu-crypt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grantlindberg4/wsu-crypt against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/grantlindberg4/wsu-crypt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 01f1becc3d1e8f42a56d9243f6092361f10e235465d78a064ff1515d99dec021 [INFO] running `"docker" "start" "-a" "01f1becc3d1e8f42a56d9243f6092361f10e235465d78a064ff1515d99dec021"` [INFO] [stderr] Checking wsu_crypt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let mut key_block = 0xabcdef0123456789; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xabcd_ef01_2345_6789` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:124:30 [INFO] [stderr] | [INFO] [stderr] 124 | let mut key_block: u64 = 0xabcdef0123456789; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xabcd_ef01_2345_6789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:144:25 [INFO] [stderr] | [INFO] [stderr] 144 | let mut key_block = 0xabcdef0123456789; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xabcd_ef01_2345_6789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | assert!(block == 0x945f0e8faaeeaa66); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x945f_0e8f_aaee_aa66` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | 0x945f0e8faaeeaa66, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x945f_0e8f_aaee_aa66` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | 0x24c7cb70945f0e8f, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x24c7_cb70_945f_0e8f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | 0x99efc5d324c7cb70, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x99ef_c5d3_24c7_cb70` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | 0xe0562f3499efc5d3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xe056_2f34_99ef_c5d3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | 0x708dbb8ce0562f34, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x708d_bb8c_e056_2f34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | 0xb3a5bb1c708dbb8c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xb3a5_bb1c_708d_bb8c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | 0xba991c1bb3a5bb1c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xba99_1c1b_b3a5_bb1c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | 0x9ad4d197ba991c1b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9ad4_d197_ba99_1c1b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | 0xb7538cf69ad4d197, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xb753_8cf6_9ad4_d197` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | 0x559ecc0bb7538cf6, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x559e_cc0b_b753_8cf6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | 0x2df37aaf559ecc0b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2df3_7aaf_559e_cc0b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | 0x721b9b4c2df37aaf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x721b_9b4c_2df3_7aaf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | 0x906cce55721b9b4c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x906c_ce55_721b_9b4c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | 0xccd1ac27906cce55, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xccd1_ac27_906c_ce55` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | 0x811429e4ccd1ac27, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8114_29e4_ccd1_ac27` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | 0x9bbb3172811429e4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9bbb_3172_8114_29e4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:188:25 [INFO] [stderr] | [INFO] [stderr] 188 | let mut key_block = 0xabcdef0123456789; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xabcd_ef01_2345_6789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:227:27 [INFO] [stderr] | [INFO] [stderr] 227 | assert!(ciphertext == 0x2ad9c6e5b8fe56fb); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2ad9_c6e5_b8fe_56fb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:237:27 [INFO] [stderr] | [INFO] [stderr] 237 | assert!(ciphertext == 0x2ad9c6e5b8fe56fb); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2ad9_c6e5_b8fe_56fb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:247:26 [INFO] [stderr] | [INFO] [stderr] 247 | assert!(plaintext == 0x01234567890abcdef); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_1234_5678_90ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/convert_types.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn to_u16_block(first: &u8, second: &u8) -> u16 { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/convert_types.rs:13:41 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn to_u16_block(first: &u8, second: &u8) -> u16 { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | let first = (*first as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(*first)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | let second = *second as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(*second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/convert_types.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn to_u32_block(first: &u16, second: &u16) -> u32 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/convert_types.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn to_u32_block(first: &u16, second: &u16) -> u32 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let first = (*first as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(*first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | let second = *second as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(*second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/convert_types.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn to_u16_vec(key: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/convert_types.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn to_u32_vec(key: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/convert_types.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn create_key_block(key: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:91:6 [INFO] [stderr] | [INFO] [stderr] 91 | ((key[0] as u64) << 32) | key[1] as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(key[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | ((key[0] as u64) << 32) | key[1] as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(key[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypt.rs:86:37 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn f(r0: u16, r1: u16, subkeys: &Vec, round: usize) -> (u16, u16) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:90:15 [INFO] [stderr] | [INFO] [stderr] 90 | let sum = t0 as u32 + 2*t1 as u32 + convert_types::to_u16_block(&subkeys[8], &subkeys[9]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:90:29 [INFO] [stderr] | [INFO] [stderr] 90 | let sum = t0 as u32 + 2*t1 as u32 + convert_types::to_u16_block(&subkeys[8], &subkeys[9]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:90:41 [INFO] [stderr] | [INFO] [stderr] 90 | let sum = t0 as u32 + 2*t1 as u32 + convert_types::to_u16_block(&subkeys[8], &subkeys[9]) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(convert_types::to_u16_block(&subkeys[8], &subkeys[9]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | let sum = 2*t0 as u32 + t1 as u32 + convert_types::to_u16_block(&subkeys[10], &subkeys[11]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:93:29 [INFO] [stderr] | [INFO] [stderr] 93 | let sum = 2*t0 as u32 + t1 as u32 + convert_types::to_u16_block(&subkeys[10], &subkeys[11]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:93:41 [INFO] [stderr] | [INFO] [stderr] 93 | let sum = 2*t0 as u32 + t1 as u32 + convert_types::to_u16_block(&subkeys[10], &subkeys[11]) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(convert_types::to_u16_block(&subkeys[10], &subkeys[11]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypt.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn encrypt(key: &Vec, plaintext: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypt.rs:113:42 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn encrypt(key: &Vec, plaintext: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypt.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn decrypt(key: &Vec, ciphertext: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypt.rs:154:43 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn decrypt(key: &Vec, ciphertext: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/subkey_gen.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn k(x: usize, key: &u64) -> u8 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/subkey_gen.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 0..SUBKEY_GEN_ROUNDS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=SUBKEY_GEN_ROUNDS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/subkey_gen.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | for i in (0..SUBKEY_GEN_ROUNDS+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=SUBKEY_GEN_ROUNDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:14:39 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn create_whitening_blocks(bytes: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:40:34 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn whiten_blocks(key_blocks: &Vec, plaintext_blocks: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:40:63 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn whiten_blocks(key_blocks: &Vec, plaintext_blocks: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn whiten_output(key: &Vec, y: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:72:41 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn whiten_output(key: &Vec, y: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/whiten.rs:76:6 [INFO] [stderr] | [INFO] [stderr] 76 | ((result[0] as u64) << 32) | result[1] as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(result[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/whiten.rs:76:34 [INFO] [stderr] | [INFO] [stderr] 76 | ((result[0] as u64) << 32) | result[1] as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(result[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn whiten_input(key: &Vec, plaintext: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:96:47 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn whiten_input(key: &Vec, plaintext: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/convert_types.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn to_u16_block(first: &u8, second: &u8) -> u16 { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/convert_types.rs:13:41 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn to_u16_block(first: &u8, second: &u8) -> u16 { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | let first = (*first as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(*first)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | let second = *second as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(*second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/convert_types.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn to_u32_block(first: &u16, second: &u16) -> u32 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/convert_types.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn to_u32_block(first: &u16, second: &u16) -> u32 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let first = (*first as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(*first)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | let second = *second as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(*second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/convert_types.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn to_u16_vec(key: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/convert_types.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn to_u32_vec(key: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/convert_types.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn create_key_block(key: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:91:6 [INFO] [stderr] | [INFO] [stderr] 91 | ((key[0] as u64) << 32) | key[1] as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(key[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/convert_types.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | ((key[0] as u64) << 32) | key[1] as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(key[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypt.rs:86:37 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn f(r0: u16, r1: u16, subkeys: &Vec, round: usize) -> (u16, u16) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:90:15 [INFO] [stderr] | [INFO] [stderr] 90 | let sum = t0 as u32 + 2*t1 as u32 + convert_types::to_u16_block(&subkeys[8], &subkeys[9]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:90:29 [INFO] [stderr] | [INFO] [stderr] 90 | let sum = t0 as u32 + 2*t1 as u32 + convert_types::to_u16_block(&subkeys[8], &subkeys[9]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:90:41 [INFO] [stderr] | [INFO] [stderr] 90 | let sum = t0 as u32 + 2*t1 as u32 + convert_types::to_u16_block(&subkeys[8], &subkeys[9]) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(convert_types::to_u16_block(&subkeys[8], &subkeys[9]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | let sum = 2*t0 as u32 + t1 as u32 + convert_types::to_u16_block(&subkeys[10], &subkeys[11]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:93:29 [INFO] [stderr] | [INFO] [stderr] 93 | let sum = 2*t0 as u32 + t1 as u32 + convert_types::to_u16_block(&subkeys[10], &subkeys[11]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/crypt.rs:93:41 [INFO] [stderr] | [INFO] [stderr] 93 | let sum = 2*t0 as u32 + t1 as u32 + convert_types::to_u16_block(&subkeys[10], &subkeys[11]) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(convert_types::to_u16_block(&subkeys[10], &subkeys[11]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypt.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn encrypt(key: &Vec, plaintext: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypt.rs:113:42 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn encrypt(key: &Vec, plaintext: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypt.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn decrypt(key: &Vec, ciphertext: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/crypt.rs:154:43 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn decrypt(key: &Vec, ciphertext: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/subkey_gen.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn k(x: usize, key: &u64) -> u8 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/subkey_gen.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 0..SUBKEY_GEN_ROUNDS+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=SUBKEY_GEN_ROUNDS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/subkey_gen.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | for i in (0..SUBKEY_GEN_ROUNDS+1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=SUBKEY_GEN_ROUNDS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:14:39 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn create_whitening_blocks(bytes: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:40:34 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn whiten_blocks(key_blocks: &Vec, plaintext_blocks: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:40:63 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn whiten_blocks(key_blocks: &Vec, plaintext_blocks: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn whiten_output(key: &Vec, y: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:72:41 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn whiten_output(key: &Vec, y: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/whiten.rs:76:6 [INFO] [stderr] | [INFO] [stderr] 76 | ((result[0] as u64) << 32) | result[1] as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(result[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/whiten.rs:76:34 [INFO] [stderr] | [INFO] [stderr] 76 | ((result[0] as u64) << 32) | result[1] as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(result[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn whiten_input(key: &Vec, plaintext: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/whiten.rs:96:47 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn whiten_input(key: &Vec, plaintext: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:60:15 [INFO] [stderr] | [INFO] [stderr] 60 | let sum = t0 as u32 + 2*t1 as u32 + convert_types::to_u16_block(&subkeys[8], &subkeys[9]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | let sum = t0 as u32 + 2*t1 as u32 + convert_types::to_u16_block(&subkeys[8], &subkeys[9]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:60:41 [INFO] [stderr] | [INFO] [stderr] 60 | let sum = t0 as u32 + 2*t1 as u32 + convert_types::to_u16_block(&subkeys[8], &subkeys[9]) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(convert_types::to_u16_block(&subkeys[8], &subkeys[9]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let sum = 2*t0 as u32 + t1 as u32 + convert_types::to_u16_block(&subkeys[10], &subkeys[11]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:64:29 [INFO] [stderr] | [INFO] [stderr] 64 | let sum = 2*t0 as u32 + t1 as u32 + convert_types::to_u16_block(&subkeys[10], &subkeys[11]) as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(t1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:64:41 [INFO] [stderr] | [INFO] [stderr] 64 | let sum = 2*t0 as u32 + t1 as u32 + convert_types::to_u16_block(&subkeys[10], &subkeys[11]) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(convert_types::to_u16_block(&subkeys[10], &subkeys[11]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | let block = ((block[0] as u64) << 32) | block[1] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(block[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:158:45 [INFO] [stderr] | [INFO] [stderr] 158 | let block = ((block[0] as u64) << 32) | block[1] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(block[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:207:26 [INFO] [stderr] | [INFO] [stderr] 207 | let block = ((block[0] as u64) << 32) | block[1] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(block[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/test.rs:207:53 [INFO] [stderr] | [INFO] [stderr] 207 | let block = ((block[0] as u64) << 32) | block[1] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(block[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.05s [INFO] running `"docker" "inspect" "01f1becc3d1e8f42a56d9243f6092361f10e235465d78a064ff1515d99dec021"` [INFO] running `"docker" "rm" "-f" "01f1becc3d1e8f42a56d9243f6092361f10e235465d78a064ff1515d99dec021"` [INFO] [stdout] 01f1becc3d1e8f42a56d9243f6092361f10e235465d78a064ff1515d99dec021