[INFO] updating cached repository gpierzynski/sorting [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gpierzynski/sorting [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gpierzynski/sorting" "work/ex/clippy-test-run/sources/stable/gh/gpierzynski/sorting"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gpierzynski/sorting'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gpierzynski/sorting" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gpierzynski/sorting"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gpierzynski/sorting'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0e71a168fb88c8f6e6861bb53f0398f219dc3a65 [INFO] sha for GitHub repo gpierzynski/sorting: 0e71a168fb88c8f6e6861bb53f0398f219dc3a65 [INFO] validating manifest of gpierzynski/sorting on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gpierzynski/sorting on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gpierzynski/sorting [INFO] finished frobbing gpierzynski/sorting [INFO] frobbed toml for gpierzynski/sorting written to work/ex/clippy-test-run/sources/stable/gh/gpierzynski/sorting/Cargo.toml [INFO] started frobbing gpierzynski/sorting [INFO] finished frobbing gpierzynski/sorting [INFO] frobbed toml for gpierzynski/sorting written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gpierzynski/sorting/Cargo.toml [INFO] crate gpierzynski/sorting has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gpierzynski/sorting against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gpierzynski/sorting:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] faa735470d21fac0d3c1830f6d47137bbde7d58e5780512d1b38f36902e8b883 [INFO] running `"docker" "start" "-a" "faa735470d21fac0d3c1830f6d47137bbde7d58e5780512d1b38f36902e8b883"` [INFO] [stderr] Checking sorts v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/print_sorted.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/quick.rs:7:10 [INFO] [stderr] | [INFO] [stderr] 7 | let mut i = p - 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/print_sorted.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/quick.rs:7:10 [INFO] [stderr] | [INFO] [stderr] 7 | let mut i = p - 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quick.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | return i + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `i + 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | quick::quick_sort(&mut sortme, 0, (a.len() as i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/quick.rs:6:6 [INFO] [stderr] | [INFO] [stderr] 6 | let mut x = a[(r-1) as usize]; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/quick.rs:25:6 [INFO] [stderr] | [INFO] [stderr] 25 | let mut q: i32; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/quick.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | i = i + 1; [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/quick.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | return i + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `i + 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | quick::quick_sort(&mut sortme, 0, (a.len() as i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | for i in 0..a.len() { [INFO] [stderr] | ^^^^^^^^^^ help: try replacing the loop by: `sortme[..a.len()].clone_from_slice(&a[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/quick.rs:6:6 [INFO] [stderr] | [INFO] [stderr] 6 | let mut x = a[(r-1) as usize]; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/quick.rs:25:6 [INFO] [stderr] | [INFO] [stderr] 25 | let mut q: i32; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/quick.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | for i in 0..a.len() { [INFO] [stderr] | ^^^^^^^^^^ help: try replacing the loop by: `sortme[..a.len()].clone_from_slice(&a[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "faa735470d21fac0d3c1830f6d47137bbde7d58e5780512d1b38f36902e8b883"` [INFO] running `"docker" "rm" "-f" "faa735470d21fac0d3c1830f6d47137bbde7d58e5780512d1b38f36902e8b883"` [INFO] [stdout] faa735470d21fac0d3c1830f6d47137bbde7d58e5780512d1b38f36902e8b883