[INFO] updating cached repository goodeggs/docker-compose-cacher [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/goodeggs/docker-compose-cacher [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/goodeggs/docker-compose-cacher" "work/ex/clippy-test-run/sources/stable/gh/goodeggs/docker-compose-cacher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/goodeggs/docker-compose-cacher'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/goodeggs/docker-compose-cacher" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/goodeggs/docker-compose-cacher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/goodeggs/docker-compose-cacher'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 50fe0b2765ee170d888b238cf519b07942691e28 [INFO] sha for GitHub repo goodeggs/docker-compose-cacher: 50fe0b2765ee170d888b238cf519b07942691e28 [INFO] validating manifest of goodeggs/docker-compose-cacher on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of goodeggs/docker-compose-cacher on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing goodeggs/docker-compose-cacher [INFO] finished frobbing goodeggs/docker-compose-cacher [INFO] frobbed toml for goodeggs/docker-compose-cacher written to work/ex/clippy-test-run/sources/stable/gh/goodeggs/docker-compose-cacher/Cargo.toml [INFO] started frobbing goodeggs/docker-compose-cacher [INFO] finished frobbing goodeggs/docker-compose-cacher [INFO] frobbed toml for goodeggs/docker-compose-cacher written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/goodeggs/docker-compose-cacher/Cargo.toml [INFO] crate goodeggs/docker-compose-cacher has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting goodeggs/docker-compose-cacher against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/goodeggs/docker-compose-cacher:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8ecd32125c6b8ac6d36d9ba288aa953744e85b8c3e85d409ffe9e5fcf0a3366a [INFO] running `"docker" "start" "-a" "8ecd32125c6b8ac6d36d9ba288aa953744e85b8c3e85d409ffe9e5fcf0a3366a"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking shellexpand v1.0.0 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking docker-compose-cacher v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | return Path::new(&filename).exists() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Path::new(&filename).exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | return Path::new(&filename).exists() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Path::new(&filename).exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:40:65 [INFO] [stderr] | [INFO] [stderr] 40 | let raw_cache_path = matches.opt_str("d").unwrap_or_else(|| format!("{}", "~/.docker-compose-cacher")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"~/.docker-compose-cacher".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | for (_, service) in services { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 54 | for service in services.values() { [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:40:65 [INFO] [stderr] | [INFO] [stderr] 40 | let raw_cache_path = matches.opt_str("d").unwrap_or_else(|| format!("{}", "~/.docker-compose-cacher")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"~/.docker-compose-cacher".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | for (_, service) in services { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 54 | for service in services.values() { [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.87s [INFO] running `"docker" "inspect" "8ecd32125c6b8ac6d36d9ba288aa953744e85b8c3e85d409ffe9e5fcf0a3366a"` [INFO] running `"docker" "rm" "-f" "8ecd32125c6b8ac6d36d9ba288aa953744e85b8c3e85d409ffe9e5fcf0a3366a"` [INFO] [stdout] 8ecd32125c6b8ac6d36d9ba288aa953744e85b8c3e85d409ffe9e5fcf0a3366a