[INFO] updating cached repository golf1052/rustdns
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/golf1052/rustdns
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/golf1052/rustdns" "work/ex/clippy-test-run/sources/stable/gh/golf1052/rustdns"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/golf1052/rustdns'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/golf1052/rustdns" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/golf1052/rustdns"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/golf1052/rustdns'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 423b6610a46fecc1f7ad0e85d4fb91a0dcf94b7f
[INFO] sha for GitHub repo golf1052/rustdns: 423b6610a46fecc1f7ad0e85d4fb91a0dcf94b7f
[INFO] validating manifest of golf1052/rustdns on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of golf1052/rustdns on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing golf1052/rustdns
[INFO] finished frobbing golf1052/rustdns
[INFO] frobbed toml for golf1052/rustdns written to work/ex/clippy-test-run/sources/stable/gh/golf1052/rustdns/Cargo.toml
[INFO] started frobbing golf1052/rustdns
[INFO] finished frobbing golf1052/rustdns
[INFO] frobbed toml for golf1052/rustdns written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/golf1052/rustdns/Cargo.toml
[INFO] crate golf1052/rustdns has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting golf1052/rustdns against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/golf1052/rustdns:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 67278cfe3f507653580a60cde640285ec36457e123e2c2732a20ecc1ee694c85
[INFO] running `"docker" "start" "-a" "67278cfe3f507653580a60cde640285ec36457e123e2c2732a20ecc1ee694c85"`
[INFO] [stderr]     Checking rustdns v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:288:13
[INFO] [stderr]     |
[INFO] [stderr] 288 |             rdlength: rdlength,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `rdlength`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:288:13
[INFO] [stderr]     |
[INFO] [stderr] 288 |             rdlength: rdlength,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `rdlength`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:433:20
[INFO] [stderr]     |
[INFO] [stderr] 433 |         assert_eq!(1000000, to_u32(&vec));
[INFO] [stderr]     |                    ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `dump_packet`
[INFO] [stderr]    --> src/main.rs:385:1
[INFO] [stderr]     |
[INFO] [stderr] 385 | fn dump_packet(data: &[u8]) {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `get_char`
[INFO] [stderr]    --> src/main.rs:404:1
[INFO] [stderr]     |
[INFO] [stderr] 404 | fn get_char(datum: u8) -> char {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `data`
[INFO] [stderr]    --> src/main.rs:250:14
[INFO] [stderr]     |
[INFO] [stderr] 250 |     for i in HEADER_SIZE..data.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 250 |     for (i, <item>) in data.iter().enumerate().skip(HEADER_SIZE) {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `data`
[INFO] [stderr]    --> src/main.rs:269:18
[INFO] [stderr]     |
[INFO] [stderr] 269 |         for i in answer_start..data.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 269 |         for (i, <item>) in data.iter().enumerate().skip(answer_start) {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:315:18
[INFO] [stderr]     |
[INFO] [stderr] 315 |         value |= *byte as u16 & 0xff;
[INFO] [stderr]     |                  ^^^^^^^^^^^^ help: try: `u16::from(*byte)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:324:18
[INFO] [stderr]     |
[INFO] [stderr] 324 |         value |= *byte as u32 & 0xff;
[INFO] [stderr]     |                  ^^^^^^^^^^^^ help: try: `u32::from(*byte)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/main.rs:334:33
[INFO] [stderr]     |
[INFO] [stderr] 334 |             let offset = to_u16(&vec![datum & 0x30, data[i + 1]]);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[datum & 0x30, data[i + 1]]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:351:16
[INFO] [stderr]     |
[INFO] [stderr] 351 |             if found_data.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!found_data.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/main.rs:353:42
[INFO] [stderr]     |
[INFO] [stderr] 353 |                 let offset: u16 = to_u16(&vec![datum & 0x30, data[i + 1]]);
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[datum & 0x30, data[i + 1]]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:372:16
[INFO] [stderr]     |
[INFO] [stderr] 372 |             if name.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:399:8
[INFO] [stderr]     |
[INFO] [stderr] 399 |     if chars.len() != 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chars.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `dump_packet`
[INFO] [stderr]    --> src/main.rs:385:1
[INFO] [stderr]     |
[INFO] [stderr] 385 | fn dump_packet(data: &[u8]) {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `get_char`
[INFO] [stderr]    --> src/main.rs:404:1
[INFO] [stderr]     |
[INFO] [stderr] 404 | fn get_char(datum: u8) -> char {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `data`
[INFO] [stderr]    --> src/main.rs:250:14
[INFO] [stderr]     |
[INFO] [stderr] 250 |     for i in HEADER_SIZE..data.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 250 |     for (i, <item>) in data.iter().enumerate().skip(HEADER_SIZE) {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `data`
[INFO] [stderr]    --> src/main.rs:269:18
[INFO] [stderr]     |
[INFO] [stderr] 269 |         for i in answer_start..data.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 269 |         for (i, <item>) in data.iter().enumerate().skip(answer_start) {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:315:18
[INFO] [stderr]     |
[INFO] [stderr] 315 |         value |= *byte as u16 & 0xff;
[INFO] [stderr]     |                  ^^^^^^^^^^^^ help: try: `u16::from(*byte)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:324:18
[INFO] [stderr]     |
[INFO] [stderr] 324 |         value |= *byte as u32 & 0xff;
[INFO] [stderr]     |                  ^^^^^^^^^^^^ help: try: `u32::from(*byte)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/main.rs:334:33
[INFO] [stderr]     |
[INFO] [stderr] 334 |             let offset = to_u16(&vec![datum & 0x30, data[i + 1]]);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[datum & 0x30, data[i + 1]]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:351:16
[INFO] [stderr]     |
[INFO] [stderr] 351 |             if found_data.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!found_data.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/main.rs:353:42
[INFO] [stderr]     |
[INFO] [stderr] 353 |                 let offset: u16 = to_u16(&vec![datum & 0x30, data[i + 1]]);
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[datum & 0x30, data[i + 1]]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:372:16
[INFO] [stderr]     |
[INFO] [stderr] 372 |             if name.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:399:8
[INFO] [stderr]     |
[INFO] [stderr] 399 |     if chars.len() != 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chars.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.47s
[INFO] running `"docker" "inspect" "67278cfe3f507653580a60cde640285ec36457e123e2c2732a20ecc1ee694c85"`
[INFO] running `"docker" "rm" "-f" "67278cfe3f507653580a60cde640285ec36457e123e2c2732a20ecc1ee694c85"`
[INFO] [stdout] 67278cfe3f507653580a60cde640285ec36457e123e2c2732a20ecc1ee694c85