[INFO] updating cached repository gmnash/advent_of_code
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/gmnash/advent_of_code
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/gmnash/advent_of_code" "work/ex/clippy-test-run/sources/stable/gh/gmnash/advent_of_code"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gmnash/advent_of_code'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/gmnash/advent_of_code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmnash/advent_of_code"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmnash/advent_of_code'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 250e06b6ff446bc0da41d9229e3db7feb1dc8d55
[INFO] sha for GitHub repo gmnash/advent_of_code: 250e06b6ff446bc0da41d9229e3db7feb1dc8d55
[INFO] validating manifest of gmnash/advent_of_code on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gmnash/advent_of_code on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gmnash/advent_of_code
[INFO] finished frobbing gmnash/advent_of_code
[INFO] frobbed toml for gmnash/advent_of_code written to work/ex/clippy-test-run/sources/stable/gh/gmnash/advent_of_code/Cargo.toml
[INFO] started frobbing gmnash/advent_of_code
[INFO] finished frobbing gmnash/advent_of_code
[INFO] frobbed toml for gmnash/advent_of_code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmnash/advent_of_code/Cargo.toml
[INFO] crate gmnash/advent_of_code has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gmnash/advent_of_code against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmnash/advent_of_code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 53ae632816b72c7b710f6191347fb5f0255893f2c4371b559d2467fe41bf1f1c
[INFO] running `"docker" "start" "-a" "53ae632816b72c7b710f6191347fb5f0255893f2c4371b559d2467fe41bf1f1c"`
[INFO] [stderr]     Checking advent_of_code v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/day_02.rs:14:17
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let mut d = Vec::new();
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/day_02.rs:14:17
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let mut d = Vec::new();
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_01.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return current_floor;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_floor`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_01.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     return index;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `index`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_02.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return total_area;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `total_area`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_02.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     return total_area;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `total_area`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_01.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return current_floor;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_floor`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_01.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     return index;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `index`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_02.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 |     return total_area;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `total_area`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day_02.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 |     return total_area;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `total_area`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/day_02.rs:19:37
[INFO] [stderr]    |
[INFO] [stderr] 19 |         let all_sides = 2 * d.iter().fold(0, |sum, x| sum + x);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/day_02.rs:40:27
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let bow = d.iter().fold(1, |product, x| product * x);
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/day_02.rs:19:37
[INFO] [stderr]    |
[INFO] [stderr] 19 |         let all_sides = 2 * d.iter().fold(0, |sum, x| sum + x);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/day_02.rs:40:27
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let bow = d.iter().fold(1, |product, x| product * x);
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/test_day_02.rs:15:16
[INFO] [stderr]    |
[INFO] [stderr] 15 |     assert_eq!(1586300, day_02::amount_of_paper(&s));
[INFO] [stderr]    |                ^^^^^^^ help: consider: `1_586_300`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/test_day_02.rs:25:16
[INFO] [stderr]    |
[INFO] [stderr] 25 |     assert_eq!(3737498, day_02::amount_of_ribbon(&s));
[INFO] [stderr]    |                ^^^^^^^ help: consider: `3_737_498`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.82s
[INFO] running `"docker" "inspect" "53ae632816b72c7b710f6191347fb5f0255893f2c4371b559d2467fe41bf1f1c"`
[INFO] running `"docker" "rm" "-f" "53ae632816b72c7b710f6191347fb5f0255893f2c4371b559d2467fe41bf1f1c"`
[INFO] [stdout] 53ae632816b72c7b710f6191347fb5f0255893f2c4371b559d2467fe41bf1f1c