[INFO] updating cached repository gmadrid/hunt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gmadrid/hunt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gmadrid/hunt" "work/ex/clippy-test-run/sources/stable/gh/gmadrid/hunt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gmadrid/hunt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gmadrid/hunt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmadrid/hunt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmadrid/hunt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 14df5827c274006a4a8691ed300a4044caee88ac [INFO] sha for GitHub repo gmadrid/hunt: 14df5827c274006a4a8691ed300a4044caee88ac [INFO] validating manifest of gmadrid/hunt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gmadrid/hunt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gmadrid/hunt [INFO] finished frobbing gmadrid/hunt [INFO] frobbed toml for gmadrid/hunt written to work/ex/clippy-test-run/sources/stable/gh/gmadrid/hunt/Cargo.toml [INFO] started frobbing gmadrid/hunt [INFO] finished frobbing gmadrid/hunt [INFO] frobbed toml for gmadrid/hunt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmadrid/hunt/Cargo.toml [INFO] crate gmadrid/hunt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gmadrid/hunt against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gmadrid/hunt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 239ef7821260d7f54d4ea88d7e740a6313368cbfaee0402d6aa32eac55ddbfa0 [INFO] running `"docker" "start" "-a" "239ef7821260d7f54d4ea88d7e740a6313368cbfaee0402d6aa32eac55ddbfa0"` [INFO] [stderr] Checking clap v2.14.0 [INFO] [stderr] Checking hunt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hunt/board.rs:83:7 [INFO] [stderr] | [INFO] [stderr] 83 | possible_cells: possible_cells, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `possible_cells` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hunt/board.rs:84:7 [INFO] [stderr] | [INFO] [stderr] 84 | dead_cells: dead_cells, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dead_cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/hunt/board.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | print!("{}", "."); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/hunt/board.rs:101:7 [INFO] [stderr] | [INFO] [stderr] 101 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hunt/coord.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hunt/coord.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hunt/board.rs:83:7 [INFO] [stderr] | [INFO] [stderr] 83 | possible_cells: possible_cells, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `possible_cells` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hunt/board.rs:84:7 [INFO] [stderr] | [INFO] [stderr] 84 | dead_cells: dead_cells, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dead_cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/hunt/board.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | print!("{}", "."); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/hunt/board.rs:101:7 [INFO] [stderr] | [INFO] [stderr] 101 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hunt/coord.rs:14:7 [INFO] [stderr] | [INFO] [stderr] 14 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hunt/coord.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hunt/board.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | b [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 231 | let board = board!(3; 4; (1, 2), (2, 3), (0, 0)); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hunt/board.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | let b = Board::new($rows, $cols, dead_cells); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 231 | let board = board!(3; 4; (1, 2), (2, 3), (0, 0)); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/hunt/board.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / macro_rules! board { [INFO] [stderr] 12 | | ( $rows:expr ; $cols:expr) => { Board::new($rows, $cols, HashSet::::new()) }; [INFO] [stderr] 13 | | ( $rows:expr ; $cols:expr ; $($c:expr), *) => { [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/hunt/board.rs:170:1 [INFO] [stderr] | [INFO] [stderr] 170 | / macro_rules! assert_has_coords { [INFO] [stderr] 171 | | ( $coords:expr , $($c:expr), *) => { [INFO] [stderr] 172 | | { [INFO] [stderr] 173 | | let coord_set_in = HashSet::::from_iter($coords.into_iter()); [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hunt/coord.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn move_in_direction(&self, dir: Direction) -> Coord { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hunt/coord.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn move_in_direction(&self, dir: Direction) -> Coord { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.30s [INFO] running `"docker" "inspect" "239ef7821260d7f54d4ea88d7e740a6313368cbfaee0402d6aa32eac55ddbfa0"` [INFO] running `"docker" "rm" "-f" "239ef7821260d7f54d4ea88d7e740a6313368cbfaee0402d6aa32eac55ddbfa0"` [INFO] [stdout] 239ef7821260d7f54d4ea88d7e740a6313368cbfaee0402d6aa32eac55ddbfa0