[INFO] updating cached repository gluyas/niwa-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gluyas/niwa-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gluyas/niwa-rs" "work/ex/clippy-test-run/sources/stable/gh/gluyas/niwa-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gluyas/niwa-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gluyas/niwa-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gluyas/niwa-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gluyas/niwa-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bed97251b7a0b4b40881cc8e92755c9c225fd876 [INFO] sha for GitHub repo gluyas/niwa-rs: bed97251b7a0b4b40881cc8e92755c9c225fd876 [INFO] validating manifest of gluyas/niwa-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gluyas/niwa-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gluyas/niwa-rs [INFO] finished frobbing gluyas/niwa-rs [INFO] frobbed toml for gluyas/niwa-rs written to work/ex/clippy-test-run/sources/stable/gh/gluyas/niwa-rs/Cargo.toml [INFO] started frobbing gluyas/niwa-rs [INFO] finished frobbing gluyas/niwa-rs [INFO] frobbed toml for gluyas/niwa-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gluyas/niwa-rs/Cargo.toml [INFO] crate gluyas/niwa-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gluyas/niwa-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gluyas/niwa-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ffdf2bd55b9247ea5ea26a51b7d3d41125c5bd2ae5914ad6eb7920cfd7234a32 [INFO] running `"docker" "start" "-a" "ffdf2bd55b9247ea5ea26a51b7d3d41125c5bd2ae5914ad6eb7920cfd7234a32"` [INFO] [stderr] Checking niwa-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/util.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | *self += (-rhs.into()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:131:24 [INFO] [stderr] | [INFO] [stderr] 131 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 132 | | if let PuzzleStatus::Virgin = puzzle.regions[cell.region] { [INFO] [stderr] 133 | | print!("{}", cell.get_symbol_virgin()); [INFO] [stderr] 134 | | } else { [INFO] [stderr] 135 | | print!("{}", cell.get_symbol_exhausted()); [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 131 | } else if let PuzzleStatus::Virgin = puzzle.regions[cell.region] { [INFO] [stderr] 132 | print!("{}", cell.get_symbol_virgin()); [INFO] [stderr] 133 | } else { [INFO] [stderr] 134 | print!("{}", cell.get_symbol_exhausted()); [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/util.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | *self += (-rhs.into()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:131:24 [INFO] [stderr] | [INFO] [stderr] 131 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 132 | | if let PuzzleStatus::Virgin = puzzle.regions[cell.region] { [INFO] [stderr] 133 | | print!("{}", cell.get_symbol_virgin()); [INFO] [stderr] 134 | | } else { [INFO] [stderr] 135 | | print!("{}", cell.get_symbol_exhausted()); [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 131 | } else if let PuzzleStatus::Virgin = puzzle.regions[cell.region] { [INFO] [stderr] 132 | print!("{}", cell.get_symbol_virgin()); [INFO] [stderr] 133 | } else { [INFO] [stderr] 134 | print!("{}", cell.get_symbol_exhausted()); [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `nudge` [INFO] [stderr] --> src/util.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn nudge(self, dir: Direction) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `snap_to_edge` [INFO] [stderr] --> src/util.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn snap_to_edge > (mut self, dir: Direction, bounds: P) -> GridIndex { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter_rect` [INFO] [stderr] --> src/util.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | pub fn iter_rect(self, dir_primary: Direction, dir_secondary: Direction) -> RectIterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_within` [INFO] [stderr] --> src/util.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn is_within > (self, bound: P) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `component_add` [INFO] [stderr] --> src/util.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | pub fn component_add > (self, other: P) -> GridIndex { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `component_diff` [INFO] [stderr] --> src/util.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | pub fn component_diff > (self, other: P) -> GridIndex { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `RectIterator` [INFO] [stderr] --> src/util.rs:234:1 [INFO] [stderr] | [INFO] [stderr] 234 | pub struct RectIterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/util.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | pub fn new > (range: P, dir_primary: Direction, dir_secondary: Direction) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `of` [INFO] [stderr] --> src/util.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | pub fn of > (size: P, val: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Dirt` [INFO] [stderr] --> src/world.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | Dirt, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Sand` [INFO] [stderr] --> src/world.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Sand, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Stone` [INFO] [stderr] --> src/world.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Stone, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Water` [INFO] [stderr] --> src/world.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | Water, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_blocked` [INFO] [stderr] --> src/puzzle.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn is_blocked > (&self, pos: P, dir: Direction) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Complete` [INFO] [stderr] --> src/puzzle.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | Complete, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_walls` [INFO] [stderr] --> src/puzzle.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn set_walls(&mut self, dirs: &[Direction]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/util.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | self + dir; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/util.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | self + dir; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:341:59 [INFO] [stderr] | [INFO] [stderr] 341 | self.data.get_unchecked(self.linear_index(index.into())) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:354:54 [INFO] [stderr] | [INFO] [stderr] 354 | let linear_index = self.linear_index(index.into()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/main.rs:67:34 [INFO] [stderr] | [INFO] [stderr] 67 | .map_or(true, |cell| { cell.plant.is_none() }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | fn cast_spell(dir: Direction, player: &GridIndex, room: &Room, puzzle: &mut PuzzleGrid) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `GridIndex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/main.rs:81:49 [INFO] [stderr] | [INFO] [stderr] 81 | if !room.tiles[pos].as_ref().map(|tile| { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 82 | | match tile.material { [INFO] [stderr] 83 | | Material::Grass | Material::Dirt => true, [INFO] [stderr] 84 | | _ => false [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | }).unwrap_or(false) { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: method is never used: `nudge` [INFO] [stderr] --> src/util.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn nudge(self, dir: Direction) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `snap_to_edge` [INFO] [stderr] --> src/util.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn snap_to_edge > (mut self, dir: Direction, bounds: P) -> GridIndex { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter_rect` [INFO] [stderr] --> src/util.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | pub fn iter_rect(self, dir_primary: Direction, dir_secondary: Direction) -> RectIterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_within` [INFO] [stderr] --> src/util.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn is_within > (self, bound: P) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `component_add` [INFO] [stderr] --> src/util.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | pub fn component_add > (self, other: P) -> GridIndex { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `component_diff` [INFO] [stderr] --> src/util.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | pub fn component_diff > (self, other: P) -> GridIndex { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `RectIterator` [INFO] [stderr] --> src/util.rs:234:1 [INFO] [stderr] | [INFO] [stderr] 234 | pub struct RectIterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/util.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | pub fn new > (range: P, dir_primary: Direction, dir_secondary: Direction) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `of` [INFO] [stderr] --> src/util.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | pub fn of > (size: P, val: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Dirt` [INFO] [stderr] --> src/world.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | Dirt, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Sand` [INFO] [stderr] --> src/world.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Sand, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Stone` [INFO] [stderr] --> src/world.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Stone, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Water` [INFO] [stderr] --> src/world.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | Water, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_blocked` [INFO] [stderr] --> src/puzzle.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn is_blocked > (&self, pos: P, dir: Direction) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Complete` [INFO] [stderr] --> src/puzzle.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | Complete, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_walls` [INFO] [stderr] --> src/puzzle.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn set_walls(&mut self, dirs: &[Direction]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> src/util.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | self + dir; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/util.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | self + dir; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:341:59 [INFO] [stderr] | [INFO] [stderr] 341 | self.data.get_unchecked(self.linear_index(index.into())) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:354:54 [INFO] [stderr] | [INFO] [stderr] 354 | let linear_index = self.linear_index(index.into()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/main.rs:67:34 [INFO] [stderr] | [INFO] [stderr] 67 | .map_or(true, |cell| { cell.plant.is_none() }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | fn cast_spell(dir: Direction, player: &GridIndex, room: &Room, puzzle: &mut PuzzleGrid) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `GridIndex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/main.rs:81:49 [INFO] [stderr] | [INFO] [stderr] 81 | if !room.tiles[pos].as_ref().map(|tile| { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 82 | | match tile.material { [INFO] [stderr] 83 | | Material::Grass | Material::Dirt => true, [INFO] [stderr] 84 | | _ => false [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | }).unwrap_or(false) { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `"docker" "inspect" "ffdf2bd55b9247ea5ea26a51b7d3d41125c5bd2ae5914ad6eb7920cfd7234a32"` [INFO] running `"docker" "rm" "-f" "ffdf2bd55b9247ea5ea26a51b7d3d41125c5bd2ae5914ad6eb7920cfd7234a32"` [INFO] [stdout] ffdf2bd55b9247ea5ea26a51b7d3d41125c5bd2ae5914ad6eb7920cfd7234a32