[INFO] updating cached repository gilesv/minigrep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gilesv/minigrep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gilesv/minigrep" "work/ex/clippy-test-run/sources/stable/gh/gilesv/minigrep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gilesv/minigrep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gilesv/minigrep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gilesv/minigrep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gilesv/minigrep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e9e150a27557533869fcb33473b8c9a5d454cdb8 [INFO] sha for GitHub repo gilesv/minigrep: e9e150a27557533869fcb33473b8c9a5d454cdb8 [INFO] validating manifest of gilesv/minigrep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gilesv/minigrep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gilesv/minigrep [INFO] finished frobbing gilesv/minigrep [INFO] frobbed toml for gilesv/minigrep written to work/ex/clippy-test-run/sources/stable/gh/gilesv/minigrep/Cargo.toml [INFO] started frobbing gilesv/minigrep [INFO] finished frobbing gilesv/minigrep [INFO] frobbed toml for gilesv/minigrep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gilesv/minigrep/Cargo.toml [INFO] crate gilesv/minigrep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gilesv/minigrep against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gilesv/minigrep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e43a2476e7d6fffa604be3657ec3c91346cbfc551c27eaa87307c2b3cfc656a2 [INFO] running `"docker" "start" "-a" "e43a2476e7d6fffa604be3657ec3c91346cbfc551c27eaa87307c2b3cfc656a2"` [INFO] [stderr] Checking minigrep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:70:16 [INFO] [stderr] | [INFO] [stderr] 70 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 71 | | if line.to_lowercase().contains(&query.to_lowercase()) { [INFO] [stderr] 72 | | results.push(Line::new(line_number, &line)); [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 70 | } else if line.to_lowercase().contains(&query.to_lowercase()) { [INFO] [stderr] 71 | results.push(Line::new(line_number, &line)); [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:70:16 [INFO] [stderr] | [INFO] [stderr] 70 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 71 | | if line.to_lowercase().contains(&query.to_lowercase()) { [INFO] [stderr] 72 | | results.push(Line::new(line_number, &line)); [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 70 | } else if line.to_lowercase().contains(&query.to_lowercase()) { [INFO] [stderr] 71 | results.push(Line::new(line_number, &line)); [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match minigrep::run(config) { [INFO] [stderr] 18 | | Err(e) => { [INFO] [stderr] 19 | | println!("Application error: {}", e); [INFO] [stderr] 20 | | process::exit(1); [INFO] [stderr] 21 | | }, [INFO] [stderr] 22 | | Ok(_) => {} [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | if let Err(e) = minigrep::run(config) { [INFO] [stderr] 18 | println!("Application error: {}", e); [INFO] [stderr] 19 | process::exit(1); [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match minigrep::run(config) { [INFO] [stderr] 18 | | Err(e) => { [INFO] [stderr] 19 | | println!("Application error: {}", e); [INFO] [stderr] 20 | | process::exit(1); [INFO] [stderr] 21 | | }, [INFO] [stderr] 22 | | Ok(_) => {} [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | if let Err(e) = minigrep::run(config) { [INFO] [stderr] 18 | println!("Application error: {}", e); [INFO] [stderr] 19 | process::exit(1); [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `"docker" "inspect" "e43a2476e7d6fffa604be3657ec3c91346cbfc551c27eaa87307c2b3cfc656a2"` [INFO] running `"docker" "rm" "-f" "e43a2476e7d6fffa604be3657ec3c91346cbfc551c27eaa87307c2b3cfc656a2"` [INFO] [stdout] e43a2476e7d6fffa604be3657ec3c91346cbfc551c27eaa87307c2b3cfc656a2