[INFO] updating cached repository gdeb/calculator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gdeb/calculator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gdeb/calculator" "work/ex/clippy-test-run/sources/stable/gh/gdeb/calculator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gdeb/calculator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gdeb/calculator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gdeb/calculator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gdeb/calculator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 06430755e93f1dc7bc64da104bf2388565e877ae [INFO] sha for GitHub repo gdeb/calculator: 06430755e93f1dc7bc64da104bf2388565e877ae [INFO] validating manifest of gdeb/calculator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gdeb/calculator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gdeb/calculator [INFO] finished frobbing gdeb/calculator [INFO] frobbed toml for gdeb/calculator written to work/ex/clippy-test-run/sources/stable/gh/gdeb/calculator/Cargo.toml [INFO] started frobbing gdeb/calculator [INFO] finished frobbing gdeb/calculator [INFO] frobbed toml for gdeb/calculator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gdeb/calculator/Cargo.toml [INFO] crate gdeb/calculator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gdeb/calculator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gdeb/calculator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 52610ed4b8a4f05929d4f71007721515aef89b448b87c6b8cca19e9d89a5f04e [INFO] running `"docker" "start" "-a" "52610ed4b8a4f05929d4f71007721515aef89b448b87c6b8cca19e9d89a5f04e"` [INFO] [stderr] Checking calculator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / match token { [INFO] [stderr] 40 | | &Token::Number(_) => 0, [INFO] [stderr] 41 | | &Token::LeftParen => 5, [INFO] [stderr] 42 | | &Token::RightParen => 5, [INFO] [stderr] ... | [INFO] [stderr] 46 | | &Token::InvalidToken => 0, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *token { [INFO] [stderr] 40 | Token::Number(_) => 0, [INFO] [stderr] 41 | Token::LeftParen => 5, [INFO] [stderr] 42 | Token::RightParen => 5, [INFO] [stderr] 43 | Token::Operator(Operator::Add) => 15, [INFO] [stderr] 44 | Token::Operator(Operator::Substract) => 15, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match ast { [INFO] [stderr] 9 | | &AST::Value(n) => n as isize, [INFO] [stderr] 10 | | &AST::Operator(Operator::Add, ref left, ref right) => { [INFO] [stderr] 11 | | evaluate_ast(&*left) + evaluate_ast(&*right) [INFO] [stderr] ... | [INFO] [stderr] 18 | | }, [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 8 | match *ast { [INFO] [stderr] 9 | AST::Value(n) => n as isize, [INFO] [stderr] 10 | AST::Operator(Operator::Add, ref left, ref right) => { [INFO] [stderr] 11 | evaluate_ast(&*left) + evaluate_ast(&*right) [INFO] [stderr] 12 | }, [INFO] [stderr] 13 | AST::Operator(Operator::Substract, ref left, ref right) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / match token { [INFO] [stderr] 40 | | &Token::Number(_) => 0, [INFO] [stderr] 41 | | &Token::LeftParen => 5, [INFO] [stderr] 42 | | &Token::RightParen => 5, [INFO] [stderr] ... | [INFO] [stderr] 46 | | &Token::InvalidToken => 0, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *token { [INFO] [stderr] 40 | Token::Number(_) => 0, [INFO] [stderr] 41 | Token::LeftParen => 5, [INFO] [stderr] 42 | Token::RightParen => 5, [INFO] [stderr] 43 | Token::Operator(Operator::Add) => 15, [INFO] [stderr] 44 | Token::Operator(Operator::Substract) => 15, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match ast { [INFO] [stderr] 9 | | &AST::Value(n) => n as isize, [INFO] [stderr] 10 | | &AST::Operator(Operator::Add, ref left, ref right) => { [INFO] [stderr] 11 | | evaluate_ast(&*left) + evaluate_ast(&*right) [INFO] [stderr] ... | [INFO] [stderr] 18 | | }, [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 8 | match *ast { [INFO] [stderr] 9 | AST::Value(n) => n as isize, [INFO] [stderr] 10 | AST::Operator(Operator::Add, ref left, ref right) => { [INFO] [stderr] 11 | evaluate_ast(&*left) + evaluate_ast(&*right) [INFO] [stderr] 12 | }, [INFO] [stderr] 13 | AST::Operator(Operator::Substract, ref left, ref right) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "52610ed4b8a4f05929d4f71007721515aef89b448b87c6b8cca19e9d89a5f04e"` [INFO] running `"docker" "rm" "-f" "52610ed4b8a4f05929d4f71007721515aef89b448b87c6b8cca19e9d89a5f04e"` [INFO] [stdout] 52610ed4b8a4f05929d4f71007721515aef89b448b87c6b8cca19e9d89a5f04e