[INFO] updating cached repository gcouvrette/peek [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gcouvrette/peek [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gcouvrette/peek" "work/ex/clippy-test-run/sources/stable/gh/gcouvrette/peek"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gcouvrette/peek'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gcouvrette/peek" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gcouvrette/peek"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gcouvrette/peek'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3836d3de885e395f5db923df9df683db24882f48 [INFO] sha for GitHub repo gcouvrette/peek: 3836d3de885e395f5db923df9df683db24882f48 [INFO] validating manifest of gcouvrette/peek on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gcouvrette/peek on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gcouvrette/peek [INFO] finished frobbing gcouvrette/peek [INFO] frobbed toml for gcouvrette/peek written to work/ex/clippy-test-run/sources/stable/gh/gcouvrette/peek/Cargo.toml [INFO] started frobbing gcouvrette/peek [INFO] finished frobbing gcouvrette/peek [INFO] frobbed toml for gcouvrette/peek written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gcouvrette/peek/Cargo.toml [INFO] crate gcouvrette/peek has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gcouvrette/peek against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gcouvrette/peek:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a01f1d584c17d82e2b3de96c7be951481ca5d3621d7a7bd7ea2197ed172441f1 [INFO] running `"docker" "start" "-a" "a01f1d584c17d82e2b3de96c7be951481ca5d3621d7a7bd7ea2197ed172441f1"` [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking getch v0.1.1 [INFO] [stderr] Checking peek v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod read_mode; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | pub mod read_mode; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/read_mode/read_mode.rs:29:60 [INFO] [stderr] | [INFO] [stderr] 29 | let buffer = usize::from_str(&args.pop_front().unwrap_or("3200".to_owned())).map_err(|_|"Buffer length is not a number.")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "3200".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/read_mode/read_mode.rs:33:59 [INFO] [stderr] | [INFO] [stderr] 33 | let width = usize::from_str(&args.pop_front().unwrap_or("80".to_owned())).map_err(|_|"Width is not a number.")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "80".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/read_mode/read_mode.rs:34:60 [INFO] [stderr] | [INFO] [stderr] 34 | let height = usize::from_str(&args.pop_front().unwrap_or("40".to_owned())).map_err(|_|"Height is not a number.")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "40".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/read_mode/linear_mode.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | self.file.seek(SeekFrom::Start(self.index)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/read_mode/linear_mode.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | self.file.read(buf.as_mut_slice()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/read_mode/multiline_mode.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | self.file.seek(SeekFrom::Start(seek_idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/read_mode/multiline_mode.rs:44:38 [INFO] [stderr] | [INFO] [stderr] 44 | {last_seek_idx = self.line_history.last().unwrap().clone();} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.line_history.last().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/read_mode/read_mode.rs:29:60 [INFO] [stderr] | [INFO] [stderr] 29 | let buffer = usize::from_str(&args.pop_front().unwrap_or("3200".to_owned())).map_err(|_|"Buffer length is not a number.")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "3200".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/read_mode/read_mode.rs:33:59 [INFO] [stderr] | [INFO] [stderr] 33 | let width = usize::from_str(&args.pop_front().unwrap_or("80".to_owned())).map_err(|_|"Width is not a number.")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "80".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/read_mode/read_mode.rs:34:60 [INFO] [stderr] | [INFO] [stderr] 34 | let height = usize::from_str(&args.pop_front().unwrap_or("40".to_owned())).map_err(|_|"Height is not a number.")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "40".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/read_mode/linear_mode.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | self.file.seek(SeekFrom::Start(self.index)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/read_mode/linear_mode.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | self.file.read(buf.as_mut_slice()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/read_mode/multiline_mode.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | self.file.seek(SeekFrom::Start(seek_idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/read_mode/multiline_mode.rs:44:38 [INFO] [stderr] | [INFO] [stderr] 44 | {last_seek_idx = self.line_history.last().unwrap().clone();} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.line_history.last().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.82s [INFO] running `"docker" "inspect" "a01f1d584c17d82e2b3de96c7be951481ca5d3621d7a7bd7ea2197ed172441f1"` [INFO] running `"docker" "rm" "-f" "a01f1d584c17d82e2b3de96c7be951481ca5d3621d7a7bd7ea2197ed172441f1"` [INFO] [stdout] a01f1d584c17d82e2b3de96c7be951481ca5d3621d7a7bd7ea2197ed172441f1