[INFO] updating cached repository gavynriebau/xor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/gavynriebau/xor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/gavynriebau/xor" "work/ex/clippy-test-run/sources/stable/gh/gavynriebau/xor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/gavynriebau/xor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/gavynriebau/xor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gavynriebau/xor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gavynriebau/xor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d8ba3542eac060b79c0114a3475258e9fe0a63c9 [INFO] sha for GitHub repo gavynriebau/xor: d8ba3542eac060b79c0114a3475258e9fe0a63c9 [INFO] validating manifest of gavynriebau/xor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gavynriebau/xor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gavynriebau/xor [INFO] finished frobbing gavynriebau/xor [INFO] frobbed toml for gavynriebau/xor written to work/ex/clippy-test-run/sources/stable/gh/gavynriebau/xor/Cargo.toml [INFO] started frobbing gavynriebau/xor [INFO] finished frobbing gavynriebau/xor [INFO] frobbed toml for gavynriebau/xor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gavynriebau/xor/Cargo.toml [INFO] crate gavynriebau/xor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gavynriebau/xor against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/gavynriebau/xor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 56e69ca0b96fda921170669bcfc81c2e1cd4a989f5dc83fb16ff04c71d6b7586 [INFO] running `"docker" "start" "-a" "56e69ca0b96fda921170669bcfc81c2e1cd4a989f5dc83fb16ff04c71d6b7586"` [INFO] [stderr] Checking rand v0.3.18 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking number_prefix v0.2.7 [INFO] [stderr] Checking xor-utils v0.6.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking textwrap v0.6.0 [INFO] [stderr] Checking clap v2.25.0 [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] Checking filesystem v0.4.2 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking xor v1.4.5 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/stdout_writer.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | const ERR_ENCODED_DATA_NOT_UTF8 : &'static str = r#"ERROR: Encoded data isn't printable. [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cursor` [INFO] [stderr] --> src/main.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | use std::io::{Write, Read, Cursor}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/stdout_writer.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | const ERR_ENCODED_DATA_NOT_UTF8 : &'static str = r#"ERROR: Encoded data isn't printable. [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mode` [INFO] [stderr] --> src/main.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | let mode = if matches.is_present("decrypt") { [INFO] [stderr] | ^^^^ help: consider using `_mode` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key_bytes` [INFO] [stderr] --> src/main.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | let key_bytes = get_key_bytes(&matches); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_key_bytes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:310:22 [INFO] [stderr] | [INFO] [stderr] 310 | fn get_key_bytes<'a>(matches: &'a ArgMatches<'a>) -> Vec { [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | let mut key_bytes : Vec = Vec::new(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `StdoutWriter` [INFO] [stderr] --> src/stdout_writer.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct StdoutWriter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `encrypt_reader` [INFO] [stderr] --> src/main.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | fn encrypt_reader(input : &mut Read, key : &Vec, output : &mut Write) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `xor_file` [INFO] [stderr] --> src/main.rs:185:1 [INFO] [stderr] | [INFO] [stderr] 185 | fn xor_file(fs : &T, file_path : &Path, key : &Vec, mode : &Mode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `xor_dir` [INFO] [stderr] --> src/main.rs:203:1 [INFO] [stderr] | [INFO] [stderr] 203 | fn xor_dir(fs : &T, dir_path : &Path, key : &Vec, mode : &Mode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `rename_entry` [INFO] [stderr] --> src/main.rs:237:1 [INFO] [stderr] | [INFO] [stderr] 237 | fn rename_entry(fs : &T, entry : &Path, key : &Vec, mode : &Mode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `repeat_key` [INFO] [stderr] --> src/main.rs:281:1 [INFO] [stderr] | [INFO] [stderr] 281 | fn repeat_key(key : &Vec, required_len : usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `to_hex_string` [INFO] [stderr] --> src/main.rs:297:1 [INFO] [stderr] | [INFO] [stderr] 297 | fn to_hex_string(bytes: Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `from_hex_string` [INFO] [stderr] --> src/main.rs:306:1 [INFO] [stderr] | [INFO] [stderr] 306 | fn from_hex_string(hex : &String) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `show_prompt` [INFO] [stderr] --> src/main.rs:406:1 [INFO] [stderr] | [INFO] [stderr] 406 | fn show_prompt() -> char { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_keysize_warning` [INFO] [stderr] --> src/main.rs:425:1 [INFO] [stderr] | [INFO] [stderr] 425 | fn print_keysize_warning(key_size : usize, largest_file_size : u64, longest_name : usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:129:16 [INFO] [stderr] | [INFO] [stderr] 129 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 130 | | // trace!("Reading input from stdin."); [INFO] [stderr] 131 | | // let mut stdin_reader = io::stdin(); [INFO] [stderr] 132 | | // encrypt_reader(&mut stdin_reader, &key_bytes, output.deref_mut()); [INFO] [stderr] 133 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:125:40 [INFO] [stderr] | [INFO] [stderr] 125 | if matches.is_present("input") { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 126 | | // trace!("Reading input from a file."); [INFO] [stderr] 127 | | // let mut file_reader= File::open(matches.value_of("input").unwrap()).unwrap(); [INFO] [stderr] 128 | | // encrypt_reader(&mut file_reader, &key_bytes, output.deref_mut()); [INFO] [stderr] 129 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:139:44 [INFO] [stderr] | [INFO] [stderr] 139 | fn encrypt_reader(input : &mut Read, key : &Vec, output : &mut Write) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:185:63 [INFO] [stderr] | [INFO] [stderr] 185 | fn xor_file(fs : &T, file_path : &Path, key : &Vec, mode : &Mode) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:203:61 [INFO] [stderr] | [INFO] [stderr] 203 | fn xor_dir(fs : &T, dir_path : &Path, key : &Vec, mode : &Mode) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:237:63 [INFO] [stderr] | [INFO] [stderr] 237 | fn rename_entry(fs : &T, entry : &Path, key : &Vec, mode : &Mode) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:281:21 [INFO] [stderr] | [INFO] [stderr] 281 | fn repeat_key(key : &Vec, required_len : usize) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:306:26 [INFO] [stderr] | [INFO] [stderr] 306 | fn from_hex_string(hex : &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `xor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `mode` [INFO] [stderr] --> src/main.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | let mode = if matches.is_present("decrypt") { [INFO] [stderr] | ^^^^ help: consider using `_mode` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key_bytes` [INFO] [stderr] --> src/main.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | let key_bytes = get_key_bytes(&matches); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_key_bytes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:310:22 [INFO] [stderr] | [INFO] [stderr] 310 | fn get_key_bytes<'a>(matches: &'a ArgMatches<'a>) -> Vec { [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | let mut key_bytes : Vec = Vec::new(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:529:13 [INFO] [stderr] | [INFO] [stderr] 529 | let mut filenames = get_root_files(&fs); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:556:13 [INFO] [stderr] | [INFO] [stderr] 556 | let mut filenames = get_root_files(&fs); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `StdoutWriter` [INFO] [stderr] --> src/stdout_writer.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct StdoutWriter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `show_prompt` [INFO] [stderr] --> src/main.rs:406:1 [INFO] [stderr] | [INFO] [stderr] 406 | fn show_prompt() -> char { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_keysize_warning` [INFO] [stderr] --> src/main.rs:425:1 [INFO] [stderr] | [INFO] [stderr] 425 | fn print_keysize_warning(key_size : usize, largest_file_size : u64, longest_name : usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:129:16 [INFO] [stderr] | [INFO] [stderr] 129 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 130 | | // trace!("Reading input from stdin."); [INFO] [stderr] 131 | | // let mut stdin_reader = io::stdin(); [INFO] [stderr] 132 | | // encrypt_reader(&mut stdin_reader, &key_bytes, output.deref_mut()); [INFO] [stderr] 133 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:125:40 [INFO] [stderr] | [INFO] [stderr] 125 | if matches.is_present("input") { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 126 | | // trace!("Reading input from a file."); [INFO] [stderr] 127 | | // let mut file_reader= File::open(matches.value_of("input").unwrap()).unwrap(); [INFO] [stderr] 128 | | // encrypt_reader(&mut file_reader, &key_bytes, output.deref_mut()); [INFO] [stderr] 129 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:139:44 [INFO] [stderr] | [INFO] [stderr] 139 | fn encrypt_reader(input : &mut Read, key : &Vec, output : &mut Write) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:185:63 [INFO] [stderr] | [INFO] [stderr] 185 | fn xor_file(fs : &T, file_path : &Path, key : &Vec, mode : &Mode) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:203:61 [INFO] [stderr] | [INFO] [stderr] 203 | fn xor_dir(fs : &T, dir_path : &Path, key : &Vec, mode : &Mode) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:237:63 [INFO] [stderr] | [INFO] [stderr] 237 | fn rename_entry(fs : &T, entry : &Path, key : &Vec, mode : &Mode) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:281:21 [INFO] [stderr] | [INFO] [stderr] 281 | fn repeat_key(key : &Vec, required_len : usize) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:306:26 [INFO] [stderr] | [INFO] [stderr] 306 | fn from_hex_string(hex : &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:519:26 [INFO] [stderr] | [INFO] [stderr] 519 | let input_data = "hello world".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hello world"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:561:37 [INFO] [stderr] | [INFO] [stderr] 561 | assert_eq!(encrypted_bytes, "hello world".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hello world"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `xor`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "56e69ca0b96fda921170669bcfc81c2e1cd4a989f5dc83fb16ff04c71d6b7586"` [INFO] running `"docker" "rm" "-f" "56e69ca0b96fda921170669bcfc81c2e1cd4a989f5dc83fb16ff04c71d6b7586"` [INFO] [stdout] 56e69ca0b96fda921170669bcfc81c2e1cd4a989f5dc83fb16ff04c71d6b7586