[INFO] updating cached repository garyemerson/circular_walk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/garyemerson/circular_walk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/garyemerson/circular_walk" "work/ex/clippy-test-run/sources/stable/gh/garyemerson/circular_walk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/garyemerson/circular_walk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/garyemerson/circular_walk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/circular_walk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/circular_walk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0815ede4471340cf97ed3207bcd4d5b3c09c6e62 [INFO] sha for GitHub repo garyemerson/circular_walk: 0815ede4471340cf97ed3207bcd4d5b3c09c6e62 [INFO] validating manifest of garyemerson/circular_walk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of garyemerson/circular_walk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing garyemerson/circular_walk [INFO] finished frobbing garyemerson/circular_walk [INFO] frobbed toml for garyemerson/circular_walk written to work/ex/clippy-test-run/sources/stable/gh/garyemerson/circular_walk/Cargo.toml [INFO] started frobbing garyemerson/circular_walk [INFO] finished frobbing garyemerson/circular_walk [INFO] frobbed toml for garyemerson/circular_walk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/circular_walk/Cargo.toml [INFO] crate garyemerson/circular_walk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting garyemerson/circular_walk against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/circular_walk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 159bb8fd03f3194804887356723b9fd06a087d70a13d20be36d5d778a4dcb1e0 [INFO] running `"docker" "start" "-a" "159bb8fd03f3194804887356723b9fd06a087d70a13d20be36d5d778a4dcb1e0"` [INFO] [stderr] Checking circular_walk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let (r0, g, seed, p) = (temp[0], temp[1], temp[2], temp[3]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | let mut r: Vec = Vec::with_capacity(n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | let x = (r[i - 1] * g + seed) % p; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:21:14 [INFO] [stderr] | [INFO] [stderr] 21 | Some(h) => { h.to_string() }, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let (r0, g, seed, p) = (temp[0], temp[1], temp[2], temp[3]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | let mut r: Vec = Vec::with_capacity(n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | let x = (r[i - 1] * g + seed) % p; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:21:14 [INFO] [stderr] | [INFO] [stderr] 21 | Some(h) => { h.to_string() }, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | Box::new((start..n).chain((0..(end + 1)))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | Box::new((start..n).chain((0..(end + 1)))) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | Box::new((start..(end + 1))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | Box::new((start..(end + 1))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | Box::new((start..n).chain((0..(end + 1)))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | Box::new((start..n).chain((0..(end + 1)))) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | Box::new((start..(end + 1))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | Box::new((start..(end + 1))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | fn get_min_hops(r: &Vec, n: usize, s: usize, t: usize) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:53:38 [INFO] [stderr] | [INFO] [stderr] 53 | fn get_next_visit(n: usize, visited: &Vec, dist: &Vec>) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:53:56 [INFO] [stderr] | [INFO] [stderr] 53 | fn get_next_visit(n: usize, visited: &Vec, dist: &Vec>) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / let start; [INFO] [stderr] 71 | | if reach > node { [INFO] [stderr] 72 | | start = n - (reach - node); [INFO] [stderr] 73 | | } else { [INFO] [stderr] 74 | | start = node - reach; [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let start = if reach > node { n - (reach - node) } else { node - reach };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | Box::new((start..n).chain((0..(end + 1)))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(0..=end)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | Box::new((start..(end + 1))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `(start..=end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | fn get_min_hops(r: &Vec, n: usize, s: usize, t: usize) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:53:38 [INFO] [stderr] | [INFO] [stderr] 53 | fn get_next_visit(n: usize, visited: &Vec, dist: &Vec>) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:53:56 [INFO] [stderr] | [INFO] [stderr] 53 | fn get_next_visit(n: usize, visited: &Vec, dist: &Vec>) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / let start; [INFO] [stderr] 71 | | if reach > node { [INFO] [stderr] 72 | | start = n - (reach - node); [INFO] [stderr] 73 | | } else { [INFO] [stderr] 74 | | start = node - reach; [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let start = if reach > node { n - (reach - node) } else { node - reach };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | Box::new((start..n).chain((0..(end + 1)))) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(0..=end)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | Box::new((start..(end + 1))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `(start..=end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.60s [INFO] running `"docker" "inspect" "159bb8fd03f3194804887356723b9fd06a087d70a13d20be36d5d778a4dcb1e0"` [INFO] running `"docker" "rm" "-f" "159bb8fd03f3194804887356723b9fd06a087d70a13d20be36d5d778a4dcb1e0"` [INFO] [stdout] 159bb8fd03f3194804887356723b9fd06a087d70a13d20be36d5d778a4dcb1e0