[INFO] updating cached repository garyemerson/breadth_first_search_shortest_reach [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/garyemerson/breadth_first_search_shortest_reach [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/garyemerson/breadth_first_search_shortest_reach" "work/ex/clippy-test-run/sources/stable/gh/garyemerson/breadth_first_search_shortest_reach"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/garyemerson/breadth_first_search_shortest_reach'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/garyemerson/breadth_first_search_shortest_reach" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/breadth_first_search_shortest_reach"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/breadth_first_search_shortest_reach'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7c621ee57319559079e0398369287452327d7d94 [INFO] sha for GitHub repo garyemerson/breadth_first_search_shortest_reach: 7c621ee57319559079e0398369287452327d7d94 [INFO] validating manifest of garyemerson/breadth_first_search_shortest_reach on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of garyemerson/breadth_first_search_shortest_reach on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing garyemerson/breadth_first_search_shortest_reach [INFO] finished frobbing garyemerson/breadth_first_search_shortest_reach [INFO] frobbed toml for garyemerson/breadth_first_search_shortest_reach written to work/ex/clippy-test-run/sources/stable/gh/garyemerson/breadth_first_search_shortest_reach/Cargo.toml [INFO] started frobbing garyemerson/breadth_first_search_shortest_reach [INFO] finished frobbing garyemerson/breadth_first_search_shortest_reach [INFO] frobbed toml for garyemerson/breadth_first_search_shortest_reach written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/breadth_first_search_shortest_reach/Cargo.toml [INFO] crate garyemerson/breadth_first_search_shortest_reach has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting garyemerson/breadth_first_search_shortest_reach against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/breadth_first_search_shortest_reach:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df8f9f8063173b2fafec7111457856782f3e3414095d1128211b39f68f0e50a1 [INFO] running `"docker" "start" "-a" "df8f9f8063173b2fafec7111457856782f3e3414095d1128211b39f68f0e50a1"` [INFO] [stderr] Checking breadth_first_search_shortest_reach v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `num_edges` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | num_edges: i32, [INFO] [stderr] | ^^^^^^^^^ help: consider using `_num_edges` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num_edges` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | num_edges: i32, [INFO] [stderr] | ^^^^^^^^^ help: consider using `_num_edges` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:24:11 [INFO] [stderr] | [INFO] [stderr] 24 | while queue.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | for n in 1..(num_nodes + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=num_nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:71:31 [INFO] [stderr] | [INFO] [stderr] 71 | edges.entry(nodes[0]).or_insert(HashSet::new()).insert(nodes[1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | edges.entry(nodes[1]).or_insert(HashSet::new()).insert(nodes[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:24:11 [INFO] [stderr] | [INFO] [stderr] 24 | while queue.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | for n in 1..(num_nodes + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=num_nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:71:31 [INFO] [stderr] | [INFO] [stderr] 71 | edges.entry(nodes[0]).or_insert(HashSet::new()).insert(nodes[1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | edges.entry(nodes[1]).or_insert(HashSet::new()).insert(nodes[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.53s [INFO] running `"docker" "inspect" "df8f9f8063173b2fafec7111457856782f3e3414095d1128211b39f68f0e50a1"` [INFO] running `"docker" "rm" "-f" "df8f9f8063173b2fafec7111457856782f3e3414095d1128211b39f68f0e50a1"` [INFO] [stdout] df8f9f8063173b2fafec7111457856782f3e3414095d1128211b39f68f0e50a1