[INFO] updating cached repository garyemerson/angry_children_2
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/garyemerson/angry_children_2
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/garyemerson/angry_children_2" "work/ex/clippy-test-run/sources/stable/gh/garyemerson/angry_children_2"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/garyemerson/angry_children_2'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/garyemerson/angry_children_2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/angry_children_2"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/angry_children_2'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] cc804dba709405b1fecc8e1b220d1603e5812df9
[INFO] sha for GitHub repo garyemerson/angry_children_2: cc804dba709405b1fecc8e1b220d1603e5812df9
[INFO] validating manifest of garyemerson/angry_children_2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of garyemerson/angry_children_2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing garyemerson/angry_children_2
[INFO] finished frobbing garyemerson/angry_children_2
[INFO] frobbed toml for garyemerson/angry_children_2 written to work/ex/clippy-test-run/sources/stable/gh/garyemerson/angry_children_2/Cargo.toml
[INFO] started frobbing garyemerson/angry_children_2
[INFO] finished frobbing garyemerson/angry_children_2
[INFO] frobbed toml for garyemerson/angry_children_2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/angry_children_2/Cargo.toml
[INFO] crate garyemerson/angry_children_2 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting garyemerson/angry_children_2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garyemerson/angry_children_2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fb5c43129093ecc7821b2bbd0fb851c724482860e61c9fbfaca6128989e7110b
[INFO] running `"docker" "start" "-a" "fb5c43129093ecc7821b2bbd0fb851c724482860e61c9fbfaca6128989e7110b"`
[INFO] [stderr]     Checking angry_children_2 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/main.rs:34:35
[INFO] [stderr]    |
[INFO] [stderr] 34 |             - log("old part    ", (sum(&sums, start, start + k - 2) - ((k - 1) as i64) * packets[start - 1]));
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         return sums[end];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sums[end]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 |         return sums[end] - sums[start - 1];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sums[end] - sums[start - 1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/main.rs:34:35
[INFO] [stderr]    |
[INFO] [stderr] 34 |             - log("old part    ", (sum(&sums, start, start + k - 2) - ((k - 1) as i64) * packets[start - 1]));
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         return sums[end];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sums[end]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 |         return sums[end] - sums[start - 1];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sums[end] - sums[start - 1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `msg`
[INFO] [stderr]   --> src/main.rs:52:28
[INFO] [stderr]    |
[INFO] [stderr] 52 | fn log<T: std::fmt::Debug>(msg: &str, val: T) -> T {
[INFO] [stderr]    |                            ^^^ help: consider using `_msg` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `get_unfair_slow`
[INFO] [stderr]   --> src/main.rs:57:1
[INFO] [stderr]    |
[INFO] [stderr] 57 | fn get_unfair_slow(packets: &Vec<i64>, start: usize, end: usize) -> i64 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:30:18
[INFO] [stderr]    |
[INFO] [stderr] 30 |     for start in 1..(n - k + 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: use: `1..=n - k`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:57:29
[INFO] [stderr]    |
[INFO] [stderr] 57 | fn get_unfair_slow(packets: &Vec<i64>, start: usize, end: usize) -> i64 {
[INFO] [stderr]    |                             ^^^^^^^^^ help: change this to: `&[i64]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:60:18
[INFO] [stderr]    |
[INFO] [stderr] 60 |         for j in (i + 1)..(end + 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^ help: use: `((i + 1)..=end)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:67:14
[INFO] [stderr]    |
[INFO] [stderr] 67 | fn sum(sums: &Vec<i64>, start: usize, end: usize) -> i64 {
[INFO] [stderr]    |              ^^^^^^^^^ help: change this to: `&[i64]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:76:35
[INFO] [stderr]    |
[INFO] [stderr] 76 | fn get_inital_unfairness(packets: &Vec<i64>, k: usize) -> i64 {
[INFO] [stderr]    |                                   ^^^^^^^^^ help: change this to: `&[i64]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `msg`
[INFO] [stderr]   --> src/main.rs:52:28
[INFO] [stderr]    |
[INFO] [stderr] 52 | fn log<T: std::fmt::Debug>(msg: &str, val: T) -> T {
[INFO] [stderr]    |                            ^^^ help: consider using `_msg` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `get_unfair_slow`
[INFO] [stderr]   --> src/main.rs:57:1
[INFO] [stderr]    |
[INFO] [stderr] 57 | fn get_unfair_slow(packets: &Vec<i64>, start: usize, end: usize) -> i64 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:30:18
[INFO] [stderr]    |
[INFO] [stderr] 30 |     for start in 1..(n - k + 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: use: `1..=n - k`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:57:29
[INFO] [stderr]    |
[INFO] [stderr] 57 | fn get_unfair_slow(packets: &Vec<i64>, start: usize, end: usize) -> i64 {
[INFO] [stderr]    |                             ^^^^^^^^^ help: change this to: `&[i64]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:60:18
[INFO] [stderr]    |
[INFO] [stderr] 60 |         for j in (i + 1)..(end + 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^ help: use: `((i + 1)..=end)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:67:14
[INFO] [stderr]    |
[INFO] [stderr] 67 | fn sum(sums: &Vec<i64>, start: usize, end: usize) -> i64 {
[INFO] [stderr]    |              ^^^^^^^^^ help: change this to: `&[i64]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:76:35
[INFO] [stderr]    |
[INFO] [stderr] 76 | fn get_inital_unfairness(packets: &Vec<i64>, k: usize) -> i64 {
[INFO] [stderr]    |                                   ^^^^^^^^^ help: change this to: `&[i64]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.44s
[INFO] running `"docker" "inspect" "fb5c43129093ecc7821b2bbd0fb851c724482860e61c9fbfaca6128989e7110b"`
[INFO] running `"docker" "rm" "-f" "fb5c43129093ecc7821b2bbd0fb851c724482860e61c9fbfaca6128989e7110b"`
[INFO] [stdout] fb5c43129093ecc7821b2bbd0fb851c724482860e61c9fbfaca6128989e7110b