[INFO] updating cached repository garrettm/splitters
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/garrettm/splitters
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/garrettm/splitters" "work/ex/clippy-test-run/sources/stable/gh/garrettm/splitters"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/garrettm/splitters'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/garrettm/splitters" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garrettm/splitters"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garrettm/splitters'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 557e5442a1a6f872b5a1b43aae276dfeec34d13b
[INFO] sha for GitHub repo garrettm/splitters: 557e5442a1a6f872b5a1b43aae276dfeec34d13b
[INFO] validating manifest of garrettm/splitters on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of garrettm/splitters on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing garrettm/splitters
[INFO] finished frobbing garrettm/splitters
[INFO] frobbed toml for garrettm/splitters written to work/ex/clippy-test-run/sources/stable/gh/garrettm/splitters/Cargo.toml
[INFO] started frobbing garrettm/splitters
[INFO] finished frobbing garrettm/splitters
[INFO] frobbed toml for garrettm/splitters written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garrettm/splitters/Cargo.toml
[INFO] crate garrettm/splitters has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting garrettm/splitters against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/garrettm/splitters:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c685fa183e4d2d787e20d9711635ea0114cabfbe3de541f19f5f45036f7a5f35
[INFO] running `"docker" "start" "-a" "c685fa183e4d2d787e20d9711635ea0114cabfbe3de541f19f5f45036f7a5f35"`
[INFO] [stderr]     Checking splitters v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:8:17
[INFO] [stderr]   |
[INFO] [stderr] 8 | const NEWLINE: &'static str = "\n";
[INFO] [stderr]   |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:8:17
[INFO] [stderr]   |
[INFO] [stderr] 8 | const NEWLINE: &'static str = "\n";
[INFO] [stderr]   |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:33:51
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let outfile_stem = matches.value_of("output").unwrap_or(infile_path.file_stem().unwrap().to_str().unwrap());
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| infile_path.file_stem().unwrap().to_str().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:43:53
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let outfile_extension = infile_path.extension().unwrap_or(OsStr::new(""));
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsStr::new(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:44:50
[INFO] [stderr]    |
[INFO] [stderr] 44 |     let outfile_base_path = infile_path.parent().unwrap_or(Path::new(""));
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/main.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             let _ = outfile.flush().unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/main.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     let _ = outfile.flush().unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:33:51
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let outfile_stem = matches.value_of("output").unwrap_or(infile_path.file_stem().unwrap().to_str().unwrap());
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| infile_path.file_stem().unwrap().to_str().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:43:53
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let outfile_extension = infile_path.extension().unwrap_or(OsStr::new(""));
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsStr::new(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:44:50
[INFO] [stderr]    |
[INFO] [stderr] 44 |     let outfile_base_path = infile_path.parent().unwrap_or(Path::new(""));
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/main.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             let _ = outfile.flush().unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/main.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     let _ = outfile.flush().unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.84s
[INFO] running `"docker" "inspect" "c685fa183e4d2d787e20d9711635ea0114cabfbe3de541f19f5f45036f7a5f35"`
[INFO] running `"docker" "rm" "-f" "c685fa183e4d2d787e20d9711635ea0114cabfbe3de541f19f5f45036f7a5f35"`
[INFO] [stdout] c685fa183e4d2d787e20d9711635ea0114cabfbe3de541f19f5f45036f7a5f35