[INFO] updating cached repository g-s-k/budgt-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/g-s-k/budgt-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/g-s-k/budgt-rs" "work/ex/clippy-test-run/sources/stable/gh/g-s-k/budgt-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/g-s-k/budgt-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/g-s-k/budgt-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/g-s-k/budgt-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/g-s-k/budgt-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c34e643e811d7c0132d5065a7c32b8a846f3dcbc [INFO] sha for GitHub repo g-s-k/budgt-rs: c34e643e811d7c0132d5065a7c32b8a846f3dcbc [INFO] validating manifest of g-s-k/budgt-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of g-s-k/budgt-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing g-s-k/budgt-rs [INFO] finished frobbing g-s-k/budgt-rs [INFO] frobbed toml for g-s-k/budgt-rs written to work/ex/clippy-test-run/sources/stable/gh/g-s-k/budgt-rs/Cargo.toml [INFO] started frobbing g-s-k/budgt-rs [INFO] finished frobbing g-s-k/budgt-rs [INFO] frobbed toml for g-s-k/budgt-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/g-s-k/budgt-rs/Cargo.toml [INFO] crate g-s-k/budgt-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting g-s-k/budgt-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/g-s-k/budgt-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcbb8a4f78593cfd9c6c2c3c5d7b2818d820fce192eff601781f8d5bd810c309 [INFO] running `"docker" "start" "-a" "fcbb8a4f78593cfd9c6c2c3c5d7b2818d820fce192eff601781f8d5bd810c309"` [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking tui v0.2.3 [INFO] [stderr] Checking budgt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | / match ch.unwrap() { [INFO] [stderr] 34 | | event::Key::Char('q') => { [INFO] [stderr] 35 | | input_tx.send("quit").unwrap(); [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | _ => {} [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let event::Key::Char('q') = ch.unwrap() { [INFO] [stderr] 34 | input_tx.send("quit").unwrap(); [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match evt { [INFO] [stderr] 55 | | "quit" => break, [INFO] [stderr] 56 | | _ => {} [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ help: try this: `if let "quit" = evt { break }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | / match ch.unwrap() { [INFO] [stderr] 34 | | event::Key::Char('q') => { [INFO] [stderr] 35 | | input_tx.send("quit").unwrap(); [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | _ => {} [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let event::Key::Char('q') = ch.unwrap() { [INFO] [stderr] 34 | input_tx.send("quit").unwrap(); [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | .map(|x| x as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match evt { [INFO] [stderr] 55 | | "quit" => break, [INFO] [stderr] 56 | | _ => {} [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ help: try this: `if let "quit" = evt { break }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:85:27 [INFO] [stderr] | [INFO] [stderr] 85 | .map(|x| (x, (x * 3.14159 / 20.0).sin())) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | ].into_iter(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | .map(|x| x as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:85:27 [INFO] [stderr] | [INFO] [stderr] 85 | .map(|x| (x, (x * 3.14159 / 20.0).sin())) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | ].into_iter(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `budgt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `budgt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fcbb8a4f78593cfd9c6c2c3c5d7b2818d820fce192eff601781f8d5bd810c309"` [INFO] running `"docker" "rm" "-f" "fcbb8a4f78593cfd9c6c2c3c5d7b2818d820fce192eff601781f8d5bd810c309"` [INFO] [stdout] fcbb8a4f78593cfd9c6c2c3c5d7b2818d820fce192eff601781f8d5bd810c309