[INFO] updating cached repository frostie614/cards [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/frostie614/cards [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/frostie614/cards" "work/ex/clippy-test-run/sources/stable/gh/frostie614/cards"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/frostie614/cards'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/frostie614/cards" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frostie614/cards"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frostie614/cards'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6c0f920240c260881a84e2cbb2b22baeae50cebc [INFO] sha for GitHub repo frostie614/cards: 6c0f920240c260881a84e2cbb2b22baeae50cebc [INFO] validating manifest of frostie614/cards on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of frostie614/cards on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing frostie614/cards [INFO] finished frobbing frostie614/cards [INFO] frobbed toml for frostie614/cards written to work/ex/clippy-test-run/sources/stable/gh/frostie614/cards/Cargo.toml [INFO] started frobbing frostie614/cards [INFO] finished frobbing frostie614/cards [INFO] frobbed toml for frostie614/cards written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frostie614/cards/Cargo.toml [INFO] crate frostie614/cards has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting frostie614/cards against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frostie614/cards:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69f434d2581d0415ce3c3adcd5398b9e2a655191c4d27743c57a4f5cc9db12b9 [INFO] running `"docker" "start" "-a" "69f434d2581d0415ce3c3adcd5398b9e2a655191c4d27743c57a4f5cc9db12b9"` [INFO] [stderr] Checking cards v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variant is never constructed: `Hearts` [INFO] [stderr] --> src/main.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | enum Suit {Hearts, Diamonds, Spades, Clubs} [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![warn(dead_code)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Diamonds` [INFO] [stderr] --> src/main.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | enum Suit {Hearts, Diamonds, Spades, Clubs} [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Spades` [INFO] [stderr] --> src/main.rs:24:30 [INFO] [stderr] | [INFO] [stderr] 24 | enum Suit {Hearts, Diamonds, Spades, Clubs} [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Clubs` [INFO] [stderr] --> src/main.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | enum Suit {Hearts, Diamonds, Spades, Clubs} [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Ace` [INFO] [stderr] --> src/main.rs:27:10 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Two` [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Three` [INFO] [stderr] --> src/main.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Four` [INFO] [stderr] --> src/main.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Five` [INFO] [stderr] --> src/main.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Six` [INFO] [stderr] --> src/main.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Seven` [INFO] [stderr] --> src/main.rs:27:44 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Eight` [INFO] [stderr] --> src/main.rs:27:51 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Nine` [INFO] [stderr] --> src/main.rs:27:58 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Ten` [INFO] [stderr] --> src/main.rs:27:64 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Jack` [INFO] [stderr] --> src/main.rs:27:69 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Queen` [INFO] [stderr] --> src/main.rs:27:75 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `King` [INFO] [stderr] --> src/main.rs:27:82 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/main.rs:47:2 [INFO] [stderr] | [INFO] [stderr] 47 | fn new()-> Deck{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `deal` [INFO] [stderr] --> src/main.rs:57:2 [INFO] [stderr] | [INFO] [stderr] 57 | fn deal(&mut self) -> Option{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `shuffle` [INFO] [stderr] --> src/main.rs:61:2 [INFO] [stderr] | [INFO] [stderr] 61 | fn shuffle(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/main.rs:68:2 [INFO] [stderr] | [INFO] [stderr] 68 | fn new(suit:Suit, pip:Pip) -> Card{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `value` [INFO] [stderr] --> src/main.rs:72:2 [INFO] [stderr] | [INFO] [stderr] 72 | fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | writeln!(f, "{}", card); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:49:15 [INFO] [stderr] | [INFO] [stderr] 49 | for suit in vec![Suit::Hearts, Suit::Diamonds, Suit::Spades, Suit::Clubs]{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Suit::Hearts, Suit::Diamonds, Suit::Spades, Suit::Clubs]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | for pip in vec![Pip::Ace, Pip::Two, Pip::Three, Pip::Four, Pip::Five, Pip::Six, Pip::Seven, Pip::Eight, Pip::Nine, Pip::Ten, Pip::Jack, Pip::Queen, Pip::King]{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Pip::Ace, Pip::Two, Pip::Three, Pip::Four, Pip::Five, Pip::Six, Pip::Seven, Pip::Eight, Pip::Nine, Pip::Ten, Pip::Jack, Pip::Queen, Pip::King]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Hearts` [INFO] [stderr] --> src/main.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | enum Suit {Hearts, Diamonds, Spades, Clubs} [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![warn(dead_code)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Diamonds` [INFO] [stderr] --> src/main.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | enum Suit {Hearts, Diamonds, Spades, Clubs} [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Spades` [INFO] [stderr] --> src/main.rs:24:30 [INFO] [stderr] | [INFO] [stderr] 24 | enum Suit {Hearts, Diamonds, Spades, Clubs} [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Clubs` [INFO] [stderr] --> src/main.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | enum Suit {Hearts, Diamonds, Spades, Clubs} [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Ace` [INFO] [stderr] --> src/main.rs:27:10 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Two` [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Three` [INFO] [stderr] --> src/main.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Four` [INFO] [stderr] --> src/main.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Five` [INFO] [stderr] --> src/main.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Six` [INFO] [stderr] --> src/main.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Seven` [INFO] [stderr] --> src/main.rs:27:44 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Eight` [INFO] [stderr] --> src/main.rs:27:51 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Nine` [INFO] [stderr] --> src/main.rs:27:58 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Ten` [INFO] [stderr] --> src/main.rs:27:64 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Jack` [INFO] [stderr] --> src/main.rs:27:69 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Queen` [INFO] [stderr] --> src/main.rs:27:75 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `King` [INFO] [stderr] --> src/main.rs:27:82 [INFO] [stderr] | [INFO] [stderr] 27 | enum Pip{Ace, Two, Three, Four, Five, Six, Seven, Eight, Nine, Ten, Jack, Queen, King} [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/main.rs:47:2 [INFO] [stderr] | [INFO] [stderr] 47 | fn new()-> Deck{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `deal` [INFO] [stderr] --> src/main.rs:57:2 [INFO] [stderr] | [INFO] [stderr] 57 | fn deal(&mut self) -> Option{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `shuffle` [INFO] [stderr] --> src/main.rs:61:2 [INFO] [stderr] | [INFO] [stderr] 61 | fn shuffle(&mut self){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/main.rs:68:2 [INFO] [stderr] | [INFO] [stderr] 68 | fn new(suit:Suit, pip:Pip) -> Card{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `value` [INFO] [stderr] --> src/main.rs:72:2 [INFO] [stderr] | [INFO] [stderr] 72 | fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | writeln!(f, "{}", card); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:49:15 [INFO] [stderr] | [INFO] [stderr] 49 | for suit in vec![Suit::Hearts, Suit::Diamonds, Suit::Spades, Suit::Clubs]{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Suit::Hearts, Suit::Diamonds, Suit::Spades, Suit::Clubs]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | for pip in vec![Pip::Ace, Pip::Two, Pip::Three, Pip::Four, Pip::Five, Pip::Six, Pip::Seven, Pip::Eight, Pip::Nine, Pip::Ten, Pip::Jack, Pip::Queen, Pip::King]{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Pip::Ace, Pip::Two, Pip::Three, Pip::Four, Pip::Five, Pip::Six, Pip::Seven, Pip::Eight, Pip::Nine, Pip::Ten, Pip::Jack, Pip::Queen, Pip::King]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.88s [INFO] running `"docker" "inspect" "69f434d2581d0415ce3c3adcd5398b9e2a655191c4d27743c57a4f5cc9db12b9"` [INFO] running `"docker" "rm" "-f" "69f434d2581d0415ce3c3adcd5398b9e2a655191c4d27743c57a4f5cc9db12b9"` [INFO] [stdout] 69f434d2581d0415ce3c3adcd5398b9e2a655191c4d27743c57a4f5cc9db12b9