[INFO] updating cached repository frigus02/crypto-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/frigus02/crypto-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/frigus02/crypto-playground" "work/ex/clippy-test-run/sources/stable/gh/frigus02/crypto-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/frigus02/crypto-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/frigus02/crypto-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frigus02/crypto-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frigus02/crypto-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec966bae4c9681eb558dc68586edfc05b69b04ef [INFO] sha for GitHub repo frigus02/crypto-playground: ec966bae4c9681eb558dc68586edfc05b69b04ef [INFO] validating manifest of frigus02/crypto-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of frigus02/crypto-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing frigus02/crypto-playground [INFO] finished frobbing frigus02/crypto-playground [INFO] frobbed toml for frigus02/crypto-playground written to work/ex/clippy-test-run/sources/stable/gh/frigus02/crypto-playground/Cargo.toml [INFO] started frobbing frigus02/crypto-playground [INFO] finished frobbing frigus02/crypto-playground [INFO] frobbed toml for frigus02/crypto-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frigus02/crypto-playground/Cargo.toml [INFO] crate frigus02/crypto-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting frigus02/crypto-playground against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/frigus02/crypto-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6d5d5fbfdb9c68ab6c9cb612808461bfae21afe26d8762a1c07e1178daa9dad [INFO] running `"docker" "start" "-a" "f6d5d5fbfdb9c68ab6c9cb612808461bfae21afe26d8762a1c07e1178daa9dad"` [INFO] [stderr] Checking crypto-playground v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analysis/hemming_distance.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return Ok(distance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(distance)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analysis/letter_frequency.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return differences.iter().sum::() / differences.len() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `differences.iter().sum::() / differences.len() as f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analysis/letter_frequency.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return Ok(scores); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(scores)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analysis/letter_frequency.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return scores; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `scores` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/break_repeating_key_xor.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return Ok(Info { key, plain_text }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Info { key, plain_text })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/detect_single_char_xor.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / return match String::from_utf8(decoded_bytes) { [INFO] [stderr] 33 | | Ok(plain_text) => Ok(Info { [INFO] [stderr] 34 | | key, [INFO] [stderr] 35 | | plain_text, [INFO] [stderr] ... | [INFO] [stderr] 38 | | Err(err) => Err(format!("decoding failed: {}", err)), [INFO] [stderr] 39 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 32 | match String::from_utf8(decoded_bytes) { [INFO] [stderr] 33 | Ok(plain_text) => Ok(Info { [INFO] [stderr] 34 | key, [INFO] [stderr] 35 | plain_text, [INFO] [stderr] 36 | score, [INFO] [stderr] 37 | }), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/fixed_xor.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return hex::encode(&result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hex::encode(&result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/hex_to_base64.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return base64::encode(bytes.as_slice()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `base64::encode(bytes.as_slice())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/repeating_key_xor.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return hex::encode(&result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hex::encode(&result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/single_byte_xor.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return hex::encode(&result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hex::encode(&result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/base64.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return String::from_utf8(base64_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(base64_bytes).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/base64.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / return if value <= 25 { [INFO] [stderr] 34 | | value + 65 // "A" - "Z" [INFO] [stderr] 35 | | } else if value >= 26 && value <= 51 { [INFO] [stderr] 36 | | value + 71 // "a" - "z" [INFO] [stderr] ... | [INFO] [stderr] 44 | | panic!("Invalid base64 value: {}", value); [INFO] [stderr] 45 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | if value <= 25 { [INFO] [stderr] 34 | value + 65 // "A" - "Z" [INFO] [stderr] 35 | } else if value >= 26 && value <= 51 { [INFO] [stderr] 36 | value + 71 // "a" - "z" [INFO] [stderr] 37 | } else if value >= 52 && value <= 61 { [INFO] [stderr] 38 | value - 4 // "0" - "9" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/base64.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/base64.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / return if value >= 65 && value <= 90 { [INFO] [stderr] 82 | | value - 65 // "A" - "Z" [INFO] [stderr] 83 | | } else if value >= 97 && value <= 122 { [INFO] [stderr] 84 | | value - 71 // "a" - "z" [INFO] [stderr] ... | [INFO] [stderr] 92 | | panic!("Invalid base64 value: {}", value); [INFO] [stderr] 93 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 81 | if value >= 65 && value <= 90 { [INFO] [stderr] 82 | value - 65 // "A" - "Z" [INFO] [stderr] 83 | } else if value >= 97 && value <= 122 { [INFO] [stderr] 84 | value - 71 // "a" - "z" [INFO] [stderr] 85 | } else if value >= 48 && value <= 57 { [INFO] [stderr] 86 | value + 4 // "0" - "9" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/hex.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return String::from_utf8(hex_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(hex_bytes).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/hex.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / return if value <= 9 { [INFO] [stderr] 29 | | value + 48 // "0" - "9" [INFO] [stderr] 30 | | } else if value >= 10 && value <= 15 { [INFO] [stderr] 31 | | value + 87 // "a" - "f" [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | panic!("Invalid hex value: {}", value); [INFO] [stderr] 34 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | if value <= 9 { [INFO] [stderr] 29 | value + 48 // "0" - "9" [INFO] [stderr] 30 | } else if value >= 10 && value <= 15 { [INFO] [stderr] 31 | value + 87 // "a" - "f" [INFO] [stderr] 32 | } else { [INFO] [stderr] 33 | panic!("Invalid hex value: {}", value); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/hex.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/hex.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / return if value >= 48 && value <= 57 { [INFO] [stderr] 60 | | value - 48 // "0" - "9" [INFO] [stderr] 61 | | } else if value >= 65 && value <= 70 { [INFO] [stderr] 62 | | value - 55 // "A" - "F" [INFO] [stderr] ... | [INFO] [stderr] 66 | | panic!("Invalid hex value: {}", value); [INFO] [stderr] 67 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 59 | if value >= 48 && value <= 57 { [INFO] [stderr] 60 | value - 48 // "0" - "9" [INFO] [stderr] 61 | } else if value >= 65 && value <= 70 { [INFO] [stderr] 62 | value - 55 // "A" - "F" [INFO] [stderr] 63 | } else if value >= 97 && value <= 102 { [INFO] [stderr] 64 | value - 87 // "a" - "f" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/xor.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return encoded_bytes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `encoded_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analysis/hemming_distance.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return Ok(distance); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(distance)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analysis/letter_frequency.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return differences.iter().sum::() / differences.len() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `differences.iter().sum::() / differences.len() as f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analysis/letter_frequency.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return Ok(scores); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(scores)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analysis/letter_frequency.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return scores; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `scores` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/break_repeating_key_xor.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return Ok(Info { key, plain_text }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Info { key, plain_text })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/detect_single_char_xor.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / return match String::from_utf8(decoded_bytes) { [INFO] [stderr] 33 | | Ok(plain_text) => Ok(Info { [INFO] [stderr] 34 | | key, [INFO] [stderr] 35 | | plain_text, [INFO] [stderr] ... | [INFO] [stderr] 38 | | Err(err) => Err(format!("decoding failed: {}", err)), [INFO] [stderr] 39 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 32 | match String::from_utf8(decoded_bytes) { [INFO] [stderr] 33 | Ok(plain_text) => Ok(Info { [INFO] [stderr] 34 | key, [INFO] [stderr] 35 | plain_text, [INFO] [stderr] 36 | score, [INFO] [stderr] 37 | }), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/fixed_xor.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return hex::encode(&result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hex::encode(&result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/hex_to_base64.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return base64::encode(bytes.as_slice()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `base64::encode(bytes.as_slice())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/repeating_key_xor.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return hex::encode(&result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hex::encode(&result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/challenges/single_byte_xor.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return hex::encode(&result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hex::encode(&result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/base64.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return String::from_utf8(base64_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(base64_bytes).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/base64.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / return if value <= 25 { [INFO] [stderr] 34 | | value + 65 // "A" - "Z" [INFO] [stderr] 35 | | } else if value >= 26 && value <= 51 { [INFO] [stderr] 36 | | value + 71 // "a" - "z" [INFO] [stderr] ... | [INFO] [stderr] 44 | | panic!("Invalid base64 value: {}", value); [INFO] [stderr] 45 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | if value <= 25 { [INFO] [stderr] 34 | value + 65 // "A" - "Z" [INFO] [stderr] 35 | } else if value >= 26 && value <= 51 { [INFO] [stderr] 36 | value + 71 // "a" - "z" [INFO] [stderr] 37 | } else if value >= 52 && value <= 61 { [INFO] [stderr] 38 | value - 4 // "0" - "9" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/base64.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/base64.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / return if value >= 65 && value <= 90 { [INFO] [stderr] 82 | | value - 65 // "A" - "Z" [INFO] [stderr] 83 | | } else if value >= 97 && value <= 122 { [INFO] [stderr] 84 | | value - 71 // "a" - "z" [INFO] [stderr] ... | [INFO] [stderr] 92 | | panic!("Invalid base64 value: {}", value); [INFO] [stderr] 93 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 81 | if value >= 65 && value <= 90 { [INFO] [stderr] 82 | value - 65 // "A" - "Z" [INFO] [stderr] 83 | } else if value >= 97 && value <= 122 { [INFO] [stderr] 84 | value - 71 // "a" - "z" [INFO] [stderr] 85 | } else if value >= 48 && value <= 57 { [INFO] [stderr] 86 | value + 4 // "0" - "9" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/hex.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return String::from_utf8(hex_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(hex_bytes).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/hex.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / return if value <= 9 { [INFO] [stderr] 29 | | value + 48 // "0" - "9" [INFO] [stderr] 30 | | } else if value >= 10 && value <= 15 { [INFO] [stderr] 31 | | value + 87 // "a" - "f" [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | panic!("Invalid hex value: {}", value); [INFO] [stderr] 34 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | if value <= 9 { [INFO] [stderr] 29 | value + 48 // "0" - "9" [INFO] [stderr] 30 | } else if value >= 10 && value <= 15 { [INFO] [stderr] 31 | value + 87 // "a" - "f" [INFO] [stderr] 32 | } else { [INFO] [stderr] 33 | panic!("Invalid hex value: {}", value); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/hex.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/hex.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / return if value >= 48 && value <= 57 { [INFO] [stderr] 60 | | value - 48 // "0" - "9" [INFO] [stderr] 61 | | } else if value >= 65 && value <= 70 { [INFO] [stderr] 62 | | value - 55 // "A" - "F" [INFO] [stderr] ... | [INFO] [stderr] 66 | | panic!("Invalid hex value: {}", value); [INFO] [stderr] 67 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 59 | if value >= 48 && value <= 57 { [INFO] [stderr] 60 | value - 48 // "0" - "9" [INFO] [stderr] 61 | } else if value >= 65 && value <= 70 { [INFO] [stderr] 62 | value - 55 // "A" - "F" [INFO] [stderr] 63 | } else if value >= 97 && value <= 102 { [INFO] [stderr] 64 | value - 87 // "a" - "f" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoding/xor.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return encoded_bytes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `encoded_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/challenges/break_repeating_key_xor.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let bytes = base64::decode(base64); [INFO] [stderr] | ^^^^^ help: consider using `_bytes` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get` [INFO] [stderr] --> src/analysis/hemming_distance.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn get(bytes_a: &[u8], bytes_b: &[u8]) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/analysis/letter_frequency.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/analysis/letter_frequency.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | *frequency = *frequency / len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*frequency /= len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/challenges/detect_single_char_xor.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | }).ok_or(String::from("score collection empty"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| String::from("score collection empty"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/challenges/detect_single_char_xor.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | let (key, decoded_bytes, score) = key_range [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 22 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `key_range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/challenges/detect_single_char_xor.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | let decoded_bytes = xor::encode(&bytes, &vec![key]); [INFO] [stderr] | ^^^^^^^^^^ help: you can use a slice directly: `&[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/challenges/single_byte_xor.rs:6:38 [INFO] [stderr] | [INFO] [stderr] 6 | let result = xor::encode(&bytes, &vec![encoding_byte]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[encoding_byte]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/encoding/base64.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | part1 = part1 << 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `part1 <<= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/encoding/base64.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | part2 = part2 >> 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `part2 >>= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/encoding/base64.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | part1 = part1 << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `part1 <<= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/encoding/base64.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | part2 = part2 >> 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `part2 >>= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/encoding/base64.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | part1 = part1 << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `part1 <<= 6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/challenges/break_repeating_key_xor.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let bytes = base64::decode(base64); [INFO] [stderr] | ^^^^^ help: consider using `_bytes` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/analysis/letter_frequency.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/analysis/letter_frequency.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | *frequency = *frequency / len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*frequency /= len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/challenges/detect_single_char_xor.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | }).ok_or(String::from("score collection empty"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| String::from("score collection empty"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/challenges/detect_single_char_xor.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | let (key, decoded_bytes, score) = key_range [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 22 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `key_range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/challenges/detect_single_char_xor.rs:24:53 [INFO] [stderr] | [INFO] [stderr] 24 | let decoded_bytes = xor::encode(&bytes, &vec![key]); [INFO] [stderr] | ^^^^^^^^^^ help: you can use a slice directly: `&[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/challenges/detect_single_char_xor.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!('X' as u8, info.key); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'X' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/challenges/single_byte_xor.rs:6:38 [INFO] [stderr] | [INFO] [stderr] 6 | let result = xor::encode(&bytes, &vec![encoding_byte]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[encoding_byte]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/encoding/base64.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | part1 = part1 << 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `part1 <<= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/encoding/base64.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | part2 = part2 >> 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `part2 >>= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/encoding/base64.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | part1 = part1 << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `part1 <<= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/encoding/base64.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | part2 = part2 >> 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `part2 >>= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/encoding/base64.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | part1 = part1 << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `part1 <<= 6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.25s [INFO] running `"docker" "inspect" "f6d5d5fbfdb9c68ab6c9cb612808461bfae21afe26d8762a1c07e1178daa9dad"` [INFO] running `"docker" "rm" "-f" "f6d5d5fbfdb9c68ab6c9cb612808461bfae21afe26d8762a1c07e1178daa9dad"` [INFO] [stdout] f6d5d5fbfdb9c68ab6c9cb612808461bfae21afe26d8762a1c07e1178daa9dad