[INFO] updating cached repository fourohfour/enquel [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fourohfour/enquel [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fourohfour/enquel" "work/ex/clippy-test-run/sources/stable/gh/fourohfour/enquel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fourohfour/enquel'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fourohfour/enquel" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fourohfour/enquel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fourohfour/enquel'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0add6c82245dab3c7e4e03592fa12ea76b68a30f [INFO] sha for GitHub repo fourohfour/enquel: 0add6c82245dab3c7e4e03592fa12ea76b68a30f [INFO] validating manifest of fourohfour/enquel on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fourohfour/enquel on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fourohfour/enquel [INFO] finished frobbing fourohfour/enquel [INFO] frobbed toml for fourohfour/enquel written to work/ex/clippy-test-run/sources/stable/gh/fourohfour/enquel/Cargo.toml [INFO] started frobbing fourohfour/enquel [INFO] finished frobbing fourohfour/enquel [INFO] frobbed toml for fourohfour/enquel written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fourohfour/enquel/Cargo.toml [INFO] crate fourohfour/enquel has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fourohfour/enquel against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fourohfour/enquel:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac3cd544027da699af965546e6b58bc2a0ce611e25bd0ff1de03add0d94d4bd3 [INFO] running `"docker" "start" "-a" "ac3cd544027da699af965546e6b58bc2a0ce611e25bd0ff1de03add0d94d4bd3"` [INFO] [stderr] Checking enquel v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokeniser.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | slice : slice, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokeniser.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | chars : chars, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokeniser.rs:79:34 [INFO] [stderr] | [INFO] [stderr] 79 | length : length , [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokeniser.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | slice : slice, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokeniser.rs:315:63 [INFO] [stderr] | [INFO] [stderr] 315 | return Some(token::Token {origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:91:26 [INFO] [stderr] | [INFO] [stderr] 91 | let node = Node {data: data, children: Vec::new()}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokeniser.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | chars : chars, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokeniser.rs:79:34 [INFO] [stderr] | [INFO] [stderr] 79 | length : length , [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokeniser.rs:315:63 [INFO] [stderr] | [INFO] [stderr] 315 | return Some(token::Token {origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:91:26 [INFO] [stderr] | [INFO] [stderr] 91 | let node = Node {data: data, children: Vec::new()}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokeniser.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return self.chars.get(self.ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chars.get(self.ptr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokeniser.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return self.chars.get(self.ptr + self.grab + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chars.get(self.ptr + self.grab + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tokeniser.rs:119:26 [INFO] [stderr] | [INFO] [stderr] 119 | fn ungrab(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tokeniser.rs:523:18 [INFO] [stderr] | [INFO] [stderr] 523 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 524 | | if let Some(symbol) = consumer.consume_symbol() { [INFO] [stderr] 525 | | tokens.push(symbol); [INFO] [stderr] 526 | | } [INFO] [stderr] 527 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 523 | else if let Some(symbol) = consumer.consume_symbol() { [INFO] [stderr] 524 | tokens.push(symbol); [INFO] [stderr] 525 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `token` [INFO] [stderr] --> src/parse.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use token; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokeniser.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return self.chars.get(self.ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chars.get(self.ptr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokeniser.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return self.chars.get(self.ptr + self.grab + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chars.get(self.ptr + self.grab + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tokeniser.rs:119:26 [INFO] [stderr] | [INFO] [stderr] 119 | fn ungrab(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tokeniser.rs:523:18 [INFO] [stderr] | [INFO] [stderr] 523 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 524 | | if let Some(symbol) = consumer.consume_symbol() { [INFO] [stderr] 525 | | tokens.push(symbol); [INFO] [stderr] 526 | | } [INFO] [stderr] 527 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 523 | else if let Some(symbol) = consumer.consume_symbol() { [INFO] [stderr] 524 | tokens.push(symbol); [INFO] [stderr] 525 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `token` [INFO] [stderr] --> src/parse.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use token; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tokens` [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let tokens = tokeniser::tokenise(&inbuf); [INFO] [stderr] | ^^^^^^ help: consider using `_tokens` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `slice` [INFO] [stderr] --> src/tokeniser.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | slice : &'a str , [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `placeholder_origin` [INFO] [stderr] --> src/tokeniser.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | fn placeholder_origin() -> token::Origin { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `ungrab` [INFO] [stderr] --> src/tokeniser.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | fn ungrab(&mut self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `ArgClass` [INFO] [stderr] --> src/parse.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub enum ArgClass { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `LogicalBlock` [INFO] [stderr] --> src/parse.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub enum LogicalBlock { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `EvaluatorType` [INFO] [stderr] --> src/parse.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub enum EvaluatorType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `ComparisonOperator` [INFO] [stderr] --> src/parse.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | pub enum ComparisonOperator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `NodeData` [INFO] [stderr] --> src/parse.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | pub enum NodeData { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Node` [INFO] [stderr] --> src/parse.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | pub struct Node { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_child` [INFO] [stderr] --> src/parse.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn add_child(&mut self, c : Node) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_child` [INFO] [stderr] --> src/parse.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn new_child(&mut self, data: NodeData) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `walk_display` [INFO] [stderr] --> src/parse.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | fn walk_display(&self, depth: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Tree` [INFO] [stderr] --> src/parse.rs:104:1 [INFO] [stderr] | [INFO] [stderr] 104 | pub struct Tree { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parse.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn new() -> Tree { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `root` [INFO] [stderr] --> src/parse.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn root<'rnode>(&'rnode mut self) -> &'rnode mut Node { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `walk` [INFO] [stderr] --> src/parse.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn walk<'rnode>(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tokeniser.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | for index in self.ptr .. (self.ptr + self.grab + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.ptr..=self.ptr + self.grab` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tokeniser.rs:291:16 [INFO] [stderr] | [INFO] [stderr] 291 | if !(init == '\"') { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `init != '\"'` [INFO] [stderr] warning: unused variable: `tokens` [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let tokens = tokeniser::tokenise(&inbuf); [INFO] [stderr] | ^^^^^^ help: consider using `_tokens` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the variable `shrink` is used as a loop counter. Consider using `for (shrink, item) in &controls.enumerate()` or similar iterators [INFO] [stderr] --> src/tokeniser.rs:307:42 [INFO] [stderr] | [INFO] [stderr] 307 | for c in &controls { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/tokeniser.rs:503:5 [INFO] [stderr] | [INFO] [stderr] 503 | / loop { [INFO] [stderr] 504 | | if let Some(c) = consumer.current() { [INFO] [stderr] 505 | | if c.is_whitespace() { [INFO] [stderr] 506 | | consumer.consume_whitespace(); [INFO] [stderr] ... | [INFO] [stderr] 531 | | } [INFO] [stderr] 532 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(c) = consumer.current() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | / pub fn root<'rnode>(&'rnode mut self) -> &'rnode mut Node { [INFO] [stderr] 119 | | &mut self.root [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parse.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn walk<'rnode>(&self) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: field is never used: `slice` [INFO] [stderr] --> src/tokeniser.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | slice : &'a str , [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `placeholder_origin` [INFO] [stderr] --> src/tokeniser.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | fn placeholder_origin() -> token::Origin { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `ungrab` [INFO] [stderr] --> src/tokeniser.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | fn ungrab(&mut self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `ArgClass` [INFO] [stderr] --> src/parse.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub enum ArgClass { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `LogicalBlock` [INFO] [stderr] --> src/parse.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub enum LogicalBlock { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `EvaluatorType` [INFO] [stderr] --> src/parse.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub enum EvaluatorType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `ComparisonOperator` [INFO] [stderr] --> src/parse.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | pub enum ComparisonOperator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `NodeData` [INFO] [stderr] --> src/parse.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | pub enum NodeData { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Node` [INFO] [stderr] --> src/parse.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | pub struct Node { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_child` [INFO] [stderr] --> src/parse.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn add_child(&mut self, c : Node) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_child` [INFO] [stderr] --> src/parse.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn new_child(&mut self, data: NodeData) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `walk_display` [INFO] [stderr] --> src/parse.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | fn walk_display(&self, depth: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Tree` [INFO] [stderr] --> src/parse.rs:104:1 [INFO] [stderr] | [INFO] [stderr] 104 | pub struct Tree { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parse.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn new() -> Tree { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `root` [INFO] [stderr] --> src/parse.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn root<'rnode>(&'rnode mut self) -> &'rnode mut Node { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `walk` [INFO] [stderr] --> src/parse.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn walk<'rnode>(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tokeniser.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | for index in self.ptr .. (self.ptr + self.grab + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.ptr..=self.ptr + self.grab` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tokeniser.rs:291:16 [INFO] [stderr] | [INFO] [stderr] 291 | if !(init == '\"') { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `init != '\"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the variable `shrink` is used as a loop counter. Consider using `for (shrink, item) in &controls.enumerate()` or similar iterators [INFO] [stderr] --> src/tokeniser.rs:307:42 [INFO] [stderr] | [INFO] [stderr] 307 | for c in &controls { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/tokeniser.rs:503:5 [INFO] [stderr] | [INFO] [stderr] 503 | / loop { [INFO] [stderr] 504 | | if let Some(c) = consumer.current() { [INFO] [stderr] 505 | | if c.is_whitespace() { [INFO] [stderr] 506 | | consumer.consume_whitespace(); [INFO] [stderr] ... | [INFO] [stderr] 531 | | } [INFO] [stderr] 532 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(c) = consumer.current() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | / pub fn root<'rnode>(&'rnode mut self) -> &'rnode mut Node { [INFO] [stderr] 119 | | &mut self.root [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parse.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn walk<'rnode>(&self) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "ac3cd544027da699af965546e6b58bc2a0ce611e25bd0ff1de03add0d94d4bd3"` [INFO] running `"docker" "rm" "-f" "ac3cd544027da699af965546e6b58bc2a0ce611e25bd0ff1de03add0d94d4bd3"` [INFO] [stdout] ac3cd544027da699af965546e6b58bc2a0ce611e25bd0ff1de03add0d94d4bd3