[INFO] updating cached repository foolusion/ab [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/foolusion/ab [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/foolusion/ab" "work/ex/clippy-test-run/sources/stable/gh/foolusion/ab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/foolusion/ab'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/foolusion/ab" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/foolusion/ab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/foolusion/ab'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a7aad89ba5f505a54b7bae5fa1c892e3f6bf3330 [INFO] sha for GitHub repo foolusion/ab: a7aad89ba5f505a54b7bae5fa1c892e3f6bf3330 [INFO] validating manifest of foolusion/ab on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of foolusion/ab on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing foolusion/ab [INFO] finished frobbing foolusion/ab [INFO] frobbed toml for foolusion/ab written to work/ex/clippy-test-run/sources/stable/gh/foolusion/ab/Cargo.toml [INFO] started frobbing foolusion/ab [INFO] finished frobbing foolusion/ab [INFO] frobbed toml for foolusion/ab written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/foolusion/ab/Cargo.toml [INFO] crate foolusion/ab has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting foolusion/ab against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/foolusion/ab:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8502152f922affc3bf93f37ae4ed2ab497a1fbd96615b6d3063f9c59596e931 [INFO] running `"docker" "start" "-a" "b8502152f922affc3bf93f37ae4ed2ab497a1fbd96615b6d3063f9c59596e931"` [INFO] [stderr] Checking ab v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:204:14 [INFO] [stderr] | [INFO] [stderr] 204 | 0 => return Some("segment not activated"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some("segment not activated")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:119:48 [INFO] [stderr] | [INFO] [stderr] 119 | fn eval_test<'a>(exp: &'a Experiment, user_id: &'a String) -> Result, &'a str> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / match valid_segment(&exp.segments, exp_hash) { [INFO] [stderr] 124 | | Some(e) => return Err(e), [INFO] [stderr] 125 | | _ => (), [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(e) = valid_segment(&exp.segments, exp_hash) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:151:31 [INFO] [stderr] | [INFO] [stderr] 151 | fn eval_weighted<'a>(choices: &Vec<(String, f64)>, hash: u64) -> Result<&str, &str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, f64)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | fn eval_weighted<'a>(choices: &Vec<(String, f64)>, hash: u64) -> Result<&str, &str> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:166:30 [INFO] [stderr] | [INFO] [stderr] 166 | fn eval_uniform<'a>(choices: &Vec, hash: u64) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | fn eval_uniform<'a>(choices: &Vec, hash: u64) -> &str { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:200:36 [INFO] [stderr] | [INFO] [stderr] 200 | fn valid_segment<'a, 'b>(segments: &Vec, hash: u64) -> Option<&'b str> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:200:18 [INFO] [stderr] | [INFO] [stderr] 200 | fn valid_segment<'a, 'b>(segments: &Vec, hash: u64) -> Option<&'b str> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return out; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:204:14 [INFO] [stderr] | [INFO] [stderr] 204 | 0 => return Some("segment not activated"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some("segment not activated")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:119:48 [INFO] [stderr] | [INFO] [stderr] 119 | fn eval_test<'a>(exp: &'a Experiment, user_id: &'a String) -> Result, &'a str> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / match valid_segment(&exp.segments, exp_hash) { [INFO] [stderr] 124 | | Some(e) => return Err(e), [INFO] [stderr] 125 | | _ => (), [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(e) = valid_segment(&exp.segments, exp_hash) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:151:31 [INFO] [stderr] | [INFO] [stderr] 151 | fn eval_weighted<'a>(choices: &Vec<(String, f64)>, hash: u64) -> Result<&str, &str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, f64)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | fn eval_weighted<'a>(choices: &Vec<(String, f64)>, hash: u64) -> Result<&str, &str> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:166:30 [INFO] [stderr] | [INFO] [stderr] 166 | fn eval_uniform<'a>(choices: &Vec, hash: u64) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | fn eval_uniform<'a>(choices: &Vec, hash: u64) -> &str { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:200:36 [INFO] [stderr] | [INFO] [stderr] 200 | fn valid_segment<'a, 'b>(segments: &Vec, hash: u64) -> Option<&'b str> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:200:18 [INFO] [stderr] | [INFO] [stderr] 200 | fn valid_segment<'a, 'b>(segments: &Vec, hash: u64) -> Option<&'b str> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "b8502152f922affc3bf93f37ae4ed2ab497a1fbd96615b6d3063f9c59596e931"` [INFO] running `"docker" "rm" "-f" "b8502152f922affc3bf93f37ae4ed2ab497a1fbd96615b6d3063f9c59596e931"` [INFO] [stdout] b8502152f922affc3bf93f37ae4ed2ab497a1fbd96615b6d3063f9c59596e931