[INFO] updating cached repository focusaurus/slugger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/focusaurus/slugger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/focusaurus/slugger" "work/ex/clippy-test-run/sources/stable/gh/focusaurus/slugger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/focusaurus/slugger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/focusaurus/slugger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/focusaurus/slugger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/focusaurus/slugger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 64af05be5494cd4a03ef6f42198cc6409fd921e3 [INFO] sha for GitHub repo focusaurus/slugger: 64af05be5494cd4a03ef6f42198cc6409fd921e3 [INFO] validating manifest of focusaurus/slugger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of focusaurus/slugger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing focusaurus/slugger [INFO] finished frobbing focusaurus/slugger [INFO] frobbed toml for focusaurus/slugger written to work/ex/clippy-test-run/sources/stable/gh/focusaurus/slugger/Cargo.toml [INFO] started frobbing focusaurus/slugger [INFO] finished frobbing focusaurus/slugger [INFO] frobbed toml for focusaurus/slugger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/focusaurus/slugger/Cargo.toml [INFO] crate focusaurus/slugger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting focusaurus/slugger against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/focusaurus/slugger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7ca2f48835cee34d0762f01f1d2833a3486bd7fec54d8adc448be50ea2f65df [INFO] running `"docker" "start" "-a" "a7ca2f48835cee34d0762f01f1d2833a3486bd7fec54d8adc448be50ea2f65df"` [INFO] [stderr] Checking unidecode v0.3.0 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking rsfs v0.4.1 [INFO] [stderr] Checking slugger v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:213:16 [INFO] [stderr] | [INFO] [stderr] 213 | if let Err(_) = rename(&mut fs, &slug) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 214 | | panic!("should not error if existing file is already a slug"); [INFO] [stderr] 215 | | } [INFO] [stderr] | |_________- help: try this: `if rename(&mut fs, &slug).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:14:8 [INFO] [stderr] | [INFO] [stderr] 14 | if args.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:14:8 [INFO] [stderr] | [INFO] [stderr] 14 | if args.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:40:37 [INFO] [stderr] | [INFO] [stderr] 40 | match slugger_main(&mut fs, &vec![]) { [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.84s [INFO] running `"docker" "inspect" "a7ca2f48835cee34d0762f01f1d2833a3486bd7fec54d8adc448be50ea2f65df"` [INFO] running `"docker" "rm" "-f" "a7ca2f48835cee34d0762f01f1d2833a3486bd7fec54d8adc448be50ea2f65df"` [INFO] [stdout] a7ca2f48835cee34d0762f01f1d2833a3486bd7fec54d8adc448be50ea2f65df