[INFO] updating cached repository focusaurus/cody [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/focusaurus/cody [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/focusaurus/cody" "work/ex/clippy-test-run/sources/stable/gh/focusaurus/cody"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/focusaurus/cody'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/focusaurus/cody" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/focusaurus/cody"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/focusaurus/cody'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c7c4e095aaa576adfc3776c29eb089f3e025513 [INFO] sha for GitHub repo focusaurus/cody: 5c7c4e095aaa576adfc3776c29eb089f3e025513 [INFO] validating manifest of focusaurus/cody on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of focusaurus/cody on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing focusaurus/cody [INFO] finished frobbing focusaurus/cody [INFO] frobbed toml for focusaurus/cody written to work/ex/clippy-test-run/sources/stable/gh/focusaurus/cody/Cargo.toml [INFO] started frobbing focusaurus/cody [INFO] finished frobbing focusaurus/cody [INFO] frobbed toml for focusaurus/cody written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/focusaurus/cody/Cargo.toml [INFO] crate focusaurus/cody has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting focusaurus/cody against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/focusaurus/cody:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7746eba3d790906b2a8d229173631042b29cc3748596a4acf51879c6aaaf7a40 [INFO] running `"docker" "start" "-a" "7746eba3d790906b2a8d229173631042b29cc3748596a4acf51879c6aaaf7a40"` [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking cody v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:88:36 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(binary_decimal(vec![0b0000001]).unwrap(), 1); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(binary_decimal(vec![0b0000001, 0b00000001]).unwrap(), 257); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:89:47 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(binary_decimal(vec![0b0000001, 0b00000001]).unwrap(), 257); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:90:36 [INFO] [stderr] | [INFO] [stderr] 90 | assert_eq!(binary_decimal(vec![0b0000001, 0]).unwrap(), 256); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:91:39 [INFO] [stderr] | [INFO] [stderr] 91 | assert_eq!(binary_decimal(vec![0, 0b0000010, 0b00000010]).unwrap(), 514); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:91:50 [INFO] [stderr] | [INFO] [stderr] 91 | assert_eq!(binary_decimal(vec![0, 0b0000010, 0b00000010]).unwrap(), 514); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:93:41 [INFO] [stderr] | [INFO] [stderr] 93 | binary_decimal(vec![0, 0, 0, 0, 0b0000010, 0b00000010]).unwrap(), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:93:52 [INFO] [stderr] | [INFO] [stderr] 93 | binary_decimal(vec![0, 0, 0, 0, 0b0000010, 0b00000010]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | _ => format.into(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | _ => format.into(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | assert_eq!(binary_hexadecimal(&vec![]), "".to_string()); [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:64:30 [INFO] [stderr] | [INFO] [stderr] 64 | assert_eq!(binary_base64(&vec![]), "".to_string()); [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | hexadecimal_binary("01".as_bytes().to_vec()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"01"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:113:28 [INFO] [stderr] | [INFO] [stderr] 113 | hexadecimal_binary("00fe".as_bytes().to_vec()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"00fe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:117:28 [INFO] [stderr] | [INFO] [stderr] 117 | hexadecimal_binary("aa00fe".as_bytes().to_vec()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aa00fe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:120:32 [INFO] [stderr] | [INFO] [stderr] 120 | assert!(hexadecimal_binary("fg".as_bytes().to_vec()).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"fg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | hexadecimal_base64("01".as_bytes().to_vec()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"01"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:138:28 [INFO] [stderr] | [INFO] [stderr] 138 | hexadecimal_base64("00fe".as_bytes().to_vec()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"00fe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:142:28 [INFO] [stderr] | [INFO] [stderr] 142 | hexadecimal_base64("aa00fe".as_bytes().to_vec()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aa00fe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:145:32 [INFO] [stderr] | [INFO] [stderr] 145 | assert!(hexadecimal_base64("fg".as_bytes().to_vec()).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"fg"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:184:30 [INFO] [stderr] | [INFO] [stderr] 184 | assert_eq!(base64_binary("".as_bytes().to_vec()).unwrap().len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:188:23 [INFO] [stderr] | [INFO] [stderr] 188 | base64_binary("SGVsbG8sIENvZHkh".as_bytes().to_vec()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SGVsbG8sIENvZHkh"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:191:27 [INFO] [stderr] | [INFO] [stderr] 191 | assert!(base64_binary("nope-nope".as_bytes().to_vec()).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"nope-nope"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:206:35 [INFO] [stderr] | [INFO] [stderr] 206 | assert_eq!(base64_hexadecimal("".as_bytes().to_vec()).unwrap().len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:210:28 [INFO] [stderr] | [INFO] [stderr] 210 | base64_hexadecimal("SGVsbG8sIENvZHkh".as_bytes().to_vec()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"SGVsbG8sIENvZHkh"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:213:32 [INFO] [stderr] | [INFO] [stderr] 213 | assert!(base64_hexadecimal("nope-nope".as_bytes().to_vec()).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"nope-nope"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:223:28 [INFO] [stderr] | [INFO] [stderr] 223 | assert!(decimal_binary("".as_bytes().to_vec()).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:224:31 [INFO] [stderr] | [INFO] [stderr] 224 | assert_eq!(decimal_binary("10".as_bytes().to_vec()).unwrap(), 10); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"10"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:225:31 [INFO] [stderr] | [INFO] [stderr] 225 | assert_eq!(decimal_binary("256".as_bytes().to_vec()).unwrap(), 256); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"256"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:226:31 [INFO] [stderr] | [INFO] [stderr] 226 | assert_eq!(decimal_binary("-42".as_bytes().to_vec()).unwrap(), -42); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"-42"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:227:28 [INFO] [stderr] | [INFO] [stderr] 227 | assert!(decimal_binary("nope".as_bytes().to_vec()).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"nope"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.50s [INFO] running `"docker" "inspect" "7746eba3d790906b2a8d229173631042b29cc3748596a4acf51879c6aaaf7a40"` [INFO] running `"docker" "rm" "-f" "7746eba3d790906b2a8d229173631042b29cc3748596a4acf51879c6aaaf7a40"` [INFO] [stdout] 7746eba3d790906b2a8d229173631042b29cc3748596a4acf51879c6aaaf7a40