[INFO] updating cached repository flugsio/redi
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/flugsio/redi
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/flugsio/redi" "work/ex/clippy-test-run/sources/stable/gh/flugsio/redi"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/flugsio/redi'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/flugsio/redi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flugsio/redi"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flugsio/redi'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d132d50cf5cc39c73e37d900c530d63d6d03a62e
[INFO] sha for GitHub repo flugsio/redi: d132d50cf5cc39c73e37d900c530d63d6d03a62e
[INFO] validating manifest of flugsio/redi on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of flugsio/redi on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing flugsio/redi
[INFO] finished frobbing flugsio/redi
[INFO] frobbed toml for flugsio/redi written to work/ex/clippy-test-run/sources/stable/gh/flugsio/redi/Cargo.toml
[INFO] started frobbing flugsio/redi
[INFO] finished frobbing flugsio/redi
[INFO] frobbed toml for flugsio/redi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flugsio/redi/Cargo.toml
[INFO] crate flugsio/redi has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting flugsio/redi against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/flugsio/redi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3d8c4ac11c4ddbfb0415c40fd6fdd731176fa1cc417d5c0e8bf4ac2a72cec123
[INFO] running `"docker" "start" "-a" "3d8c4ac11c4ddbfb0415c40fd6fdd731176fa1cc417d5c0e8bf4ac2a72cec123"`
[INFO] [stderr]     Checking redi v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/entity/book.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |             pages: pages,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `pages`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/area.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             links: links,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `links`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:89:5
[INFO] [stderr]    |
[INFO] [stderr] 89 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/entity/book.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |             pages: pages,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `pages`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/area.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             links: links,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `links`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:89:5
[INFO] [stderr]    |
[INFO] [stderr] 89 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/area.rs:30:8
[INFO] [stderr]    |
[INFO] [stderr] 30 |        self.links.get(name).map(|a| a.clone())
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.links.get(name).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:78:8
[INFO] [stderr]    |
[INFO] [stderr] 78 |     if items.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:85:34
[INFO] [stderr]    |
[INFO] [stderr] 85 |                 Entity::Spell => format!(" * one crappy spell"),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" * one crappy spell".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/area.rs:30:8
[INFO] [stderr]    |
[INFO] [stderr] 30 |        self.links.get(name).map(|a| a.clone())
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.links.get(name).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:78:8
[INFO] [stderr]    |
[INFO] [stderr] 78 |     if items.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:85:34
[INFO] [stderr]    |
[INFO] [stderr] 85 |                 Entity::Spell => format!(" * one crappy spell"),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" * one crappy spell".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.79s
[INFO] running `"docker" "inspect" "3d8c4ac11c4ddbfb0415c40fd6fdd731176fa1cc417d5c0e8bf4ac2a72cec123"`
[INFO] running `"docker" "rm" "-f" "3d8c4ac11c4ddbfb0415c40fd6fdd731176fa1cc417d5c0e8bf4ac2a72cec123"`
[INFO] [stdout] 3d8c4ac11c4ddbfb0415c40fd6fdd731176fa1cc417d5c0e8bf4ac2a72cec123