[INFO] updating cached repository floschnell/ascii-platformer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/floschnell/ascii-platformer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/floschnell/ascii-platformer" "work/ex/clippy-test-run/sources/stable/gh/floschnell/ascii-platformer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/floschnell/ascii-platformer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/floschnell/ascii-platformer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/floschnell/ascii-platformer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/floschnell/ascii-platformer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1abd783ef013b2c374e3ba5d1e85ca43a048febd [INFO] sha for GitHub repo floschnell/ascii-platformer: 1abd783ef013b2c374e3ba5d1e85ca43a048febd [INFO] validating manifest of floschnell/ascii-platformer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of floschnell/ascii-platformer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing floschnell/ascii-platformer [INFO] finished frobbing floschnell/ascii-platformer [INFO] frobbed toml for floschnell/ascii-platformer written to work/ex/clippy-test-run/sources/stable/gh/floschnell/ascii-platformer/Cargo.toml [INFO] started frobbing floschnell/ascii-platformer [INFO] finished frobbing floschnell/ascii-platformer [INFO] frobbed toml for floschnell/ascii-platformer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/floschnell/ascii-platformer/Cargo.toml [INFO] crate floschnell/ascii-platformer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting floschnell/ascii-platformer against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/floschnell/ascii-platformer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b716bfdaa91d91d0b30b79d9fb2ec01aab558e25144461cdd37592723e465ee [INFO] running `"docker" "start" "-a" "2b716bfdaa91d91d0b30b79d9fb2ec01aab558e25144461cdd37592723e465ee"` [INFO] [stderr] Checking platformer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Rgb` [INFO] [stderr] --> src/main.rs:5:30 [INFO] [stderr] | [INFO] [stderr] 5 | use termion::color::{Bg, Fg, Rgb}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:97:11 [INFO] [stderr] | [INFO] [stderr] 97 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / if player.speed_y < 0.0 && check_y >= 1.0 { [INFO] [stderr] 154 | | if world.mat[(check_y - 1.0) as usize][check_x as usize] == '#' { [INFO] [stderr] 155 | | player.speed_y = 0.0; [INFO] [stderr] 156 | | new_y = check_y; [INFO] [stderr] 157 | | collision = true; [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 153 | if player.speed_y < 0.0 && check_y >= 1.0 && world.mat[(check_y - 1.0) as usize][check_x as usize] == '#' { [INFO] [stderr] 154 | player.speed_y = 0.0; [INFO] [stderr] 155 | new_y = check_y; [INFO] [stderr] 156 | collision = true; [INFO] [stderr] 157 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / if player.speed_y > 0.0 { [INFO] [stderr] 162 | | if world.mat[(check_y + 1.0) as usize][check_x as usize] == '#' { [INFO] [stderr] 163 | | player.speed_y = 0.0; [INFO] [stderr] 164 | | new_y = check_y; [INFO] [stderr] ... | [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | if player.speed_y > 0.0 && world.mat[(check_y + 1.0) as usize][check_x as usize] == '#' { [INFO] [stderr] 162 | player.speed_y = 0.0; [INFO] [stderr] 163 | new_y = check_y; [INFO] [stderr] 164 | player.on_ground = true; [INFO] [stderr] 165 | collision = true; [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | / if player.speed_x < 0.0 && check_x >= 1.0 { [INFO] [stderr] 171 | | if world.mat[check_y as usize][(check_x - 1.0) as usize] == '#' { [INFO] [stderr] 172 | | player.speed_x = 0.0; [INFO] [stderr] 173 | | new_x = player.x; [INFO] [stderr] 174 | | collision = true; [INFO] [stderr] 175 | | } [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | if player.speed_x < 0.0 && check_x >= 1.0 && world.mat[check_y as usize][(check_x - 1.0) as usize] == '#' { [INFO] [stderr] 171 | player.speed_x = 0.0; [INFO] [stderr] 172 | new_x = player.x; [INFO] [stderr] 173 | collision = true; [INFO] [stderr] 174 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / if player.speed_x > 0.0 { [INFO] [stderr] 179 | | if world.mat[check_y as usize][(check_x + 1.0) as usize] == '#' { [INFO] [stderr] 180 | | player.speed_x = 0.0; [INFO] [stderr] 181 | | new_x = player.x; [INFO] [stderr] 182 | | collision = true; [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | if player.speed_x > 0.0 && world.mat[check_y as usize][(check_x + 1.0) as usize] == '#' { [INFO] [stderr] 179 | player.speed_x = 0.0; [INFO] [stderr] 180 | new_x = player.x; [INFO] [stderr] 181 | collision = true; [INFO] [stderr] 182 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:208:10 [INFO] [stderr] | [INFO] [stderr] 208 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 209 | | if player.walking { [INFO] [stderr] 210 | | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.1; [INFO] [stderr] 211 | | } else { [INFO] [stderr] 212 | | player.speed_x = player.speed_x * 0.95; [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 208 | } else if player.walking { [INFO] [stderr] 209 | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.1; [INFO] [stderr] 210 | } else { [INFO] [stderr] 211 | player.speed_x = player.speed_x * 0.95; [INFO] [stderr] 212 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:235:10 [INFO] [stderr] | [INFO] [stderr] 235 | } else if player.x < display.left as f32 + (display.width as f32 * 0.33) { [INFO] [stderr] | __________^ [INFO] [stderr] 236 | | if display.left > 0 { [INFO] [stderr] 237 | | display.left = (player.x - display.width as f32 * 0.33) as usize; [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 235 | } else if player.x < display.left as f32 + (display.width as f32 * 0.33) && display.left > 0 { [INFO] [stderr] 236 | display.left = (player.x - display.width as f32 * 0.33) as usize; [INFO] [stderr] 237 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:290:55 [INFO] [stderr] | [INFO] [stderr] 290 | fn load_level(world: &mut World, player: &mut Player) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `Rgb` [INFO] [stderr] --> src/main.rs:5:30 [INFO] [stderr] | [INFO] [stderr] 5 | use termion::color::{Bg, Fg, Rgb}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:97:11 [INFO] [stderr] | [INFO] [stderr] 97 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / if player.speed_y < 0.0 && check_y >= 1.0 { [INFO] [stderr] 154 | | if world.mat[(check_y - 1.0) as usize][check_x as usize] == '#' { [INFO] [stderr] 155 | | player.speed_y = 0.0; [INFO] [stderr] 156 | | new_y = check_y; [INFO] [stderr] 157 | | collision = true; [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 153 | if player.speed_y < 0.0 && check_y >= 1.0 && world.mat[(check_y - 1.0) as usize][check_x as usize] == '#' { [INFO] [stderr] 154 | player.speed_y = 0.0; [INFO] [stderr] 155 | new_y = check_y; [INFO] [stderr] 156 | collision = true; [INFO] [stderr] 157 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / if player.speed_y > 0.0 { [INFO] [stderr] 162 | | if world.mat[(check_y + 1.0) as usize][check_x as usize] == '#' { [INFO] [stderr] 163 | | player.speed_y = 0.0; [INFO] [stderr] 164 | | new_y = check_y; [INFO] [stderr] ... | [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | if player.speed_y > 0.0 && world.mat[(check_y + 1.0) as usize][check_x as usize] == '#' { [INFO] [stderr] 162 | player.speed_y = 0.0; [INFO] [stderr] 163 | new_y = check_y; [INFO] [stderr] 164 | player.on_ground = true; [INFO] [stderr] 165 | collision = true; [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | / if player.speed_x < 0.0 && check_x >= 1.0 { [INFO] [stderr] 171 | | if world.mat[check_y as usize][(check_x - 1.0) as usize] == '#' { [INFO] [stderr] 172 | | player.speed_x = 0.0; [INFO] [stderr] 173 | | new_x = player.x; [INFO] [stderr] 174 | | collision = true; [INFO] [stderr] 175 | | } [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | if player.speed_x < 0.0 && check_x >= 1.0 && world.mat[check_y as usize][(check_x - 1.0) as usize] == '#' { [INFO] [stderr] 171 | player.speed_x = 0.0; [INFO] [stderr] 172 | new_x = player.x; [INFO] [stderr] 173 | collision = true; [INFO] [stderr] 174 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / if player.speed_x > 0.0 { [INFO] [stderr] 179 | | if world.mat[check_y as usize][(check_x + 1.0) as usize] == '#' { [INFO] [stderr] 180 | | player.speed_x = 0.0; [INFO] [stderr] 181 | | new_x = player.x; [INFO] [stderr] 182 | | collision = true; [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | if player.speed_x > 0.0 && world.mat[check_y as usize][(check_x + 1.0) as usize] == '#' { [INFO] [stderr] 179 | player.speed_x = 0.0; [INFO] [stderr] 180 | new_x = player.x; [INFO] [stderr] 181 | collision = true; [INFO] [stderr] 182 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:208:10 [INFO] [stderr] | [INFO] [stderr] 208 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 209 | | if player.walking { [INFO] [stderr] 210 | | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.1; [INFO] [stderr] 211 | | } else { [INFO] [stderr] 212 | | player.speed_x = player.speed_x * 0.95; [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 208 | } else if player.walking { [INFO] [stderr] 209 | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.1; [INFO] [stderr] 210 | } else { [INFO] [stderr] 211 | player.speed_x = player.speed_x * 0.95; [INFO] [stderr] 212 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:235:10 [INFO] [stderr] | [INFO] [stderr] 235 | } else if player.x < display.left as f32 + (display.width as f32 * 0.33) { [INFO] [stderr] | __________^ [INFO] [stderr] 236 | | if display.left > 0 { [INFO] [stderr] 237 | | display.left = (player.x - display.width as f32 * 0.33) as usize; [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 235 | } else if player.x < display.left as f32 + (display.width as f32 * 0.33) && display.left > 0 { [INFO] [stderr] 236 | display.left = (player.x - display.width as f32 * 0.33) as usize; [INFO] [stderr] 237 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:290:55 [INFO] [stderr] | [INFO] [stderr] 290 | fn load_level(world: &mut World, player: &mut Player) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | Err(_) => panic!("Could not get terminal size!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:75:3 [INFO] [stderr] | [INFO] [stderr] 75 | write!(stdout, "{}", termion::cursor::Hide); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match stdin.next() { [INFO] [stderr] 79 | | Some(Ok(b)) => { [INFO] [stderr] 80 | | if b == b'q' { [INFO] [stderr] 81 | | panic!("Quit"); [INFO] [stderr] ... | [INFO] [stderr] 100 | | _ => (), [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let Some(Ok(b)) = stdin.next() { [INFO] [stderr] 79 | if b == b'q' { [INFO] [stderr] 80 | panic!("Quit"); [INFO] [stderr] 81 | } else if b == b'w' { [INFO] [stderr] 82 | jump(&mut player) [INFO] [stderr] 83 | } else if b == b'a' { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | for step in 0..(steps.abs() as usize + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=steps.abs() as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:197:24 [INFO] [stderr] | [INFO] [stderr] 197 | } else if player.x > world.width as f32 - 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(world.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:198:16 [INFO] [stderr] | [INFO] [stderr] 198 | player.x = world.width as f32 - 1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(world.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:204:7 [INFO] [stderr] | [INFO] [stderr] 204 | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player.speed_x += player.walking_dir as f32 * 0.25` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:204:41 [INFO] [stderr] | [INFO] [stderr] 204 | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(player.walking_dir)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:206:7 [INFO] [stderr] | [INFO] [stderr] 206 | player.speed_x = player.speed_x * 0.75; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player.speed_x *= 0.75` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:210:7 [INFO] [stderr] | [INFO] [stderr] 210 | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player.speed_x += player.walking_dir as f32 * 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:210:41 [INFO] [stderr] | [INFO] [stderr] 210 | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(player.walking_dir)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:212:7 [INFO] [stderr] | [INFO] [stderr] 212 | player.speed_x = player.speed_x * 0.95; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player.speed_x *= 0.95` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:217:22 [INFO] [stderr] | [INFO] [stderr] 217 | player.speed_x = player.walking_dir as f32 * SPEED_X_MAX; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(player.walking_dir)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:40 [INFO] [stderr] | [INFO] [stderr] 231 | if player.x > display.left as f32 + (display.width as f32 * 0.66) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(display.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:233:34 [INFO] [stderr] | [INFO] [stderr] 233 | display.left = (player.x - display.width as f32 * 0.66) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(display.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:235:47 [INFO] [stderr] | [INFO] [stderr] 235 | } else if player.x < display.left as f32 + (display.width as f32 * 0.33) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(display.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:237:34 [INFO] [stderr] | [INFO] [stderr] 237 | display.left = (player.x - display.width as f32 * 0.33) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(display.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | Err(_) => panic!("Could not load level!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:297:30 [INFO] [stderr] | [INFO] [stderr] 297 | let lines = contents.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the variable `y` is used as a loop counter. Consider using `for (y, item) in lines.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:300:15 [INFO] [stderr] | [INFO] [stderr] 300 | for line in lines { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | Err(_) => panic!("Could not get terminal size!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:75:3 [INFO] [stderr] | [INFO] [stderr] 75 | write!(stdout, "{}", termion::cursor::Hide); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match stdin.next() { [INFO] [stderr] 79 | | Some(Ok(b)) => { [INFO] [stderr] 80 | | if b == b'q' { [INFO] [stderr] 81 | | panic!("Quit"); [INFO] [stderr] ... | [INFO] [stderr] 100 | | _ => (), [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let Some(Ok(b)) = stdin.next() { [INFO] [stderr] 79 | if b == b'q' { [INFO] [stderr] 80 | panic!("Quit"); [INFO] [stderr] 81 | } else if b == b'w' { [INFO] [stderr] 82 | jump(&mut player) [INFO] [stderr] 83 | } else if b == b'a' { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | for step in 0..(steps.abs() as usize + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=steps.abs() as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:197:24 [INFO] [stderr] | [INFO] [stderr] 197 | } else if player.x > world.width as f32 - 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(world.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:198:16 [INFO] [stderr] | [INFO] [stderr] 198 | player.x = world.width as f32 - 1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(world.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:204:7 [INFO] [stderr] | [INFO] [stderr] 204 | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player.speed_x += player.walking_dir as f32 * 0.25` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:204:41 [INFO] [stderr] | [INFO] [stderr] 204 | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(player.walking_dir)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:206:7 [INFO] [stderr] | [INFO] [stderr] 206 | player.speed_x = player.speed_x * 0.75; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player.speed_x *= 0.75` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:210:7 [INFO] [stderr] | [INFO] [stderr] 210 | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player.speed_x += player.walking_dir as f32 * 0.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:210:41 [INFO] [stderr] | [INFO] [stderr] 210 | player.speed_x = player.speed_x + player.walking_dir as f32 * 0.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(player.walking_dir)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:212:7 [INFO] [stderr] | [INFO] [stderr] 212 | player.speed_x = player.speed_x * 0.95; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player.speed_x *= 0.95` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:217:22 [INFO] [stderr] | [INFO] [stderr] 217 | player.speed_x = player.walking_dir as f32 * SPEED_X_MAX; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(player.walking_dir)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:231:40 [INFO] [stderr] | [INFO] [stderr] 231 | if player.x > display.left as f32 + (display.width as f32 * 0.66) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(display.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:233:34 [INFO] [stderr] | [INFO] [stderr] 233 | display.left = (player.x - display.width as f32 * 0.66) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(display.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:235:47 [INFO] [stderr] | [INFO] [stderr] 235 | } else if player.x < display.left as f32 + (display.width as f32 * 0.33) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(display.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:237:34 [INFO] [stderr] | [INFO] [stderr] 237 | display.left = (player.x - display.width as f32 * 0.33) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(display.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | Err(_) => panic!("Could not load level!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:297:30 [INFO] [stderr] | [INFO] [stderr] 297 | let lines = contents.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the variable `y` is used as a loop counter. Consider using `for (y, item) in lines.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:300:15 [INFO] [stderr] | [INFO] [stderr] 300 | for line in lines { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "2b716bfdaa91d91d0b30b79d9fb2ec01aab558e25144461cdd37592723e465ee"` [INFO] running `"docker" "rm" "-f" "2b716bfdaa91d91d0b30b79d9fb2ec01aab558e25144461cdd37592723e465ee"` [INFO] [stdout] 2b716bfdaa91d91d0b30b79d9fb2ec01aab558e25144461cdd37592723e465ee