[INFO] updating cached repository fgaray/project-euler-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fgaray/project-euler-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fgaray/project-euler-rust" "work/ex/clippy-test-run/sources/stable/gh/fgaray/project-euler-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fgaray/project-euler-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fgaray/project-euler-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fgaray/project-euler-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fgaray/project-euler-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d61b820d5bdb1b22269fa9c173c836d3cca64bc5 [INFO] sha for GitHub repo fgaray/project-euler-rust: d61b820d5bdb1b22269fa9c173c836d3cca64bc5 [INFO] validating manifest of fgaray/project-euler-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fgaray/project-euler-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fgaray/project-euler-rust [INFO] finished frobbing fgaray/project-euler-rust [INFO] frobbed toml for fgaray/project-euler-rust written to work/ex/clippy-test-run/sources/stable/gh/fgaray/project-euler-rust/Cargo.toml [INFO] started frobbing fgaray/project-euler-rust [INFO] finished frobbing fgaray/project-euler-rust [INFO] frobbed toml for fgaray/project-euler-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fgaray/project-euler-rust/Cargo.toml [INFO] crate fgaray/project-euler-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fgaray/project-euler-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fgaray/project-euler-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 173c6375b0138c0e576c0e4b433e005f04eaaf6a546062e8d54f03cf7ae306a4 [INFO] running `"docker" "start" "-a" "173c6375b0138c0e576c0e4b433e005f04eaaf6a546062e8d54f03cf7ae306a4"` [INFO] [stderr] Checking euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/problem3/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problem7/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problem9/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return 0 [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/problem9/mod.rs:6:14 [INFO] [stderr] | [INFO] [stderr] 6 | for b in (1..1000) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/problem9/mod.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | for c in (1..1000) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/problem10/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:28:47 [INFO] [stderr] | [INFO] [stderr] 28 | println!("Solution: {}", problem10::solve(2000000)); [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/problem3/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problem7/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problem9/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return 0 [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/problem9/mod.rs:6:14 [INFO] [stderr] | [INFO] [stderr] 6 | for b in (1..1000) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/problem9/mod.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | for c in (1..1000) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/problem10/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:28:47 [INFO] [stderr] | [INFO] [stderr] 28 | println!("Solution: {}", problem10::solve(2000000)); [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d1` [INFO] [stderr] --> src/problem4/mod.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | let mut d1 = 1; [INFO] [stderr] | ^^ help: consider using `_d1` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d2` [INFO] [stderr] --> src/problem4/mod.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | let mut d2 = 1; [INFO] [stderr] | ^^ help: consider using `_d2` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/problem3/mod.rs:20:8 [INFO] [stderr] | [INFO] [stderr] 20 | let mut v = prime.get_mem(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/problem4/mod.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let mut d1 = 1; [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/problem4/mod.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let mut d2 = 1; [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/utils/prime.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let mut v = Vec::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/utils/prime.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let mut v = Vec::with_capacity(capacity); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem3/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn solve(n: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem4/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn solve() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem5/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn solve(n: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem6/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn solve(upper: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem7/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn solve(n: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem9/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn solve(constant: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mem` [INFO] [stderr] --> src/utils/prime.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn get_mem(&mut self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `reverse` [INFO] [stderr] --> src/utils/number.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn reverse(n: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem6/mod.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | let sum_square: i64 = (1..(upper + 1)).map(|x| x*x).sum(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(1..=upper)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem6/mod.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | let sum: i64 = (1..(upper + 1)).sum(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(1..=upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils/fibonacci.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | y = x + y; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `y += x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/utils/prime.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn is_prime(&mut self, n: i64) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/utils/prime.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if x > &s { [INFO] [stderr] | ^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils/number.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | number = number / 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d1` [INFO] [stderr] --> src/problem4/mod.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | let mut d1 = 1; [INFO] [stderr] | ^^ help: consider using `_d1` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `d2` [INFO] [stderr] --> src/problem4/mod.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | let mut d2 = 1; [INFO] [stderr] | ^^ help: consider using `_d2` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/problem3/mod.rs:20:8 [INFO] [stderr] | [INFO] [stderr] 20 | let mut v = prime.get_mem(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/problem4/mod.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let mut d1 = 1; [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/problem4/mod.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let mut d2 = 1; [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/utils/prime.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let mut v = Vec::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/utils/prime.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let mut v = Vec::with_capacity(capacity); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem3/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn solve(n: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem4/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn solve() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem5/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn solve(n: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem6/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn solve(upper: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem7/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn solve(n: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `solve` [INFO] [stderr] --> src/problem9/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn solve(constant: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mem` [INFO] [stderr] --> src/utils/prime.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn get_mem(&mut self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `reverse` [INFO] [stderr] --> src/utils/number.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn reverse(n: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem6/mod.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | let sum_square: i64 = (1..(upper + 1)).map(|x| x*x).sum(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(1..=upper)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/problem6/mod.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | let sum: i64 = (1..(upper + 1)).sum(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(1..=upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils/fibonacci.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | y = x + y; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `y += x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/utils/prime.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn is_prime(&mut self, n: i64) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/utils/prime.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if x > &s { [INFO] [stderr] | ^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utils/number.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | number = number / 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.62s [INFO] running `"docker" "inspect" "173c6375b0138c0e576c0e4b433e005f04eaaf6a546062e8d54f03cf7ae306a4"` [INFO] running `"docker" "rm" "-f" "173c6375b0138c0e576c0e4b433e005f04eaaf6a546062e8d54f03cf7ae306a4"` [INFO] [stdout] 173c6375b0138c0e576c0e4b433e005f04eaaf6a546062e8d54f03cf7ae306a4