[INFO] updating cached repository ffjanp/finding_cycles
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ffjanp/finding_cycles
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ffjanp/finding_cycles" "work/ex/clippy-test-run/sources/stable/gh/ffjanp/finding_cycles"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ffjanp/finding_cycles'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ffjanp/finding_cycles" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ffjanp/finding_cycles"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ffjanp/finding_cycles'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 37c86244bc1f34490dea91ef291560984bb85fc6
[INFO] sha for GitHub repo ffjanp/finding_cycles: 37c86244bc1f34490dea91ef291560984bb85fc6
[INFO] validating manifest of ffjanp/finding_cycles on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ffjanp/finding_cycles on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ffjanp/finding_cycles
[INFO] finished frobbing ffjanp/finding_cycles
[INFO] frobbed toml for ffjanp/finding_cycles written to work/ex/clippy-test-run/sources/stable/gh/ffjanp/finding_cycles/Cargo.toml
[INFO] started frobbing ffjanp/finding_cycles
[INFO] finished frobbing ffjanp/finding_cycles
[INFO] frobbed toml for ffjanp/finding_cycles written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ffjanp/finding_cycles/Cargo.toml
[INFO] crate ffjanp/finding_cycles has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ffjanp/finding_cycles against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ffjanp/finding_cycles:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b18636dfafeb65e88bc9e161118b5ab868676dbefa9fd9426f4cef8859d5efa7
[INFO] running `"docker" "start" "-a" "b18636dfafeb65e88bc9e161118b5ab868676dbefa9fd9426f4cef8859d5efa7"`
[INFO] [stderr]     Checking finding_cycles v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused variable: `file`
[INFO] [stderr]   --> src/main.rs:36:98
[INFO] [stderr]    |
[INFO] [stderr] 36 | fn find_cycles<W: std::io::Write>(graph:&mut HashMap<usize,Vec<usize>>,startnode : usize,n:usize,file:&mut W)   {
[INFO] [stderr]    |                                                                                                  ^^^^ help: consider using `_file` instead
[INFO] [stderr]    |
[INFO] [stderr] warning: unused variable: `file`
[INFO] [stderr]   --> src/main.rs:36:98
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 36 | fn find_cycles<W: std::io::Write>(graph:&mut HashMap<usize,Vec<usize>>,startnode : usize,n:usize,file:&mut W)   {
[INFO] [stderr]    |                                                                                                  ^^^^ help: consider using `_file` instead
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:30:12
[INFO] [stderr]    |
[INFO] [stderr] 30 |         if likes.len() > 0 && likes[likes.len()-1] == node {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!likes.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:30:12
[INFO] [stderr]    |
[INFO] [stderr] 30 |         if likes.len() > 0 && likes[likes.len()-1] == node {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!likes.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:39:11
[INFO] [stderr]    |
[INFO] [stderr] 39 |     while stack.len() > 0 {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:41:12
[INFO] [stderr]    |
[INFO] [stderr] 41 |         if stack[l - 1].1.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack[l - 1].1.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:56:17
[INFO] [stderr]    |
[INFO] [stderr] 56 |         else if stack[l - 1].1.len() == 0 {
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack[l - 1].1.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:39:11
[INFO] [stderr]    |
[INFO] [stderr] 39 |     while stack.len() > 0 {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:41:12
[INFO] [stderr]    |
[INFO] [stderr] 41 |         if stack[l - 1].1.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack[l - 1].1.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:56:17
[INFO] [stderr]    |
[INFO] [stderr] 56 |         else if stack[l - 1].1.len() == 0 {
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack[l - 1].1.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/main.rs:77:30
[INFO] [stderr]    |
[INFO] [stderr] 77 |         graph.entry(edge[0]).or_insert(vec![]).push(edge[1]);
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]   --> src/main.rs:79:22
[INFO] [stderr]    |
[INFO] [stderr] 79 |     for (_,likes) in &mut graph {
[INFO] [stderr]    |                      ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 79 |     for likes in graph.values_mut() {
[INFO] [stderr]    |         ^^^^^    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:95:9
[INFO] [stderr]    |
[INFO] [stderr] 95 |         i = i + 1;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/main.rs:77:30
[INFO] [stderr]    |
[INFO] [stderr] 77 |         graph.entry(edge[0]).or_insert(vec![]).push(edge[1]);
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]   --> src/main.rs:79:22
[INFO] [stderr]    |
[INFO] [stderr] 79 |     for (_,likes) in &mut graph {
[INFO] [stderr]    |                      ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 79 |     for likes in graph.values_mut() {
[INFO] [stderr]    |         ^^^^^    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:95:9
[INFO] [stderr]    |
[INFO] [stderr] 95 |         i = i + 1;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `i += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.40s
[INFO] running `"docker" "inspect" "b18636dfafeb65e88bc9e161118b5ab868676dbefa9fd9426f4cef8859d5efa7"`
[INFO] running `"docker" "rm" "-f" "b18636dfafeb65e88bc9e161118b5ab868676dbefa9fd9426f4cef8859d5efa7"`
[INFO] [stdout] b18636dfafeb65e88bc9e161118b5ab868676dbefa9fd9426f4cef8859d5efa7