[INFO] updating cached repository fb39ca4/iclicker-sniffer-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fb39ca4/iclicker-sniffer-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fb39ca4/iclicker-sniffer-rs" "work/ex/clippy-test-run/sources/stable/gh/fb39ca4/iclicker-sniffer-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fb39ca4/iclicker-sniffer-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fb39ca4/iclicker-sniffer-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fb39ca4/iclicker-sniffer-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fb39ca4/iclicker-sniffer-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9cdcd1f71e64096bb8b3ba3ba3a31b6e7064bad8 [INFO] sha for GitHub repo fb39ca4/iclicker-sniffer-rs: 9cdcd1f71e64096bb8b3ba3ba3a31b6e7064bad8 [INFO] validating manifest of fb39ca4/iclicker-sniffer-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fb39ca4/iclicker-sniffer-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fb39ca4/iclicker-sniffer-rs [INFO] finished frobbing fb39ca4/iclicker-sniffer-rs [INFO] frobbed toml for fb39ca4/iclicker-sniffer-rs written to work/ex/clippy-test-run/sources/stable/gh/fb39ca4/iclicker-sniffer-rs/Cargo.toml [INFO] started frobbing fb39ca4/iclicker-sniffer-rs [INFO] finished frobbing fb39ca4/iclicker-sniffer-rs [INFO] frobbed toml for fb39ca4/iclicker-sniffer-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fb39ca4/iclicker-sniffer-rs/Cargo.toml [INFO] crate fb39ca4/iclicker-sniffer-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fb39ca4/iclicker-sniffer-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fb39ca4/iclicker-sniffer-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3949e97d62b80d9c4d7f945d5ac2a5949573c3f66e6689eb29140d58d9b1447 [INFO] running `"docker" "start" "-a" "a3949e97d62b80d9c4d7f945d5ac2a5949573c3f66e6689eb29140d58d9b1447"` [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking itertools v0.5.9 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking clap v2.20.5 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking iclicker-sniffer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | write!(file, "{}\n", freq).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | write!(file, "{},{}\n", self.sample_count, new_sample).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | write!(file, "{}\n", freq).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | write!(file, "{},{}\n", self.sample_count, new_sample).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 58 | | if self.count > 0 { [INFO] [stderr] 59 | | self.count -= 1; [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | else if self.count > 0 { [INFO] [stderr] 58 | self.count -= 1; [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | ss [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | let ss = SymbolSync { [INFO] [stderr] | __________________^ [INFO] [stderr] 119 | | iterator: samples, [INFO] [stderr] 120 | | prev_sample: T::default(), [INFO] [stderr] 121 | | sample_symbol_ratio: ratio, [INFO] [stderr] ... | [INFO] [stderr] 124 | | file: file, [INFO] [stderr] 125 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:186:30 [INFO] [stderr] | [INFO] [stderr] 186 | while (self.window & 0xffffff) != 0x858585 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:186:43 [INFO] [stderr] | [INFO] [stderr] 186 | while (self.window & 0xffffff) != 0x858585 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0085_8585` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | return ((self.data >> (63 - i)) & 0x1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((self.data >> (63 - i)) & 0x1) as u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return (self.data << start) >> (64 - len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.data << start) >> (64 - len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 58 | | if self.count > 0 { [INFO] [stderr] 59 | | self.count -= 1; [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | else if self.count > 0 { [INFO] [stderr] 58 | self.count -= 1; [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | ss [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | let ss = SymbolSync { [INFO] [stderr] | __________________^ [INFO] [stderr] 119 | | iterator: samples, [INFO] [stderr] 120 | | prev_sample: T::default(), [INFO] [stderr] 121 | | sample_symbol_ratio: ratio, [INFO] [stderr] ... | [INFO] [stderr] 124 | | file: file, [INFO] [stderr] 125 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:186:30 [INFO] [stderr] | [INFO] [stderr] 186 | while (self.window & 0xffffff) != 0x858585 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:186:43 [INFO] [stderr] | [INFO] [stderr] 186 | while (self.window & 0xffffff) != 0x858585 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0085_8585` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | return ((self.data >> (63 - i)) & 0x1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((self.data >> (63 - i)) & 0x1) as u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return (self.data << start) >> (64 - len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.data << start) >> (64 - len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.file { [INFO] [stderr] 98 | | Some(ref mut file) => { [INFO] [stderr] 99 | | write!(file, "{}\n", freq).unwrap(); [INFO] [stderr] 100 | | }, [INFO] [stderr] 101 | | None => (), [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | if let Some(ref mut file) = self.file { [INFO] [stderr] 98 | write!(file, "{}\n", freq).unwrap(); [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | / match self.file { [INFO] [stderr] 141 | | Some(ref mut file) => { [INFO] [stderr] 142 | | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] 143 | | }, [INFO] [stderr] 144 | | None => (), [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(ref mut file) = self.file { [INFO] [stderr] 141 | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] 142 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | / match self.file { [INFO] [stderr] 155 | | Some(ref mut file) => { [INFO] [stderr] 156 | | write!(file, "{},{}\n", self.sample_count, new_sample).unwrap(); [INFO] [stderr] 157 | | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] 158 | | }, [INFO] [stderr] 159 | | None => (), [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(ref mut file) = self.file { [INFO] [stderr] 155 | write!(file, "{},{}\n", self.sample_count, new_sample).unwrap(); [INFO] [stderr] 156 | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] 157 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | self.window = self.window << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.window <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:281:10 [INFO] [stderr] | [INFO] [stderr] 281 | ((d0 as u32) << 24) | ((d1 as u32) << 16) | ((d2 as u32) << 8) | (d3 as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(d0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:281:32 [INFO] [stderr] | [INFO] [stderr] 281 | ((d0 as u32) << 24) | ((d1 as u32) << 16) | ((d2 as u32) << 8) | (d3 as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(d1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:281:54 [INFO] [stderr] | [INFO] [stderr] 281 | ((d0 as u32) << 24) | ((d1 as u32) << 16) | ((d2 as u32) << 8) | (d3 as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(d2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:281:74 [INFO] [stderr] | [INFO] [stderr] 281 | ((d0 as u32) << 24) | ((d1 as u32) << 16) | ((d2 as u32) << 8) | (d3 as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(d3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:294:29 [INFO] [stderr] | [INFO] [stderr] 294 | if frequency > 0 { Some(frequency as f64 * 1e6) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(frequency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | Err(format!("Gain must be nonnegative.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Gain must be nonnegative.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:320:23 [INFO] [stderr] | [INFO] [stderr] 320 | Err(e) => Err(format!("Gain must be a number.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Gain must be a number.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:331:21 [INFO] [stderr] | [INFO] [stderr] 331 | Err(format!("Sample rate must be positive.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Sample rate must be positive.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:334:23 [INFO] [stderr] | [INFO] [stderr] 334 | Err(e) => Err(format!("Sample rate must be a number.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Sample rate must be a number.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:343:23 [INFO] [stderr] | [INFO] [stderr] 343 | Err(e) => Err(format!("Device index must be a positive integer")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Device index must be a positive integer".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:428:19 [INFO] [stderr] | [INFO] [stderr] 428 | .map(|x| (x.unwrap() as f32 - 127.5) / 127.5) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(x.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.file { [INFO] [stderr] 98 | | Some(ref mut file) => { [INFO] [stderr] 99 | | write!(file, "{}\n", freq).unwrap(); [INFO] [stderr] 100 | | }, [INFO] [stderr] 101 | | None => (), [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | if let Some(ref mut file) = self.file { [INFO] [stderr] 98 | write!(file, "{}\n", freq).unwrap(); [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | / match self.file { [INFO] [stderr] 141 | | Some(ref mut file) => { [INFO] [stderr] 142 | | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] 143 | | }, [INFO] [stderr] 144 | | None => (), [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(ref mut file) = self.file { [INFO] [stderr] 141 | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] 142 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | / match self.file { [INFO] [stderr] 155 | | Some(ref mut file) => { [INFO] [stderr] 156 | | write!(file, "{},{}\n", self.sample_count, new_sample).unwrap(); [INFO] [stderr] 157 | | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] 158 | | }, [INFO] [stderr] 159 | | None => (), [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(ref mut file) = self.file { [INFO] [stderr] 155 | write!(file, "{},{}\n", self.sample_count, new_sample).unwrap(); [INFO] [stderr] 156 | write!(file, "{},0\n", self.sample_count).unwrap(); [INFO] [stderr] 157 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | self.window = self.window << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.window <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:281:10 [INFO] [stderr] | [INFO] [stderr] 281 | ((d0 as u32) << 24) | ((d1 as u32) << 16) | ((d2 as u32) << 8) | (d3 as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(d0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:281:32 [INFO] [stderr] | [INFO] [stderr] 281 | ((d0 as u32) << 24) | ((d1 as u32) << 16) | ((d2 as u32) << 8) | (d3 as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(d1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:281:54 [INFO] [stderr] | [INFO] [stderr] 281 | ((d0 as u32) << 24) | ((d1 as u32) << 16) | ((d2 as u32) << 8) | (d3 as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(d2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:281:74 [INFO] [stderr] | [INFO] [stderr] 281 | ((d0 as u32) << 24) | ((d1 as u32) << 16) | ((d2 as u32) << 8) | (d3 as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(d3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:294:29 [INFO] [stderr] | [INFO] [stderr] 294 | if frequency > 0 { Some(frequency as f64 * 1e6) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(frequency)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | Err(format!("Gain must be nonnegative.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Gain must be nonnegative.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:320:23 [INFO] [stderr] | [INFO] [stderr] 320 | Err(e) => Err(format!("Gain must be a number.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Gain must be a number.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:331:21 [INFO] [stderr] | [INFO] [stderr] 331 | Err(format!("Sample rate must be positive.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Sample rate must be positive.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:334:23 [INFO] [stderr] | [INFO] [stderr] 334 | Err(e) => Err(format!("Sample rate must be a number.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Sample rate must be a number.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:343:23 [INFO] [stderr] | [INFO] [stderr] 343 | Err(e) => Err(format!("Device index must be a positive integer")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Device index must be a positive integer".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:428:19 [INFO] [stderr] | [INFO] [stderr] 428 | .map(|x| (x.unwrap() as f32 - 127.5) / 127.5) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(x.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.94s [INFO] running `"docker" "inspect" "a3949e97d62b80d9c4d7f945d5ac2a5949573c3f66e6689eb29140d58d9b1447"` [INFO] running `"docker" "rm" "-f" "a3949e97d62b80d9c4d7f945d5ac2a5949573c3f66e6689eb29140d58d9b1447"` [INFO] [stdout] a3949e97d62b80d9c4d7f945d5ac2a5949573c3f66e6689eb29140d58d9b1447