[INFO] updating cached repository fanzeyi/xatu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fanzeyi/xatu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fanzeyi/xatu" "work/ex/clippy-test-run/sources/stable/gh/fanzeyi/xatu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fanzeyi/xatu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fanzeyi/xatu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fanzeyi/xatu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fanzeyi/xatu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae5a96372a631c708fbafe36a6b7911385d02990 [INFO] sha for GitHub repo fanzeyi/xatu: ae5a96372a631c708fbafe36a6b7911385d02990 [INFO] validating manifest of fanzeyi/xatu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fanzeyi/xatu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fanzeyi/xatu [INFO] finished frobbing fanzeyi/xatu [INFO] frobbed toml for fanzeyi/xatu written to work/ex/clippy-test-run/sources/stable/gh/fanzeyi/xatu/Cargo.toml [INFO] started frobbing fanzeyi/xatu [INFO] finished frobbing fanzeyi/xatu [INFO] frobbed toml for fanzeyi/xatu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fanzeyi/xatu/Cargo.toml [INFO] crate fanzeyi/xatu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fanzeyi/xatu against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fanzeyi/xatu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f2185808d584aa7ccad6404165f67200a61e50ca09b50961d5ba1bfbf6e228fb [INFO] running `"docker" "start" "-a" "f2185808d584aa7ccad6404165f67200a61e50ca09b50961d5ba1bfbf6e228fb"` [INFO] [stderr] Checking xatu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/types.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | ttype: ttype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ttype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/types.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | ttype: ttype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ttype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/token/lexer.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | fn new(input: &'a String) -> Self { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/token/lexer.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / loop { [INFO] [stderr] 43 | | if let Some(c) = self.input.peek() { [INFO] [stderr] 44 | | if IDENTIFIER.contains(c) { [INFO] [stderr] 45 | | result.push(**c); [INFO] [stderr] ... | [INFO] [stderr] 53 | | self.input.next(); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.input.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/token/lexer.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / loop { [INFO] [stderr] 63 | | if let Some(c) = self.input.peek() { [INFO] [stderr] 64 | | if INTEGERS.contains(c) { [INFO] [stderr] 65 | | result.push(**c); [INFO] [stderr] ... | [INFO] [stderr] 73 | | self.input.next(); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.input.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/token/lexer.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | fn new(input: &'a String) -> Self { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/token/lexer.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / loop { [INFO] [stderr] 43 | | if let Some(c) = self.input.peek() { [INFO] [stderr] 44 | | if IDENTIFIER.contains(c) { [INFO] [stderr] 45 | | result.push(**c); [INFO] [stderr] ... | [INFO] [stderr] 53 | | self.input.next(); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.input.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/token/lexer.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / loop { [INFO] [stderr] 63 | | if let Some(c) = self.input.peek() { [INFO] [stderr] 64 | | if INTEGERS.contains(c) { [INFO] [stderr] 65 | | result.push(**c); [INFO] [stderr] ... | [INFO] [stderr] 73 | | self.input.next(); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.input.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.33s [INFO] running `"docker" "inspect" "f2185808d584aa7ccad6404165f67200a61e50ca09b50961d5ba1bfbf6e228fb"` [INFO] running `"docker" "rm" "-f" "f2185808d584aa7ccad6404165f67200a61e50ca09b50961d5ba1bfbf6e228fb"` [INFO] [stdout] f2185808d584aa7ccad6404165f67200a61e50ca09b50961d5ba1bfbf6e228fb