[INFO] updating cached repository fangyi-zhou/sat-solver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/fangyi-zhou/sat-solver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/fangyi-zhou/sat-solver" "work/ex/clippy-test-run/sources/stable/gh/fangyi-zhou/sat-solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/fangyi-zhou/sat-solver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/fangyi-zhou/sat-solver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fangyi-zhou/sat-solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fangyi-zhou/sat-solver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 94465e202e71071d0c6c0473b2fcc96d4c1f21a4 [INFO] sha for GitHub repo fangyi-zhou/sat-solver: 94465e202e71071d0c6c0473b2fcc96d4c1f21a4 [INFO] validating manifest of fangyi-zhou/sat-solver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fangyi-zhou/sat-solver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fangyi-zhou/sat-solver [INFO] finished frobbing fangyi-zhou/sat-solver [INFO] frobbed toml for fangyi-zhou/sat-solver written to work/ex/clippy-test-run/sources/stable/gh/fangyi-zhou/sat-solver/Cargo.toml [INFO] started frobbing fangyi-zhou/sat-solver [INFO] finished frobbing fangyi-zhou/sat-solver [INFO] frobbed toml for fangyi-zhou/sat-solver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fangyi-zhou/sat-solver/Cargo.toml [INFO] crate fangyi-zhou/sat-solver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fangyi-zhou/sat-solver against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/fangyi-zhou/sat-solver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b57de40ed3cdaaaa02773d5618db27c4c66f18a33b176cef1afa16b8f193c1b [INFO] running `"docker" "start" "-a" "2b57de40ed3cdaaaa02773d5618db27c4c66f18a33b176cef1afa16b8f193c1b"` [INFO] [stderr] Checking sat-solver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variant is never constructed: `Var` [INFO] [stderr] --> src/expr.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Var(String), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `And` [INFO] [stderr] --> src/expr.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | And(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Or` [INFO] [stderr] --> src/expr.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Or(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `If` [INFO] [stderr] --> src/expr.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | If(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Iff` [INFO] [stderr] --> src/expr.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Iff(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Not` [INFO] [stderr] --> src/expr.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Not(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lit` [INFO] [stderr] --> src/expr.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Lit(bool) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `eval` [INFO] [stderr] --> src/expr.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | fn eval(&self, dict: &HashMap) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/expr.rs:23:33 [INFO] [stderr] | [INFO] [stderr] 23 | Expr::Var(ref v) => dict.get(v).expect("Dictionary does not contain variable").clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*dict.get(v).expect("Dictionary does not contain variable")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/expr.rs:23:33 [INFO] [stderr] | [INFO] [stderr] 23 | Expr::Var(ref v) => dict.get(v).expect("Dictionary does not contain variable").clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*dict.get(v).expect("Dictionary does not contain variable")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "2b57de40ed3cdaaaa02773d5618db27c4c66f18a33b176cef1afa16b8f193c1b"` [INFO] running `"docker" "rm" "-f" "2b57de40ed3cdaaaa02773d5618db27c4c66f18a33b176cef1afa16b8f193c1b"` [INFO] [stdout] 2b57de40ed3cdaaaa02773d5618db27c4c66f18a33b176cef1afa16b8f193c1b