[INFO] updating cached repository exyi/anyexec2C [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/exyi/anyexec2C [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/exyi/anyexec2C" "work/ex/clippy-test-run/sources/stable/gh/exyi/anyexec2C"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/exyi/anyexec2C'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/exyi/anyexec2C" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/exyi/anyexec2C"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/exyi/anyexec2C'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e9d542abd2c2acfa8e73eefe278d2d00d178b62a [INFO] sha for GitHub repo exyi/anyexec2C: e9d542abd2c2acfa8e73eefe278d2d00d178b62a [INFO] validating manifest of exyi/anyexec2C on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of exyi/anyexec2C on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing exyi/anyexec2C [INFO] finished frobbing exyi/anyexec2C [INFO] frobbed toml for exyi/anyexec2C written to work/ex/clippy-test-run/sources/stable/gh/exyi/anyexec2C/Cargo.toml [INFO] started frobbing exyi/anyexec2C [INFO] finished frobbing exyi/anyexec2C [INFO] frobbed toml for exyi/anyexec2C written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/exyi/anyexec2C/Cargo.toml [INFO] crate exyi/anyexec2C has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting exyi/anyexec2C against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/exyi/anyexec2C:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 046ac078d28cc947628221e8947173283e2c79c31888592bd995194d306709c3 [INFO] running `"docker" "start" "-a" "046ac078d28cc947628221e8947173283e2c79c31888592bd995194d306709c3"` [INFO] [stderr] Checking anyexec2c v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:102:47 [INFO] [stderr] | [INFO] [stderr] 102 | let f = BufReader::new(File::open(&f).expect(&format!( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 103 | | "Could not find comment file - {}", [INFO] [stderr] 104 | | &f [INFO] [stderr] 105 | | ))); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Could not find comment file - {}", &f))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:115:41 [INFO] [stderr] | [INFO] [stderr] 115 | let extension = extension.split(".").last(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | compile(&format!("cargo build -Z unstable-options --release --target x86_64-unknown-linux-musl --out-dir ."), pn) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cargo build -Z unstable-options --release --target x86_64-unknown-linux-musl --out-dir .".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:176:41 [INFO] [stderr] | [INFO] [stderr] 176 | let mut parts = build_command.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:183:10 [INFO] [stderr] | [INFO] [stderr] 183 | .expect(&format!("Failed to execute compiler. Command:\n{}", build_command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to execute compiler. Command:\n{}", build_command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:218:10 [INFO] [stderr] | [INFO] [stderr] 218 | .expect(&format!("Failed to execute bash command. Command:\n{}", cmd)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to execute bash command. Command:\n{}", cmd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:102:47 [INFO] [stderr] | [INFO] [stderr] 102 | let f = BufReader::new(File::open(&f).expect(&format!( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 103 | | "Could not find comment file - {}", [INFO] [stderr] 104 | | &f [INFO] [stderr] 105 | | ))); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Could not find comment file - {}", &f))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:115:41 [INFO] [stderr] | [INFO] [stderr] 115 | let extension = extension.split(".").last(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | compile(&format!("cargo build -Z unstable-options --release --target x86_64-unknown-linux-musl --out-dir ."), pn) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"cargo build -Z unstable-options --release --target x86_64-unknown-linux-musl --out-dir .".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:176:41 [INFO] [stderr] | [INFO] [stderr] 176 | let mut parts = build_command.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:183:10 [INFO] [stderr] | [INFO] [stderr] 183 | .expect(&format!("Failed to execute compiler. Command:\n{}", build_command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to execute compiler. Command:\n{}", build_command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:218:10 [INFO] [stderr] | [INFO] [stderr] 218 | .expect(&format!("Failed to execute bash command. Command:\n{}", cmd)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to execute bash command. Command:\n{}", cmd))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "046ac078d28cc947628221e8947173283e2c79c31888592bd995194d306709c3"` [INFO] running `"docker" "rm" "-f" "046ac078d28cc947628221e8947173283e2c79c31888592bd995194d306709c3"` [INFO] [stdout] 046ac078d28cc947628221e8947173283e2c79c31888592bd995194d306709c3