[INFO] updating cached repository excelciordan/rust_float_pt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/excelciordan/rust_float_pt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/excelciordan/rust_float_pt" "work/ex/clippy-test-run/sources/stable/gh/excelciordan/rust_float_pt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/excelciordan/rust_float_pt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/excelciordan/rust_float_pt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/excelciordan/rust_float_pt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/excelciordan/rust_float_pt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9bf5ad5f346d7354940b8ccb3e7026f9f60eced1 [INFO] sha for GitHub repo excelciordan/rust_float_pt: 9bf5ad5f346d7354940b8ccb3e7026f9f60eced1 [INFO] validating manifest of excelciordan/rust_float_pt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of excelciordan/rust_float_pt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing excelciordan/rust_float_pt [INFO] finished frobbing excelciordan/rust_float_pt [INFO] frobbed toml for excelciordan/rust_float_pt written to work/ex/clippy-test-run/sources/stable/gh/excelciordan/rust_float_pt/Cargo.toml [INFO] started frobbing excelciordan/rust_float_pt [INFO] finished frobbing excelciordan/rust_float_pt [INFO] frobbed toml for excelciordan/rust_float_pt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/excelciordan/rust_float_pt/Cargo.toml [INFO] crate excelciordan/rust_float_pt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting excelciordan/rust_float_pt against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/excelciordan/rust_float_pt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9610d65af70704e0050b0fc8c19350e657833905b45dd44b6cc6b5822869892b [INFO] running `"docker" "start" "-a" "9610d65af70704e0050b0fc8c19350e657833905b45dd44b6cc6b5822869892b"` [INFO] [stderr] Checking floatpt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | let temp_right = right ^ 0x80000000; // Invert HO bit [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/float_pt.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return from >> 31; // shift the HO bit to the LO bit [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from >> 31` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/float_pt.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return ((from >> 23) & 0xff as u32) - 127; // no assignment [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((from >> 23) & 0xff as u32) - 127` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/float_pt.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return (from & 0x7fffff as u32) | 0x800000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(from & 0x7fffff as u32) | 0x800000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | if (from & 0x7fffff as u32) == 0 {return 0} [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | return (from & 0x7fffff as u32) | 0x800000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:48:39 [INFO] [stderr] | [INFO] [stderr] 48 | return (from & 0x7fffff as u32) | 0x800000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:62:53 [INFO] [stderr] | [INFO] [stderr] 62 | 0xffff, 0x1ffff, 0x3ffff, 0x7ffff, 0xfffff, 0x1fffff, 0x3fffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:62:63 [INFO] [stderr] | [INFO] [stderr] 62 | 0xffff, 0x1ffff, 0x3ffff, 0x7ffff, 0xfffff, 0x1fffff, 0x3fffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x003f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | 0x7fffff [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:70:53 [INFO] [stderr] | [INFO] [stderr] 70 | 0x8000, 0x10000, 0x20000, 0x40000, 0x80000, 0x100000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | 0x200000, 400000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | 0x200000, 400000 [INFO] [stderr] | ^^^^^^ help: consider: `400_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/float_pt.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | return num_to_shift >> num_shifts; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num_to_shift >> num_shifts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/float_pt.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | if (num_to_shift >> num_shifts - 1) & 1 == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `num_to_shift >> (num_shifts - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/float_pt.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn fpadd(left:Fpnum, right:Fpnum, dest:&Fpnum) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Fpnum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/float_pt.rs:17:44 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn fpsub(left:Fpnum, right:Fpnum, dest:&Fpnum) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Fpnum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/float_pt.rs:51:60 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn shift_and_round(num_to_shift:&mut Fpnum, num_shifts:&Fpnum) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Fpnum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/float_pt.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | *num_to_shift = *num_to_shift >> *num_shifts; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*num_to_shift >>= *num_shifts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/float_pt.rs:99:50 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn shift_and_round_my_solution(num_to_shift: &Fpnum, num_shifts: &u32) -> Fpnum { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Fpnum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/float_pt.rs:99:70 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn shift_and_round_my_solution(num_to_shift: &Fpnum, num_shifts: &u32) -> Fpnum { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | let temp_right = right ^ 0x80000000; // Invert HO bit [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/float_pt.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return from >> 31; // shift the HO bit to the LO bit [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from >> 31` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/float_pt.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return ((from >> 23) & 0xff as u32) - 127; // no assignment [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((from >> 23) & 0xff as u32) - 127` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/float_pt.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return (from & 0x7fffff as u32) | 0x800000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(from & 0x7fffff as u32) | 0x800000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | if (from & 0x7fffff as u32) == 0 {return 0} [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | return (from & 0x7fffff as u32) | 0x800000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:48:39 [INFO] [stderr] | [INFO] [stderr] 48 | return (from & 0x7fffff as u32) | 0x800000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:62:53 [INFO] [stderr] | [INFO] [stderr] 62 | 0xffff, 0x1ffff, 0x3ffff, 0x7ffff, 0xfffff, 0x1fffff, 0x3fffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:62:63 [INFO] [stderr] | [INFO] [stderr] 62 | 0xffff, 0x1ffff, 0x3ffff, 0x7ffff, 0xfffff, 0x1fffff, 0x3fffff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x003f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | 0x7fffff [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:70:53 [INFO] [stderr] | [INFO] [stderr] 70 | 0x8000, 0x10000, 0x20000, 0x40000, 0x80000, 0x100000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | 0x200000, 400000 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | 0x200000, 400000 [INFO] [stderr] | ^^^^^^ help: consider: `400_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/float_pt.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | return num_to_shift >> num_shifts; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num_to_shift >> num_shifts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/float_pt.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | if (num_to_shift >> num_shifts - 1) & 1 == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `num_to_shift >> (num_shifts - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | assert_eq!(1, 0x80000000 >> 31) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float_pt.rs:175:23 [INFO] [stderr] | [INFO] [stderr] 175 | assert_eq!(1, 0x80000000 as u32 >> 31) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/float_pt.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn fpadd(left:Fpnum, right:Fpnum, dest:&Fpnum) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Fpnum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/float_pt.rs:17:44 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn fpsub(left:Fpnum, right:Fpnum, dest:&Fpnum) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Fpnum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/float_pt.rs:51:60 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn shift_and_round(num_to_shift:&mut Fpnum, num_shifts:&Fpnum) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Fpnum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/float_pt.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | *num_to_shift = *num_to_shift >> *num_shifts; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*num_to_shift >>= *num_shifts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/float_pt.rs:99:50 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn shift_and_round_my_solution(num_to_shift: &Fpnum, num_shifts: &u32) -> Fpnum { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Fpnum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/float_pt.rs:99:70 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn shift_and_round_my_solution(num_to_shift: &Fpnum, num_shifts: &u32) -> Fpnum { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `&` [INFO] [stderr] --> src/float_pt.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | assert_eq!(1, (0x2 >> 1) & 0x1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: literal out of range for i32 [INFO] [stderr] --> src/float_pt.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | assert_eq!(1, 0x80000000 >> 31) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0x80000000` (decimal `2147483648`) does not fit into an `i32` and will become `-2147483648i32` [INFO] [stderr] = help: consider using `u32` instead [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/float_pt.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | assert_ne!(a as f32,b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/float_pt.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | assert_ne!(a as f32,b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `floatpt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unit_tests.rs:5:51 [INFO] [stderr] | [INFO] [stderr] 5 | assert_eq!(1, floatpt::float_pt::extract_sign(0x80000000 as u32)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unit_tests.rs:11:55 [INFO] [stderr] | [INFO] [stderr] 11 | assert_eq!(0, floatpt::float_pt::extract_exponent(0x3f800000 as u32)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3f80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unit_tests.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | assert_eq!(0x80000f as u32, floatpt::float_pt::extract_mantisa(0x0000000f as u32)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_000f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unit_tests.rs:16:68 [INFO] [stderr] | [INFO] [stderr] 16 | assert_eq!(0x80000f as u32, floatpt::float_pt::extract_mantisa(0x0000000f as u32)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_000f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unit_tests.rs:21:33 [INFO] [stderr] | [INFO] [stderr] 21 | let mut num_to_shift: u32 = 0xf01000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00f0_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unit_tests.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | let mut num_to_shift: u32 = 0xf80000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00f8_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unit_tests.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | let mut num_to_shift: u32 = 0xf70000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00f7_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unit_tests.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | let mut num_to_shift: u32 = 0xe80000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00e8_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "9610d65af70704e0050b0fc8c19350e657833905b45dd44b6cc6b5822869892b"` [INFO] running `"docker" "rm" "-f" "9610d65af70704e0050b0fc8c19350e657833905b45dd44b6cc6b5822869892b"` [INFO] [stdout] 9610d65af70704e0050b0fc8c19350e657833905b45dd44b6cc6b5822869892b