[INFO] updating cached repository evantypanski/gremulator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/evantypanski/gremulator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/evantypanski/gremulator" "work/ex/clippy-test-run/sources/stable/gh/evantypanski/gremulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/evantypanski/gremulator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/evantypanski/gremulator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evantypanski/gremulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evantypanski/gremulator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7490ba17796aba4e992e44818a17c9fd1758fb12 [INFO] sha for GitHub repo evantypanski/gremulator: 7490ba17796aba4e992e44818a17c9fd1758fb12 [INFO] validating manifest of evantypanski/gremulator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of evantypanski/gremulator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing evantypanski/gremulator [INFO] finished frobbing evantypanski/gremulator [INFO] frobbed toml for evantypanski/gremulator written to work/ex/clippy-test-run/sources/stable/gh/evantypanski/gremulator/Cargo.toml [INFO] started frobbing evantypanski/gremulator [INFO] finished frobbing evantypanski/gremulator [INFO] frobbed toml for evantypanski/gremulator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evantypanski/gremulator/Cargo.toml [INFO] crate evantypanski/gremulator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting evantypanski/gremulator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/evantypanski/gremulator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7be1d72e4990eaecd2d9047c26fc4d2f1452986b87e6689e56775822dd6b3db [INFO] running `"docker" "start" "-a" "d7be1d72e4990eaecd2d9047c26fc4d2f1452986b87e6689e56775822dd6b3db"` [INFO] [stderr] Checking gremulator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/register.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if (set) { self.f |= (1 << offset); } [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/register.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | if (set) { self.f |= (1 << offset); } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | reg.f = 0b01010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/register.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if (set) { self.f |= (1 << offset); } [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/register.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | if (set) { self.f |= (1 << offset); } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/cpu.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | other => panic!("Instruction not implemented!"), [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | let mut cpu = CPU::new(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `a` [INFO] [stderr] --> src/mmu.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | a: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::CPU` [INFO] [stderr] --> src/cpu.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> CPU { [INFO] [stderr] 9 | | CPU { [INFO] [stderr] 10 | | registers: ::register::Registers::new(), [INFO] [stderr] 11 | | mmu: ::mmu::MMU::new(), [INFO] [stderr] 12 | | halted: false, [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | impl Default for cpu::CPU { [INFO] [stderr] 8 | fn default() -> Self { [INFO] [stderr] 9 | Self::new() [INFO] [stderr] 10 | } [INFO] [stderr] 11 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | self.registers.a = self.registers.a + val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a += val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/cpu.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | set = self.registers.a + val > 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/cpu.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | set = self.registers.a + val > 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0xff is the maximum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | self.registers.a = self.registers.a - val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a -= val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | self.registers.a = self.registers.a & val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a &= val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | self.registers.a = self.registers.a | val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a |= val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | self.registers.a = self.registers.a ^ val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a ^= val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/register.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | ((self.h as u16) << 8) + self.l as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/register.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | ((self.h as u16) << 8) + self.l as u16 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `other` [INFO] [stderr] --> src/cpu.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | other => panic!("Instruction not implemented!"), [INFO] [stderr] | ^^^^^ help: consider using `_other` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `halted` [INFO] [stderr] --> src/cpu.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | halted: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `a` [INFO] [stderr] --> src/mmu.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | a: u8, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::CPU` [INFO] [stderr] --> src/cpu.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> CPU { [INFO] [stderr] 9 | | CPU { [INFO] [stderr] 10 | | registers: ::register::Registers::new(), [INFO] [stderr] 11 | | mmu: ::mmu::MMU::new(), [INFO] [stderr] 12 | | halted: false, [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | impl Default for cpu::CPU { [INFO] [stderr] 8 | fn default() -> Self { [INFO] [stderr] 9 | Self::new() [INFO] [stderr] 10 | } [INFO] [stderr] 11 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | self.registers.a = self.registers.a + val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a += val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: comparison is useless due to type limits [INFO] [stderr] --> src/cpu.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | set = self.registers.a + val > 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_comparisons)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/cpu.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | set = self.registers.a + val > 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0xff is the maximum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | self.registers.a = self.registers.a - val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a -= val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | self.registers.a = self.registers.a & val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a &= val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | self.registers.a = self.registers.a | val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a |= val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | self.registers.a = self.registers.a ^ val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.registers.a ^= val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mbc.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | file.read_to_end(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/register.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | ((self.h as u16) << 8) + self.l as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/register.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | ((self.h as u16) << 8) + self.l as u16 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `gremulator`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mbc.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | file.read_to_end(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gremulator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d7be1d72e4990eaecd2d9047c26fc4d2f1452986b87e6689e56775822dd6b3db"` [INFO] running `"docker" "rm" "-f" "d7be1d72e4990eaecd2d9047c26fc4d2f1452986b87e6689e56775822dd6b3db"` [INFO] [stdout] d7be1d72e4990eaecd2d9047c26fc4d2f1452986b87e6689e56775822dd6b3db