[INFO] updating cached repository ericye16/rusty-tic-tac-toe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ericye16/rusty-tic-tac-toe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ericye16/rusty-tic-tac-toe" "work/ex/clippy-test-run/sources/stable/gh/ericye16/rusty-tic-tac-toe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ericye16/rusty-tic-tac-toe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ericye16/rusty-tic-tac-toe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericye16/rusty-tic-tac-toe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericye16/rusty-tic-tac-toe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dda5667cea5006f90d7782d60ec13d08a39353bb [INFO] sha for GitHub repo ericye16/rusty-tic-tac-toe: dda5667cea5006f90d7782d60ec13d08a39353bb [INFO] validating manifest of ericye16/rusty-tic-tac-toe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ericye16/rusty-tic-tac-toe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ericye16/rusty-tic-tac-toe [INFO] finished frobbing ericye16/rusty-tic-tac-toe [INFO] frobbed toml for ericye16/rusty-tic-tac-toe written to work/ex/clippy-test-run/sources/stable/gh/ericye16/rusty-tic-tac-toe/Cargo.toml [INFO] started frobbing ericye16/rusty-tic-tac-toe [INFO] finished frobbing ericye16/rusty-tic-tac-toe [INFO] frobbed toml for ericye16/rusty-tic-tac-toe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericye16/rusty-tic-tac-toe/Cargo.toml [INFO] crate ericye16/rusty-tic-tac-toe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ericye16/rusty-tic-tac-toe against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ericye16/rusty-tic-tac-toe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 02c0c9deaa182aa35b196f648c1756c3445b697a0a290e40ac5e6521182cb304 [INFO] running `"docker" "start" "-a" "02c0c9deaa182aa35b196f648c1756c3445b697a0a290e40ac5e6521182cb304"` [INFO] [stderr] Checking rusty-tic-tac-toe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | GameState { state: state } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/game.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | GameState { state: state } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/game.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `O` [INFO] [stderr] --> src/game.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | O, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Winner` [INFO] [stderr] --> src/game.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | Winner, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Loser` [INFO] [stderr] --> src/game.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | Loser, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Draw` [INFO] [stderr] --> src/game.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | Draw, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Indeterminate` [INFO] [stderr] --> src/game.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | Indeterminate, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `check_winner` [INFO] [stderr] --> src/game.rs:74:3 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn check_winner(&self) -> PlayerStatus { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/game.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | print!("|{}|", self.state.get(get_index(r, c)).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.state[get_index(r, c)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | winner = winner && true; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | loser = loser && true; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:110:24 [INFO] [stderr] | [INFO] [stderr] 110 | winner = winner && true; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:114:23 [INFO] [stderr] | [INFO] [stderr] 114 | loser = loser && true; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | winner = winner && true; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | loser = loser && true; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | winner = winner && true; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | loser = loser && true; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: for loop over `self.state.get(get_index(r, c))`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/game.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | for cell in self.state.get(get_index(r, c)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for cell in self.state.get(get_index(r, c))` with `if let Some(cell) = self.state.get(get_index(r, c))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `self.state.get(get_index(r, c))`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/game.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | for cell in self.state.get(get_index(r, c)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for cell in self.state.get(get_index(r, c))` with `if let Some(cell) = self.state.get(get_index(r, c))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `self.state.get(get_index(r, r))`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/game.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | for cell in self.state.get(get_index(r, r)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for cell in self.state.get(get_index(r, r))` with `if let Some(cell) = self.state.get(get_index(r, r))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `self.state.get(get_index(r, 3 - r))`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/game.rs:155:19 [INFO] [stderr] | [INFO] [stderr] 155 | for cell in self.state.get(get_index(r, 3 - r)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for cell in self.state.get(get_index(r, 3 - r))` with `if let Some(cell) = self.state.get(get_index(r, 3 - r))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | / io::stdin().read_line(&mut n) [INFO] [stderr] 10 | | .ok() [INFO] [stderr] 11 | | .expect("failed to read line"); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty-tic-tac-toe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `E` [INFO] [stderr] --> src/game.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | let E = Empty; [INFO] [stderr] | ^ help: consider using `_E` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/game.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | print!("|{}|", self.state.get(get_index(r, c)).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.state[get_index(r, c)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:84:24 [INFO] [stderr] | [INFO] [stderr] 84 | winner = winner && true; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | loser = loser && true; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:110:24 [INFO] [stderr] | [INFO] [stderr] 110 | winner = winner && true; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:114:23 [INFO] [stderr] | [INFO] [stderr] 114 | loser = loser && true; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | winner = winner && true; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | loser = loser && true; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | winner = winner && true; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | loser = loser && true; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: for loop over `self.state.get(get_index(r, c))`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/game.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | for cell in self.state.get(get_index(r, c)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for cell in self.state.get(get_index(r, c))` with `if let Some(cell) = self.state.get(get_index(r, c))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `self.state.get(get_index(r, c))`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/game.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | for cell in self.state.get(get_index(r, c)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for cell in self.state.get(get_index(r, c))` with `if let Some(cell) = self.state.get(get_index(r, c))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `self.state.get(get_index(r, r))`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/game.rs:131:19 [INFO] [stderr] | [INFO] [stderr] 131 | for cell in self.state.get(get_index(r, r)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for cell in self.state.get(get_index(r, r))` with `if let Some(cell) = self.state.get(get_index(r, r))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `self.state.get(get_index(r, 3 - r))`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/game.rs:155:19 [INFO] [stderr] | [INFO] [stderr] 155 | for cell in self.state.get(get_index(r, 3 - r)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for cell in self.state.get(get_index(r, 3 - r))` with `if let Some(cell) = self.state.get(get_index(r, 3 - r))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: variable `E` should have a snake case name such as `e` [INFO] [stderr] --> src/game.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | let E = Empty; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `E` should have a snake case name such as `e` [INFO] [stderr] --> src/game.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | let E = Empty; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `E` should have a snake case name such as `e` [INFO] [stderr] --> src/game.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | let E = Empty; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `E` should have a snake case name such as `e` [INFO] [stderr] --> src/game.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | let E = Empty; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | / io::stdin().read_line(&mut n) [INFO] [stderr] 10 | | .ok() [INFO] [stderr] 11 | | .expect("failed to read line"); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty-tic-tac-toe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "02c0c9deaa182aa35b196f648c1756c3445b697a0a290e40ac5e6521182cb304"` [INFO] running `"docker" "rm" "-f" "02c0c9deaa182aa35b196f648c1756c3445b697a0a290e40ac5e6521182cb304"` [INFO] [stdout] 02c0c9deaa182aa35b196f648c1756c3445b697a0a290e40ac5e6521182cb304