[INFO] updating cached repository eqrion/wordament [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/eqrion/wordament [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/eqrion/wordament" "work/ex/clippy-test-run/sources/stable/gh/eqrion/wordament"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/eqrion/wordament'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/eqrion/wordament" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eqrion/wordament"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eqrion/wordament'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f441062f3fe29c2c0e37337041cd696fed082858 [INFO] sha for GitHub repo eqrion/wordament: f441062f3fe29c2c0e37337041cd696fed082858 [INFO] validating manifest of eqrion/wordament on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eqrion/wordament on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eqrion/wordament [INFO] finished frobbing eqrion/wordament [INFO] frobbed toml for eqrion/wordament written to work/ex/clippy-test-run/sources/stable/gh/eqrion/wordament/Cargo.toml [INFO] started frobbing eqrion/wordament [INFO] finished frobbing eqrion/wordament [INFO] frobbed toml for eqrion/wordament written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eqrion/wordament/Cargo.toml [INFO] crate eqrion/wordament has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eqrion/wordament against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/eqrion/wordament:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6255c92e21efd8967f5d1c282923c5ef202a4820d009844c04cbfe5d7b9f2a14 [INFO] running `"docker" "start" "-a" "6255c92e21efd8967f5d1c282923c5ef202a4820d009844c04cbfe5d7b9f2a14"` [INFO] [stderr] Checking wordament v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/word.rs:9:16 [INFO] [stderr] | [INFO] [stderr] 9 | Word { text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/word.rs:9:16 [INFO] [stderr] | [INFO] [stderr] 9 | Word { text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `contains` [INFO] [stderr] --> src/trie.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn contains(&self, data: &str) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `contains_chars` [INFO] [stderr] --> src/trie.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn contains_chars(&self, mut chars: Chars) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/trie.rs:90:20 [INFO] [stderr] | [INFO] [stderr] 90 | if let None = self.children.get(&token) [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 91 | | { [INFO] [stderr] 92 | | self.children.insert( [INFO] [stderr] 93 | | token, [INFO] [stderr] 94 | | Box::new(TrieNode::new()) [INFO] [stderr] 95 | | ); [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________- help: try this: `if self.children.get(&token).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | if data.starts_with("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:24:49 [INFO] [stderr] | [INFO] [stderr] 24 | Tile::Prefix(data.trim_left_matches("-").to_owned()) [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | else if data.ends_with("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:28:50 [INFO] [stderr] | [INFO] [stderr] 28 | Tile::Suffix(data.trim_right_matches("-").to_owned()) [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | else if data.contains("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | let mut split = data.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/main.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / fn find_words_string( [INFO] [stderr] 47 | | text: &str, [INFO] [stderr] 48 | | suffix: bool, [INFO] [stderr] 49 | | board: &Board, [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/main.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / fn find_words( [INFO] [stderr] 116 | | board: &Board, [INFO] [stderr] 117 | | x: usize, y: usize, [INFO] [stderr] 118 | | first: bool, [INFO] [stderr] ... | [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: method is never used: `contains` [INFO] [stderr] --> src/trie.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn contains(&self, data: &str) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `contains_chars` [INFO] [stderr] --> src/trie.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn contains_chars(&self, mut chars: Chars) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:166:21 [INFO] [stderr] | [INFO] [stderr] 166 | assert!(word.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/trie.rs:90:20 [INFO] [stderr] | [INFO] [stderr] 90 | if let None = self.children.get(&token) [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 91 | | { [INFO] [stderr] 92 | | self.children.insert( [INFO] [stderr] 93 | | token, [INFO] [stderr] 94 | | Box::new(TrieNode::new()) [INFO] [stderr] 95 | | ); [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________- help: try this: `if self.children.get(&token).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `board`. [INFO] [stderr] --> src/main.rs:208:18 [INFO] [stderr] | [INFO] [stderr] 208 | for i in 0..4 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 208 | for in &mut board [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | if data.starts_with("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:24:49 [INFO] [stderr] | [INFO] [stderr] 24 | Tile::Prefix(data.trim_left_matches("-").to_owned()) [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | else if data.ends_with("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:28:50 [INFO] [stderr] | [INFO] [stderr] 28 | Tile::Suffix(data.trim_right_matches("-").to_owned()) [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | else if data.contains("/") [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | let mut split = data.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/main.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / fn find_words_string( [INFO] [stderr] 47 | | text: &str, [INFO] [stderr] 48 | | suffix: bool, [INFO] [stderr] 49 | | board: &Board, [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/main.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / fn find_words( [INFO] [stderr] 116 | | board: &Board, [INFO] [stderr] 117 | | x: usize, y: usize, [INFO] [stderr] 118 | | first: bool, [INFO] [stderr] ... | [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:166:21 [INFO] [stderr] | [INFO] [stderr] 166 | assert!(word.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `board`. [INFO] [stderr] --> src/main.rs:208:18 [INFO] [stderr] | [INFO] [stderr] 208 | for i in 0..4 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 208 | for in &mut board [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.54s [INFO] running `"docker" "inspect" "6255c92e21efd8967f5d1c282923c5ef202a4820d009844c04cbfe5d7b9f2a14"` [INFO] running `"docker" "rm" "-f" "6255c92e21efd8967f5d1c282923c5ef202a4820d009844c04cbfe5d7b9f2a14"` [INFO] [stdout] 6255c92e21efd8967f5d1c282923c5ef202a4820d009844c04cbfe5d7b9f2a14