[INFO] updating cached repository emkay/sksh
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/emkay/sksh
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/emkay/sksh" "work/ex/clippy-test-run/sources/stable/gh/emkay/sksh"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/emkay/sksh'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/emkay/sksh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emkay/sksh"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emkay/sksh'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f39ab9a6341c049289f353948d3b4ce56dbbaa7b
[INFO] sha for GitHub repo emkay/sksh: f39ab9a6341c049289f353948d3b4ce56dbbaa7b
[INFO] validating manifest of emkay/sksh on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of emkay/sksh on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing emkay/sksh
[INFO] finished frobbing emkay/sksh
[INFO] frobbed toml for emkay/sksh written to work/ex/clippy-test-run/sources/stable/gh/emkay/sksh/Cargo.toml
[INFO] started frobbing emkay/sksh
[INFO] finished frobbing emkay/sksh
[INFO] frobbed toml for emkay/sksh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emkay/sksh/Cargo.toml
[INFO] crate emkay/sksh has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting emkay/sksh against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/emkay/sksh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] edcde28fd3184e216e21ad7ddbafd8eb525b32e71d5d1b46d9c6addcedfcc665
[INFO] running `"docker" "start" "-a" "edcde28fd3184e216e21ad7ddbafd8eb525b32e71d5d1b46d9c6addcedfcc665"`
[INFO] [stderr]     Checking suffix v1.0.0
[INFO] [stderr]     Checking sksh v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::error::Error`
[INFO] [stderr]  --> src/main.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::error::Error;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             return Some(1);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(1)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:25:14
[INFO] [stderr]    |
[INFO] [stderr] 25 |         _ => return Some(0)
[INFO] [stderr]    |              ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     return status.code();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `status.code()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:75:5
[INFO] [stderr]    |
[INFO] [stderr] 75 |     return line;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]   --> src/main.rs:86:24
[INFO] [stderr]    |
[INFO] [stderr] 86 |                 return ();
[INFO] [stderr]    |                        ^^ help: remove the `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:15:14
[INFO] [stderr]    |
[INFO] [stderr] 15 |         0 => std::env::home_dir(),
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]   --> src/main.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |             return exit(code);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::error::Error`
[INFO] [stderr]  --> src/main.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::error::Error;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             return Some(1);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(1)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:25:14
[INFO] [stderr]    |
[INFO] [stderr] 25 |         _ => return Some(0)
[INFO] [stderr]    |              ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     return status.code();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `status.code()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:75:5
[INFO] [stderr]    |
[INFO] [stderr] 75 |     return line;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]   --> src/main.rs:86:24
[INFO] [stderr]    |
[INFO] [stderr] 86 |                 return ();
[INFO] [stderr]    |                        ^^ help: remove the `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:15:14
[INFO] [stderr]    |
[INFO] [stderr] 15 |         0 => std::env::home_dir(),
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:30:8
[INFO] [stderr]    |
[INFO] [stderr] 30 |     if c.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `c.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/main.rs:35:40
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let trimmed_args: Vec<&str> = args.into_iter().map(|arg| arg.trim()).collect();
[INFO] [stderr]    |                                        ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: sub-expression diverges
[INFO] [stderr]   --> src/main.rs:48:20
[INFO] [stderr]    |
[INFO] [stderr] 48 |             return exit(code);
[INFO] [stderr]    |                    ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::diverging_sub_expression)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable expression
[INFO] [stderr]   --> src/main.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |             return exit(code);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:30:8
[INFO] [stderr]    |
[INFO] [stderr] 30 |     if c.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `c.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/main.rs:35:40
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let trimmed_args: Vec<&str> = args.into_iter().map(|arg| arg.trim()).collect();
[INFO] [stderr]    |                                        ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: sub-expression diverges
[INFO] [stderr]   --> src/main.rs:48:20
[INFO] [stderr]    |
[INFO] [stderr] 48 |             return exit(code);
[INFO] [stderr]    |                    ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::diverging_sub_expression)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.63s
[INFO] running `"docker" "inspect" "edcde28fd3184e216e21ad7ddbafd8eb525b32e71d5d1b46d9c6addcedfcc665"`
[INFO] running `"docker" "rm" "-f" "edcde28fd3184e216e21ad7ddbafd8eb525b32e71d5d1b46d9c6addcedfcc665"`
[INFO] [stdout] edcde28fd3184e216e21ad7ddbafd8eb525b32e71d5d1b46d9c6addcedfcc665