[INFO] updating cached repository elvismt/rsql
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/elvismt/rsql
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/elvismt/rsql" "work/ex/clippy-test-run/sources/stable/gh/elvismt/rsql"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/elvismt/rsql'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/elvismt/rsql" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elvismt/rsql"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elvismt/rsql'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 56b66da58dc868b8f5cb63f23aa5996cd6437fc3
[INFO] sha for GitHub repo elvismt/rsql: 56b66da58dc868b8f5cb63f23aa5996cd6437fc3
[INFO] validating manifest of elvismt/rsql on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of elvismt/rsql on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing elvismt/rsql
[INFO] finished frobbing elvismt/rsql
[INFO] frobbed toml for elvismt/rsql written to work/ex/clippy-test-run/sources/stable/gh/elvismt/rsql/Cargo.toml
[INFO] started frobbing elvismt/rsql
[INFO] finished frobbing elvismt/rsql
[INFO] frobbed toml for elvismt/rsql written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elvismt/rsql/Cargo.toml
[INFO] crate elvismt/rsql has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting elvismt/rsql against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elvismt/rsql:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] db4cdded8ab02d9aee51f5d3ebcb488debdcbd07ca7e3498a1845042cf4ad3cb
[INFO] running `"docker" "start" "-a" "db4cdded8ab02d9aee51f5d3ebcb488debdcbd07ca7e3498a1845042cf4ad3cb"`
[INFO] [stderr]     Checking rsql v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scanner/token.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Token{ txt: txt, label: label }
[INFO] [stderr]    |                ^^^^^^^^ help: replace it with: `txt`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scanner/token.rs:51:26
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Token{ txt: txt, label: label }
[INFO] [stderr]    |                          ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scanner/token.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Token{ txt: txt, label: label }
[INFO] [stderr]    |                ^^^^^^^^ help: replace it with: `txt`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scanner/token.rs:51:26
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Token{ txt: txt, label: label }
[INFO] [stderr]    |                          ^^^^^^^^^^^^ help: replace it with: `label`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/scanner/mod.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub mod scanner;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/scanner/scanner.rs:24:22
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub const NULL_SRC: &'static str = "";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/scanner/scanner.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 | /             if self.src[i] == quote {
[INFO] [stderr] 184 | |                 if self.src[i-1] != b'\\' {
[INFO] [stderr] 185 | |                     self.tok_end = i + 1;
[INFO] [stderr] 186 | |                     break;
[INFO] [stderr] 187 | |                 }
[INFO] [stderr] 188 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 183 |             if self.src[i] == quote && self.src[i-1] != b'\\' {
[INFO] [stderr] 184 |     self.tok_end = i + 1;
[INFO] [stderr] 185 |     break;
[INFO] [stderr] 186 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/scanner/mod.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub mod scanner;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/scanner/scanner.rs:24:22
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub const NULL_SRC: &'static str = "";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/scanner/scanner.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 | /             if self.src[i] == quote {
[INFO] [stderr] 184 | |                 if self.src[i-1] != b'\\' {
[INFO] [stderr] 185 | |                     self.tok_end = i + 1;
[INFO] [stderr] 186 | |                     break;
[INFO] [stderr] 187 | |                 }
[INFO] [stderr] 188 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 183 |             if self.src[i] == quote && self.src[i-1] != b'\\' {
[INFO] [stderr] 184 |     self.tok_end = i + 1;
[INFO] [stderr] 185 |     break;
[INFO] [stderr] 186 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `scanner::scanner::Scanner<'a>`
[INFO] [stderr]   --> src/scanner/scanner.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     pub fn new() -> Self {
[INFO] [stderr] 47 | |         Self::sourced(NULL_SRC)
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 44 | impl Default for scanner::scanner::Scanner<'a> {
[INFO] [stderr] 45 |     fn default() -> Self {
[INFO] [stderr] 46 |         Self::new()
[INFO] [stderr] 47 |     }
[INFO] [stderr] 48 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/scanner/scanner.rs:90:34
[INFO] [stderr]    |
[INFO] [stderr] 90 |                 self.match_range(|x| chars::is_name_char(x), Label::NAME)
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `chars::is_name_char`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/scanner/scanner.rs:93:34
[INFO] [stderr]    |
[INFO] [stderr] 93 |                 self.match_range(|x| chars::is_decimal(x), Label::NUMBER)
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `chars::is_decimal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `scanner::scanner::Scanner<'a>`
[INFO] [stderr]   --> src/scanner/scanner.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     pub fn new() -> Self {
[INFO] [stderr] 47 | |         Self::sourced(NULL_SRC)
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 44 | impl Default for scanner::scanner::Scanner<'a> {
[INFO] [stderr] 45 |     fn default() -> Self {
[INFO] [stderr] 46 |         Self::new()
[INFO] [stderr] 47 |     }
[INFO] [stderr] 48 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/scanner/scanner.rs:90:34
[INFO] [stderr]    |
[INFO] [stderr] 90 |                 self.match_range(|x| chars::is_name_char(x), Label::NAME)
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `chars::is_name_char`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/scanner/scanner.rs:93:34
[INFO] [stderr]    |
[INFO] [stderr] 93 |                 self.match_range(|x| chars::is_decimal(x), Label::NUMBER)
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `chars::is_decimal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.56s
[INFO] running `"docker" "inspect" "db4cdded8ab02d9aee51f5d3ebcb488debdcbd07ca7e3498a1845042cf4ad3cb"`
[INFO] running `"docker" "rm" "-f" "db4cdded8ab02d9aee51f5d3ebcb488debdcbd07ca7e3498a1845042cf4ad3cb"`
[INFO] [stdout] db4cdded8ab02d9aee51f5d3ebcb488debdcbd07ca7e3498a1845042cf4ad3cb