[INFO] updating cached repository elfrostie/rust-bf
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/elfrostie/rust-bf
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/elfrostie/rust-bf" "work/ex/clippy-test-run/sources/stable/gh/elfrostie/rust-bf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/elfrostie/rust-bf'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/elfrostie/rust-bf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elfrostie/rust-bf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elfrostie/rust-bf'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 133314e2ef3dc1a8597bd81a5cd369fd91435fb9
[INFO] sha for GitHub repo elfrostie/rust-bf: 133314e2ef3dc1a8597bd81a5cd369fd91435fb9
[INFO] validating manifest of elfrostie/rust-bf on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of elfrostie/rust-bf on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing elfrostie/rust-bf
[INFO] finished frobbing elfrostie/rust-bf
[INFO] frobbed toml for elfrostie/rust-bf written to work/ex/clippy-test-run/sources/stable/gh/elfrostie/rust-bf/Cargo.toml
[INFO] started frobbing elfrostie/rust-bf
[INFO] finished frobbing elfrostie/rust-bf
[INFO] frobbed toml for elfrostie/rust-bf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elfrostie/rust-bf/Cargo.toml
[INFO] crate elfrostie/rust-bf has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting elfrostie/rust-bf against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/elfrostie/rust-bf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 77f4ba8c740c59f0100e1b92530ec21b191a8a1d4c16b5b9bf3dda9daa1f12b3
[INFO] running `"docker" "start" "-a" "77f4ba8c740c59f0100e1b92530ec21b191a8a1d4c16b5b9bf3dda9daa1f12b3"`
[INFO] [stderr]     Checking bf_aot v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:19:33
[INFO] [stderr]    |
[INFO] [stderr] 19 | fn calculate_jumptable(program: &Vec<Token>) -> Vec<usize> {
[INFO] [stderr]    |                                 ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let ref instruction: Token = program[pc];
[INFO] [stderr]    |         ----^^^^^^^^^^^^^^^---------------------- help: try: `let instruction: &Token = &program[pc];`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:50:26
[INFO] [stderr]    |
[INFO] [stderr] 50 | fn simpleinterp(program: &Vec<Token>) {
[INFO] [stderr]    |                          ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |         let ref instruction: Token = program[pc];
[INFO] [stderr]    |         ----^^^^^^^^^^^^^^^---------------------- help: try: `let instruction: &Token = &program[pc];`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:57:9
[INFO] [stderr]    |
[INFO] [stderr] 57 | /         match instruction {
[INFO] [stderr] 58 | |             &Token::IncDP  => dataptr = dataptr.wrapping_add(1),
[INFO] [stderr] 59 | |             &Token::DecDP  => dataptr = dataptr.wrapping_sub(1),
[INFO] [stderr] 60 | |             &Token::IncMemory => memory[dataptr] = memory[dataptr].wrapping_add(1),
[INFO] [stderr] ...  |
[INFO] [stderr] 73 | |             }
[INFO] [stderr] 74 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 57 |         match *instruction {
[INFO] [stderr] 58 |             Token::IncDP  => dataptr = dataptr.wrapping_add(1),
[INFO] [stderr] 59 |             Token::DecDP  => dataptr = dataptr.wrapping_sub(1),
[INFO] [stderr] 60 |             Token::IncMemory => memory[dataptr] = memory[dataptr].wrapping_add(1),
[INFO] [stderr] 61 |             Token::DecMemory => memory[dataptr] = memory[dataptr].wrapping_sub(1),
[INFO] [stderr] 62 |             Token::Read => panic!(", not implemented"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         match token {
[INFO] [stderr] 102 | |             Some(token) => parsed_program.push(token),
[INFO] [stderr] 103 | |             None => ()
[INFO] [stderr] 104 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(token) = token { parsed_program.push(token) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:19:33
[INFO] [stderr]    |
[INFO] [stderr] 19 | fn calculate_jumptable(program: &Vec<Token>) -> Vec<usize> {
[INFO] [stderr]    |                                 ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let ref instruction: Token = program[pc];
[INFO] [stderr]    |         ----^^^^^^^^^^^^^^^---------------------- help: try: `let instruction: &Token = &program[pc];`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:50:26
[INFO] [stderr]    |
[INFO] [stderr] 50 | fn simpleinterp(program: &Vec<Token>) {
[INFO] [stderr]    |                          ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |         let ref instruction: Token = program[pc];
[INFO] [stderr]    |         ----^^^^^^^^^^^^^^^---------------------- help: try: `let instruction: &Token = &program[pc];`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:57:9
[INFO] [stderr]    |
[INFO] [stderr] 57 | /         match instruction {
[INFO] [stderr] 58 | |             &Token::IncDP  => dataptr = dataptr.wrapping_add(1),
[INFO] [stderr] 59 | |             &Token::DecDP  => dataptr = dataptr.wrapping_sub(1),
[INFO] [stderr] 60 | |             &Token::IncMemory => memory[dataptr] = memory[dataptr].wrapping_add(1),
[INFO] [stderr] ...  |
[INFO] [stderr] 73 | |             }
[INFO] [stderr] 74 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 57 |         match *instruction {
[INFO] [stderr] 58 |             Token::IncDP  => dataptr = dataptr.wrapping_add(1),
[INFO] [stderr] 59 |             Token::DecDP  => dataptr = dataptr.wrapping_sub(1),
[INFO] [stderr] 60 |             Token::IncMemory => memory[dataptr] = memory[dataptr].wrapping_add(1),
[INFO] [stderr] 61 |             Token::DecMemory => memory[dataptr] = memory[dataptr].wrapping_sub(1),
[INFO] [stderr] 62 |             Token::Read => panic!(", not implemented"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         match token {
[INFO] [stderr] 102 | |             Some(token) => parsed_program.push(token),
[INFO] [stderr] 103 | |             None => ()
[INFO] [stderr] 104 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(token) = token { parsed_program.push(token) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.68s
[INFO] running `"docker" "inspect" "77f4ba8c740c59f0100e1b92530ec21b191a8a1d4c16b5b9bf3dda9daa1f12b3"`
[INFO] running `"docker" "rm" "-f" "77f4ba8c740c59f0100e1b92530ec21b191a8a1d4c16b5b9bf3dda9daa1f12b3"`
[INFO] [stdout] 77f4ba8c740c59f0100e1b92530ec21b191a8a1d4c16b5b9bf3dda9daa1f12b3