[INFO] updating cached repository ekiwi/edsacjr-sim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ekiwi/edsacjr-sim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ekiwi/edsacjr-sim" "work/ex/clippy-test-run/sources/stable/gh/ekiwi/edsacjr-sim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ekiwi/edsacjr-sim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ekiwi/edsacjr-sim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ekiwi/edsacjr-sim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ekiwi/edsacjr-sim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a8c929b748dd6a8ca8f8eb1ff4847aadb7136528 [INFO] sha for GitHub repo ekiwi/edsacjr-sim: a8c929b748dd6a8ca8f8eb1ff4847aadb7136528 [INFO] validating manifest of ekiwi/edsacjr-sim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ekiwi/edsacjr-sim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ekiwi/edsacjr-sim [INFO] finished frobbing ekiwi/edsacjr-sim [INFO] frobbed toml for ekiwi/edsacjr-sim written to work/ex/clippy-test-run/sources/stable/gh/ekiwi/edsacjr-sim/Cargo.toml [INFO] started frobbing ekiwi/edsacjr-sim [INFO] finished frobbing ekiwi/edsacjr-sim [INFO] frobbed toml for ekiwi/edsacjr-sim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ekiwi/edsacjr-sim/Cargo.toml [INFO] crate ekiwi/edsacjr-sim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ekiwi/edsacjr-sim against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ekiwi/edsacjr-sim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08a4a8a53940e93bde0b7c76b9ca35ea4d2b35a7cd698d4ed8c31372bbe4d55b [INFO] running `"docker" "start" "-a" "08a4a8a53940e93bde0b7c76b9ca35ea4d2b35a7cd698d4ed8c31372bbe4d55b"` [INFO] [stderr] Checking edsacjr-sim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | Regs {acc: Integer::new(0), pc: pc} [INFO] [stderr] | ^^^^^^ help: replace it with: `pc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | Regs {acc: Integer::new(0), pc: pc} [INFO] [stderr] | ^^^^^^ help: replace it with: `pc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:3 [INFO] [stderr] | [INFO] [stderr] 129 | return self.w & mask(11) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.w & mask(11)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | return self.w >> 11 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.w >> 11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:184:18 [INFO] [stderr] | [INFO] [stderr] 184 | Integer { w: neg - pos | (1 << 15) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(neg - pos) | (1 << 15)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:129:3 [INFO] [stderr] | [INFO] [stderr] 129 | return self.w & mask(11) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.w & mask(11)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | return self.w >> 11 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.w >> 11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:184:18 [INFO] [stderr] | [INFO] [stderr] 184 | Integer { w: neg - pos | (1 << 15) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(neg - pos) | (1 << 15)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_MEM` [INFO] [stderr] --> src/main.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | const MAX_MEM: usize = 2048; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sub` [INFO] [stderr] --> src/main.rs:249:1 [INFO] [stderr] | [INFO] [stderr] 249 | fn sub(n: u16) -> u16 { SUB.new(n).w } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `or` [INFO] [stderr] --> src/main.rs:252:1 [INFO] [stderr] | [INFO] [stderr] 252 | fn or(n: u16) -> u16 { OR.new(n).w } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and` [INFO] [stderr] --> src/main.rs:253:1 [INFO] [stderr] | [INFO] [stderr] 253 | fn and(n: u16) -> u16 { AND.new(n).w } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | fn new(&self, n: u16) -> Instruction { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/main.rs:104:2 [INFO] [stderr] | [INFO] [stderr] 104 | fn new(&self, n: u16) -> Instruction { [INFO] [stderr] | _____^ [INFO] [stderr] 105 | | Instruction::new(self.opcode, n) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | fn is_positive(&self) -> bool { self.w & (1 << 15) == 0} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | fn abs(&self) -> u16 { self.w & mask(15) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:159:10 [INFO] [stderr] | [INFO] [stderr] 159 | fn sign(&self) -> u16 { self.w & (1<<15) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | fn less_than_zero(&self) -> bool { !self.is_positive() && self.abs() != 0 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | let result = self.abs() as u32 + other.abs() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.abs())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:173:37 [INFO] [stderr] | [INFO] [stderr] 173 | let result = self.abs() as u32 + other.abs() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(other.abs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:174:16 [INFO] [stderr] | [INFO] [stderr] 174 | if result > mask(15) as u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(mask(15))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/main.rs:177:31 [INFO] [stderr] | [INFO] [stderr] 177 | Integer { w: result as u16 | self.sign() } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/main.rs:182:22 [INFO] [stderr] | [INFO] [stderr] 182 | Integer { w: pos - neg } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:244:3 [INFO] [stderr] | [INFO] [stderr] 244 | ii = ii + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ii += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `edsacjr-sim`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: constant item is never used: `MAX_MEM` [INFO] [stderr] --> src/main.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | const MAX_MEM: usize = 2048; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sub` [INFO] [stderr] --> src/main.rs:249:1 [INFO] [stderr] | [INFO] [stderr] 249 | fn sub(n: u16) -> u16 { SUB.new(n).w } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `or` [INFO] [stderr] --> src/main.rs:252:1 [INFO] [stderr] | [INFO] [stderr] 252 | fn or(n: u16) -> u16 { OR.new(n).w } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and` [INFO] [stderr] --> src/main.rs:253:1 [INFO] [stderr] | [INFO] [stderr] 253 | fn and(n: u16) -> u16 { AND.new(n).w } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | fn new(&self, n: u16) -> Instruction { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/main.rs:104:2 [INFO] [stderr] | [INFO] [stderr] 104 | fn new(&self, n: u16) -> Instruction { [INFO] [stderr] | _____^ [INFO] [stderr] 105 | | Instruction::new(self.opcode, n) [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | fn is_positive(&self) -> bool { self.w & (1 << 15) == 0} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | fn abs(&self) -> u16 { self.w & mask(15) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:159:10 [INFO] [stderr] | [INFO] [stderr] 159 | fn sign(&self) -> u16 { self.w & (1<<15) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | fn less_than_zero(&self) -> bool { !self.is_positive() && self.abs() != 0 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | let result = self.abs() as u32 + other.abs() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.abs())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:173:37 [INFO] [stderr] | [INFO] [stderr] 173 | let result = self.abs() as u32 + other.abs() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(other.abs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:174:16 [INFO] [stderr] | [INFO] [stderr] 174 | if result > mask(15) as u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(mask(15))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/main.rs:177:31 [INFO] [stderr] | [INFO] [stderr] 177 | Integer { w: result as u16 | self.sign() } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/main.rs:182:22 [INFO] [stderr] | [INFO] [stderr] 182 | Integer { w: pos - neg } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:244:3 [INFO] [stderr] | [INFO] [stderr] 244 | ii = ii + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ii += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `edsacjr-sim`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "08a4a8a53940e93bde0b7c76b9ca35ea4d2b35a7cd698d4ed8c31372bbe4d55b"` [INFO] running `"docker" "rm" "-f" "08a4a8a53940e93bde0b7c76b9ca35ea4d2b35a7cd698d4ed8c31372bbe4d55b"` [INFO] [stdout] 08a4a8a53940e93bde0b7c76b9ca35ea4d2b35a7cd698d4ed8c31372bbe4d55b