[INFO] updating cached repository ekaterinaYashkina/HammingCode1 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ekaterinaYashkina/HammingCode1 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ekaterinaYashkina/HammingCode1" "work/ex/clippy-test-run/sources/stable/gh/ekaterinaYashkina/HammingCode1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ekaterinaYashkina/HammingCode1'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ekaterinaYashkina/HammingCode1" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ekaterinaYashkina/HammingCode1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ekaterinaYashkina/HammingCode1'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1b5a689497b81a101d93d0ebb4e3788509454dc4 [INFO] sha for GitHub repo ekaterinaYashkina/HammingCode1: 1b5a689497b81a101d93d0ebb4e3788509454dc4 [INFO] validating manifest of ekaterinaYashkina/HammingCode1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ekaterinaYashkina/HammingCode1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ekaterinaYashkina/HammingCode1 [INFO] finished frobbing ekaterinaYashkina/HammingCode1 [INFO] frobbed toml for ekaterinaYashkina/HammingCode1 written to work/ex/clippy-test-run/sources/stable/gh/ekaterinaYashkina/HammingCode1/Cargo.toml [INFO] started frobbing ekaterinaYashkina/HammingCode1 [INFO] finished frobbing ekaterinaYashkina/HammingCode1 [INFO] frobbed toml for ekaterinaYashkina/HammingCode1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ekaterinaYashkina/HammingCode1/Cargo.toml [INFO] crate ekaterinaYashkina/HammingCode1 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ekaterinaYashkina/HammingCode1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ekaterinaYashkina/HammingCode1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 529d51c62771a891fca42a1760050174812e4bfb845b07aa984f64d023d8cc4d [INFO] running `"docker" "start" "-a" "529d51c62771a891fca42a1760050174812e4bfb845b07aa984f64d023d8cc4d"` [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking HammingCode v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `self::num::abs` [INFO] [stderr] --> src/encoder.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use self::num::abs; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/encoder.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | if (pos >= ((with_parity.len()) as u32)){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/encoder.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if (with_parity.get(pos as usize).unwrap() == true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/encoder.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | if (c src/encoder.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | if (counter%2 == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::num::abs` [INFO] [stderr] --> src/decoder.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use self::num::abs; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/decoder.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | decoded [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/decoder.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | let decoded= String::from_utf8_lossy(&vec).into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | if (end>word.len()){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:82:12 [INFO] [stderr] | [INFO] [stderr] 82 | if (pp==2u32.pow(a)){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decoder.rs:135:14 [INFO] [stderr] | [INFO] [stderr] 135 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 136 | | if (decoded.get(6 ).unwrap()==true){ [INFO] [stderr] 137 | | decoded.set(6 , false); [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | else { decoded.set(6, true); } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 135 | else if (decoded.get(6 ).unwrap()==true){ [INFO] [stderr] 136 | decoded.set(6 , false); [INFO] [stderr] 137 | } [INFO] [stderr] 138 | else { decoded.set(6, true); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:115:23 [INFO] [stderr] | [INFO] [stderr] 115 | if (ind1==4){ [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:130:16 [INFO] [stderr] | [INFO] [stderr] 130 | if (decoded.get(bit_to_flip ).unwrap()==true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | if (decoded.get(6 ).unwrap()==true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/decoder.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | encoded [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/decoder.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | let mut encoded = flipped_bit(indexes, parity, code); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/decoder.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | / if av_indexes.contains(&(y as u32)) { [INFO] [stderr] 164 | | if code.get(y).unwrap() == true{ [INFO] [stderr] 165 | | counter+=1; [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 163 | if av_indexes.contains(&(y as u32)) && code.get(y).unwrap() == true { [INFO] [stderr] 164 | counter+=1; [INFO] [stderr] 165 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:173:12 [INFO] [stderr] | [INFO] [stderr] 173 | if (code.get((2u32.pow(x)-1) as usize).unwrap()!=kk){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::bit_vec::BitVec` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use self::bit_vec::BitVec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::num::abs` [INFO] [stderr] --> src/encoder.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use self::num::abs; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/encoder.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | if (pos >= ((with_parity.len()) as u32)){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/encoder.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if (with_parity.get(pos as usize).unwrap() == true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/encoder.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | if (c src/encoder.rs:61:12 [INFO] [stderr] | [INFO] [stderr] 61 | if (counter%2 == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::num::abs` [INFO] [stderr] --> src/decoder.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use self::num::abs; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/decoder.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | decoded [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/decoder.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | let decoded= String::from_utf8_lossy(&vec).into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | if (end>word.len()){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:82:12 [INFO] [stderr] | [INFO] [stderr] 82 | if (pp==2u32.pow(a)){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decoder.rs:135:14 [INFO] [stderr] | [INFO] [stderr] 135 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 136 | | if (decoded.get(6 ).unwrap()==true){ [INFO] [stderr] 137 | | decoded.set(6 , false); [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | else { decoded.set(6, true); } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 135 | else if (decoded.get(6 ).unwrap()==true){ [INFO] [stderr] 136 | decoded.set(6 , false); [INFO] [stderr] 137 | } [INFO] [stderr] 138 | else { decoded.set(6, true); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:115:23 [INFO] [stderr] | [INFO] [stderr] 115 | if (ind1==4){ [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:130:16 [INFO] [stderr] | [INFO] [stderr] 130 | if (decoded.get(bit_to_flip ).unwrap()==true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | if (decoded.get(6 ).unwrap()==true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/decoder.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | encoded [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/decoder.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | let mut encoded = flipped_bit(indexes, parity, code); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/decoder.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | / if av_indexes.contains(&(y as u32)) { [INFO] [stderr] 164 | | if code.get(y).unwrap() == true{ [INFO] [stderr] 165 | | counter+=1; [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 163 | if av_indexes.contains(&(y as u32)) && code.get(y).unwrap() == true { [INFO] [stderr] 164 | counter+=1; [INFO] [stderr] 165 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/decoder.rs:173:12 [INFO] [stderr] | [INFO] [stderr] 173 | if (code.get((2u32.pow(x)-1) as usize).unwrap()!=kk){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::bit_vec::BitVec` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use self::bit_vec::BitVec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/encoder.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn set_parity(bVec:BitVec, a:u32, b:u32, c:u32) -> BitVec{ [INFO] [stderr] | ^ help: consider using `_a` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/encoder.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn set_parity(bVec:BitVec, a:u32, b:u32, c:u32) -> BitVec{ [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `trunc` is never read [INFO] [stderr] --> src/decoder.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let mut trunc = BitVec::new(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `clear_vec` [INFO] [stderr] --> src/decoder.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | let mut clear_vec = BitVec::new(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_clear_vec` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/encoder.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | let mut bv = BitVec::from_bytes(&(word.into_bytes())); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decoder.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let mut clear_vec = BitVec::new(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decoder.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | let mut encoded = flipped_bit(indexes, parity, code); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: crate `HammingCode` should have a snake case name such as `hamming_code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `bVec` should have a snake case name such as `b_vec` [INFO] [stderr] --> src/encoder.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn copy_bits(bVec:&BitVec, a:usize, b:usize) -> BitVec{ [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `bVec` should have a snake case name such as `b_vec` [INFO] [stderr] --> src/encoder.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn set_parity(bVec:BitVec, a:u32, b:u32, c:u32) -> BitVec{ [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/encoder.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if (with_parity.get(pos as usize).unwrap() == true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `with_parity.get(pos as usize).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:75:22 [INFO] [stderr] | [INFO] [stderr] 75 | output+=&(vec[x] as u32).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(vec[x])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:79:22 [INFO] [stderr] | [INFO] [stderr] 79 | output+=&(vec[x] as u32).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(vec[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `bVec` should have a snake case name such as `b_vec` [INFO] [stderr] --> src/decoder.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn copy_bits(bVec:&BitVec, a:usize, b:usize) -> BitVec{ [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `line`. [INFO] [stderr] --> src/decoder.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | for x in 0..line.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for in &line{ [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/decoder.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / let mut trunc = BitVec::new(); [INFO] [stderr] 62 | | if code.get(0).unwrap() == false { [INFO] [stderr] 63 | | trunc = copy_bits(&code, 1, code.len()-7); [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | else { [INFO] [stderr] 66 | | trunc = copy_bits(&code, 1, code.len()-1 -(7-(code.len()-1)%4)); [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let trunc = if code.get(0).unwrap() == false { copy_bits(&code, 1, code.len()-7) } else { copy_bits(&code, 1, code.len()-1 -(7-(code.len()-1)%4)) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/decoder.rs:62:8 [INFO] [stderr] | [INFO] [stderr] 62 | if code.get(0).unwrap() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!code.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/decoder.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if a.get(x as usize).unwrap() == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!a.get(x as usize).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/decoder.rs:114:19 [INFO] [stderr] | [INFO] [stderr] 114 | if (parity).get(x).unwrap()==false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(parity).get(x).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/decoder.rs:130:16 [INFO] [stderr] | [INFO] [stderr] 130 | if (decoded.get(bit_to_flip ).unwrap()==true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `decoded.get(bit_to_flip ).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/decoder.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | if (decoded.get(6 ).unwrap()==true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `decoded.get(6 ).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/decoder.rs:146:12 [INFO] [stderr] | [INFO] [stderr] 146 | if ((x+1) as f64).log2().round()!=((x+1) as f64).log2(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(((x+1) as f64).log2().round() - ((x+1) as f64).log2()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/decoder.rs:146:12 [INFO] [stderr] | [INFO] [stderr] 146 | if ((x+1) as f64).log2().round()!=((x+1) as f64).log2(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/decoder.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | if code.get(y).unwrap() == true{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `code.get(y).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `HammingCode`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/encoder.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn set_parity(bVec:BitVec, a:u32, b:u32, c:u32) -> BitVec{ [INFO] [stderr] | ^ help: consider using `_a` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/encoder.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn set_parity(bVec:BitVec, a:u32, b:u32, c:u32) -> BitVec{ [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `trunc` is never read [INFO] [stderr] --> src/decoder.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let mut trunc = BitVec::new(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `clear_vec` [INFO] [stderr] --> src/decoder.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | let mut clear_vec = BitVec::new(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_clear_vec` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/encoder.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | let mut bv = BitVec::from_bytes(&(word.into_bytes())); [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decoder.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let mut clear_vec = BitVec::new(); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decoder.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | let mut encoded = flipped_bit(indexes, parity, code); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: crate `HammingCode` should have a snake case name such as `hamming_code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `bVec` should have a snake case name such as `b_vec` [INFO] [stderr] --> src/encoder.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn copy_bits(bVec:&BitVec, a:usize, b:usize) -> BitVec{ [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `bVec` should have a snake case name such as `b_vec` [INFO] [stderr] --> src/encoder.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn set_parity(bVec:BitVec, a:u32, b:u32, c:u32) -> BitVec{ [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/encoder.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if (with_parity.get(pos as usize).unwrap() == true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `with_parity.get(pos as usize).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:75:22 [INFO] [stderr] | [INFO] [stderr] 75 | output+=&(vec[x] as u32).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(vec[x])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:79:22 [INFO] [stderr] | [INFO] [stderr] 79 | output+=&(vec[x] as u32).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(vec[x])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `bVec` should have a snake case name such as `b_vec` [INFO] [stderr] --> src/decoder.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn copy_bits(bVec:&BitVec, a:usize, b:usize) -> BitVec{ [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `line`. [INFO] [stderr] --> src/decoder.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | for x in 0..line.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for in &line{ [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/decoder.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / let mut trunc = BitVec::new(); [INFO] [stderr] 62 | | if code.get(0).unwrap() == false { [INFO] [stderr] 63 | | trunc = copy_bits(&code, 1, code.len()-7); [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | else { [INFO] [stderr] 66 | | trunc = copy_bits(&code, 1, code.len()-1 -(7-(code.len()-1)%4)); [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let trunc = if code.get(0).unwrap() == false { copy_bits(&code, 1, code.len()-7) } else { copy_bits(&code, 1, code.len()-1 -(7-(code.len()-1)%4)) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/decoder.rs:62:8 [INFO] [stderr] | [INFO] [stderr] 62 | if code.get(0).unwrap() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!code.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/decoder.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if a.get(x as usize).unwrap() == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!a.get(x as usize).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/decoder.rs:114:19 [INFO] [stderr] | [INFO] [stderr] 114 | if (parity).get(x).unwrap()==false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(parity).get(x).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/decoder.rs:130:16 [INFO] [stderr] | [INFO] [stderr] 130 | if (decoded.get(bit_to_flip ).unwrap()==true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `decoded.get(bit_to_flip ).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/decoder.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | if (decoded.get(6 ).unwrap()==true){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `decoded.get(6 ).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/decoder.rs:146:12 [INFO] [stderr] | [INFO] [stderr] 146 | if ((x+1) as f64).log2().round()!=((x+1) as f64).log2(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(((x+1) as f64).log2().round() - ((x+1) as f64).log2()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/decoder.rs:146:12 [INFO] [stderr] | [INFO] [stderr] 146 | if ((x+1) as f64).log2().round()!=((x+1) as f64).log2(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/decoder.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | if code.get(y).unwrap() == true{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `code.get(y).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `HammingCode`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "529d51c62771a891fca42a1760050174812e4bfb845b07aa984f64d023d8cc4d"` [INFO] running `"docker" "rm" "-f" "529d51c62771a891fca42a1760050174812e4bfb845b07aa984f64d023d8cc4d"` [INFO] [stdout] 529d51c62771a891fca42a1760050174812e4bfb845b07aa984f64d023d8cc4d