[INFO] updating cached repository edbrook/rust-tee [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/edbrook/rust-tee [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/edbrook/rust-tee" "work/ex/clippy-test-run/sources/stable/gh/edbrook/rust-tee"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/edbrook/rust-tee'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/edbrook/rust-tee" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edbrook/rust-tee"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edbrook/rust-tee'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1b1c038fdb959a480ae269d1f3f49adb9d53d36c [INFO] sha for GitHub repo edbrook/rust-tee: 1b1c038fdb959a480ae269d1f3f49adb9d53d36c [INFO] validating manifest of edbrook/rust-tee on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of edbrook/rust-tee on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing edbrook/rust-tee [INFO] finished frobbing edbrook/rust-tee [INFO] frobbed toml for edbrook/rust-tee written to work/ex/clippy-test-run/sources/stable/gh/edbrook/rust-tee/Cargo.toml [INFO] started frobbing edbrook/rust-tee [INFO] finished frobbing edbrook/rust-tee [INFO] frobbed toml for edbrook/rust-tee written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edbrook/rust-tee/Cargo.toml [INFO] crate edbrook/rust-tee has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting edbrook/rust-tee against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/edbrook/rust-tee:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 25a2d82d31125d40ae59752a36368095f1b71f61dffdcb17ed66011d3c8e47d7 [INFO] running `"docker" "start" "-a" "25a2d82d31125d40ae59752a36368095f1b71f61dffdcb17ed66011d3c8e47d7"` [INFO] [stderr] Checking tee v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:40:43 [INFO] [stderr] | [INFO] [stderr] 40 | fn tee(input: &mut T, files: &Vec) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[File]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | fn parse_args(args: &Vec) -> Config { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:73:35 [INFO] [stderr] | [INFO] [stderr] 73 | } else if arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:84:27 [INFO] [stderr] | [INFO] [stderr] 84 | fn open_files(file_names: &Vec, append: bool) -> io::Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:40:43 [INFO] [stderr] | [INFO] [stderr] 40 | fn tee(input: &mut T, files: &Vec) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[File]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | fn parse_args(args: &Vec) -> Config { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:73:35 [INFO] [stderr] | [INFO] [stderr] 73 | } else if arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:84:27 [INFO] [stderr] | [INFO] [stderr] 84 | fn open_files(file_names: &Vec, append: bool) -> io::Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.70s [INFO] running `"docker" "inspect" "25a2d82d31125d40ae59752a36368095f1b71f61dffdcb17ed66011d3c8e47d7"` [INFO] running `"docker" "rm" "-f" "25a2d82d31125d40ae59752a36368095f1b71f61dffdcb17ed66011d3c8e47d7"` [INFO] [stdout] 25a2d82d31125d40ae59752a36368095f1b71f61dffdcb17ed66011d3c8e47d7