[INFO] updating cached repository dwrensha/zillions [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dwrensha/zillions [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dwrensha/zillions" "work/ex/clippy-test-run/sources/stable/gh/dwrensha/zillions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dwrensha/zillions'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dwrensha/zillions" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dwrensha/zillions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dwrensha/zillions'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6bfeda5fc6f5f12d91be3638ab92867198f0fa84 [INFO] sha for GitHub repo dwrensha/zillions: 6bfeda5fc6f5f12d91be3638ab92867198f0fa84 [INFO] validating manifest of dwrensha/zillions on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dwrensha/zillions on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dwrensha/zillions [INFO] finished frobbing dwrensha/zillions [INFO] frobbed toml for dwrensha/zillions written to work/ex/clippy-test-run/sources/stable/gh/dwrensha/zillions/Cargo.toml [INFO] started frobbing dwrensha/zillions [INFO] finished frobbing dwrensha/zillions [INFO] frobbed toml for dwrensha/zillions written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dwrensha/zillions/Cargo.toml [INFO] crate dwrensha/zillions has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dwrensha/zillions against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dwrensha/zillions:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] edd57f4916757512c2abdd6e72a1ca8b02e36217f490695803ff790442b5a5f6 [INFO] running `"docker" "start" "-a" "edd57f4916757512c2abdd6e72a1ca8b02e36217f490695803ff790442b5a5f6"` [INFO] [stderr] Checking futures v0.1.11 [INFO] [stderr] Checking bytes v0.4.1 [INFO] [stderr] Checking mio v0.6.6 [INFO] [stderr] Checking tokio-io v0.1.0 [INFO] [stderr] Checking futures-cpupool v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.6 [INFO] [stderr] Checking zillions v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:293:25 [INFO] [stderr] | [INFO] [stderr] 293 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:294:25 [INFO] [stderr] | [INFO] [stderr] 294 | complete: complete, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `complete` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:368:25 [INFO] [stderr] | [INFO] [stderr] 368 | complete: complete, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `complete` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:402:24 [INFO] [stderr] | [INFO] [stderr] 402 | ChildProcess { child: child } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `child` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/stresstest.rs:584:9 [INFO] [stderr] | [INFO] [stderr] 584 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:293:25 [INFO] [stderr] | [INFO] [stderr] 293 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:294:25 [INFO] [stderr] | [INFO] [stderr] 294 | complete: complete, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `complete` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:368:25 [INFO] [stderr] | [INFO] [stderr] 368 | complete: complete, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `complete` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stresstest.rs:402:24 [INFO] [stderr] | [INFO] [stderr] 402 | ChildProcess { child: child } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `child` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/stresstest.rs:584:9 [INFO] [stderr] | [INFO] [stderr] 584 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/commandline-client.rs:6:35 [INFO] [stderr] | [INFO] [stderr] 6 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/commandline-client.rs:6:35 [INFO] [stderr] | [INFO] [stderr] 6 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/stresstest.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / macro_rules! fry { [INFO] [stderr] 23 | | ($expr:expr) => ( [INFO] [stderr] 24 | | match $expr { [INFO] [stderr] 25 | | ::std::result::Result::Ok(val) => val, [INFO] [stderr] ... | [INFO] [stderr] 29 | | }) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/stresstest.rs:518:64 [INFO] [stderr] | [INFO] [stderr] 518 | }).map_err(|e| { println!("error from clock task: {}", e); () })); [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/stresstest.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / macro_rules! fry { [INFO] [stderr] 23 | | ($expr:expr) => ( [INFO] [stderr] 24 | | match $expr { [INFO] [stderr] 25 | | ::std::result::Result::Ok(val) => val, [INFO] [stderr] ... | [INFO] [stderr] 29 | | }) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/stresstest.rs:518:64 [INFO] [stderr] | [INFO] [stderr] 518 | }).map_err(|e| { println!("error from clock task: {}", e); () })); [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/stresstest.rs:257:8 [INFO] [stderr] | [INFO] [stderr] 257 | -> Result<(Box + Send>, [INFO] [stderr] | ________^ [INFO] [stderr] 258 | | Box>, [INFO] [stderr] 259 | | Error=::std::io::Error>>), [INFO] [stderr] 260 | | ::std::io::Error> [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `read_values`. [INFO] [stderr] --> src/stresstest.rs:323:20 [INFO] [stderr] | [INFO] [stderr] 323 | for idx in 0..read_values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 323 | for in &read_values { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `senders`. [INFO] [stderr] --> src/stresstest.rs:362:28 [INFO] [stderr] | [INFO] [stderr] 362 | for idx in 0..senders.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 362 | for in &senders { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `num_reads`. [INFO] [stderr] --> src/stresstest.rs:539:24 [INFO] [stderr] | [INFO] [stderr] 539 | for idx in 0..num_reads.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 539 | for in &num_reads { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/stresstest.rs:576:41 [INFO] [stderr] | [INFO] [stderr] 576 | elapsed.as_secs() as f64 + (elapsed.subsec_nanos() as f64 / 1e9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/stresstest.rs:257:8 [INFO] [stderr] | [INFO] [stderr] 257 | -> Result<(Box + Send>, [INFO] [stderr] | ________^ [INFO] [stderr] 258 | | Box>, [INFO] [stderr] 259 | | Error=::std::io::Error>>), [INFO] [stderr] 260 | | ::std::io::Error> [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `read_values`. [INFO] [stderr] --> src/stresstest.rs:323:20 [INFO] [stderr] | [INFO] [stderr] 323 | for idx in 0..read_values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 323 | for in &read_values { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `senders`. [INFO] [stderr] --> src/stresstest.rs:362:28 [INFO] [stderr] | [INFO] [stderr] 362 | for idx in 0..senders.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 362 | for in &senders { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `num_reads`. [INFO] [stderr] --> src/stresstest.rs:539:24 [INFO] [stderr] | [INFO] [stderr] 539 | for idx in 0..num_reads.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 539 | for in &num_reads { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/stresstest.rs:576:41 [INFO] [stderr] | [INFO] [stderr] 576 | elapsed.as_secs() as f64 + (elapsed.subsec_nanos() as f64 / 1e9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.79s [INFO] running `"docker" "inspect" "edd57f4916757512c2abdd6e72a1ca8b02e36217f490695803ff790442b5a5f6"` [INFO] running `"docker" "rm" "-f" "edd57f4916757512c2abdd6e72a1ca8b02e36217f490695803ff790442b5a5f6"` [INFO] [stdout] edd57f4916757512c2abdd6e72a1ca8b02e36217f490695803ff790442b5a5f6