[INFO] updating cached repository dwelman/rust_doku [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dwelman/rust_doku [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dwelman/rust_doku" "work/ex/clippy-test-run/sources/stable/gh/dwelman/rust_doku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dwelman/rust_doku'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dwelman/rust_doku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dwelman/rust_doku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dwelman/rust_doku'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 679f04ede33d32d423522e22164836e1a1374f9b [INFO] sha for GitHub repo dwelman/rust_doku: 679f04ede33d32d423522e22164836e1a1374f9b [INFO] validating manifest of dwelman/rust_doku on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dwelman/rust_doku on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dwelman/rust_doku [INFO] finished frobbing dwelman/rust_doku [INFO] frobbed toml for dwelman/rust_doku written to work/ex/clippy-test-run/sources/stable/gh/dwelman/rust_doku/Cargo.toml [INFO] started frobbing dwelman/rust_doku [INFO] finished frobbing dwelman/rust_doku [INFO] frobbed toml for dwelman/rust_doku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dwelman/rust_doku/Cargo.toml [INFO] crate dwelman/rust_doku has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dwelman/rust_doku against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dwelman/rust_doku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a0edbbb0977877149d27580f6189c1b6c15baebf4f02ea057da2621b546df355 [INFO] running `"docker" "start" "-a" "a0edbbb0977877149d27580f6189c1b6c15baebf4f02ea057da2621b546df355"` [INFO] [stderr] Checking rust_doku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `error` [INFO] [stderr] --> src/puzzle_logic.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use error; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzle_logic.rs:67:2 [INFO] [stderr] | [INFO] [stderr] 67 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:51:2 [INFO] [stderr] | [INFO] [stderr] 51 | { [INFO] [stderr] | _____^ [INFO] [stderr] 52 | | if x == 8 [INFO] [stderr] 53 | | { [INFO] [stderr] 54 | | if puzzle_loop(puzzle, y + 1, 0) == true [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | if x == 8 [INFO] [stderr] 52 | { [INFO] [stderr] 53 | if puzzle_loop(puzzle, y + 1, 0) == true [INFO] [stderr] 54 | { [INFO] [stderr] 55 | return true [INFO] [stderr] 56 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | { [INFO] [stderr] | _________________^ [INFO] [stderr] 40 | | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] 41 | | { [INFO] [stderr] 42 | | return true [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] 40 | { [INFO] [stderr] 41 | return true [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | { [INFO] [stderr] | _________^ [INFO] [stderr] 61 | | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] 62 | | { [INFO] [stderr] 63 | | return true [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] 61 | { [INFO] [stderr] 62 | return true [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:105:3 [INFO] [stderr] | [INFO] [stderr] 105 | if y != c [INFO] [stderr] | _________^ [INFO] [stderr] 106 | | { [INFO] [stderr] 107 | | if puzzle[y][x] == puzzle[c][x] [INFO] [stderr] 108 | | { [INFO] [stderr] 109 | | return false [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | if y != c && puzzle[y][x] == puzzle[c][x] { [INFO] [stderr] 106 | return false [INFO] [stderr] 107 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | if x != r [INFO] [stderr] | _________^ [INFO] [stderr] 118 | | { [INFO] [stderr] 119 | | if puzzle[y][x] == puzzle[y][r] [INFO] [stderr] 120 | | { [INFO] [stderr] 121 | | return false [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 117 | if x != r && puzzle[y][x] == puzzle[y][r] { [INFO] [stderr] 118 | return false [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:133:4 [INFO] [stderr] | [INFO] [stderr] 133 | if c_y != y && c_x != x [INFO] [stderr] | _____________^ [INFO] [stderr] 134 | | { [INFO] [stderr] 135 | | if puzzle[y][x] == puzzle[c_y][c_x] [INFO] [stderr] 136 | | { [INFO] [stderr] 137 | | return false [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | if c_y != y && c_x != x && puzzle[y][x] == puzzle[c_y][c_x] { [INFO] [stderr] 134 | return false [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `error` [INFO] [stderr] --> src/puzzle_logic.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use error; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzle_logic.rs:67:2 [INFO] [stderr] | [INFO] [stderr] 67 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:51:2 [INFO] [stderr] | [INFO] [stderr] 51 | { [INFO] [stderr] | _____^ [INFO] [stderr] 52 | | if x == 8 [INFO] [stderr] 53 | | { [INFO] [stderr] 54 | | if puzzle_loop(puzzle, y + 1, 0) == true [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | if x == 8 [INFO] [stderr] 52 | { [INFO] [stderr] 53 | if puzzle_loop(puzzle, y + 1, 0) == true [INFO] [stderr] 54 | { [INFO] [stderr] 55 | return true [INFO] [stderr] 56 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | { [INFO] [stderr] | _________________^ [INFO] [stderr] 40 | | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] 41 | | { [INFO] [stderr] 42 | | return true [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] 40 | { [INFO] [stderr] 41 | return true [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | { [INFO] [stderr] | _________^ [INFO] [stderr] 61 | | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] 62 | | { [INFO] [stderr] 63 | | return true [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] 61 | { [INFO] [stderr] 62 | return true [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:105:3 [INFO] [stderr] | [INFO] [stderr] 105 | if y != c [INFO] [stderr] | _________^ [INFO] [stderr] 106 | | { [INFO] [stderr] 107 | | if puzzle[y][x] == puzzle[c][x] [INFO] [stderr] 108 | | { [INFO] [stderr] 109 | | return false [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | if y != c && puzzle[y][x] == puzzle[c][x] { [INFO] [stderr] 106 | return false [INFO] [stderr] 107 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | if x != r [INFO] [stderr] | _________^ [INFO] [stderr] 118 | | { [INFO] [stderr] 119 | | if puzzle[y][x] == puzzle[y][r] [INFO] [stderr] 120 | | { [INFO] [stderr] 121 | | return false [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 117 | if x != r && puzzle[y][x] == puzzle[y][r] { [INFO] [stderr] 118 | return false [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/puzzle_logic.rs:133:4 [INFO] [stderr] | [INFO] [stderr] 133 | if c_y != y && c_x != x [INFO] [stderr] | _____________^ [INFO] [stderr] 134 | | { [INFO] [stderr] 135 | | if puzzle[y][x] == puzzle[c_y][c_x] [INFO] [stderr] 136 | | { [INFO] [stderr] 137 | | return false [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | if c_y != y && c_x != x && puzzle[y][x] == puzzle[c_y][c_x] { [INFO] [stderr] 134 | return false [INFO] [stderr] 135 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | if validate_puzzle(puzzle) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `validate_puzzle(puzzle)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:29:7 [INFO] [stderr] | [INFO] [stderr] 29 | if validate_specific_val(puzzle, y, x) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `validate_specific_val(puzzle, y, x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | if puzzle_loop(puzzle, y + 1, 0) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `puzzle_loop(puzzle, y + 1, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `puzzle_loop(puzzle, y, x + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | if puzzle_loop(puzzle, y + 1, 0) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `puzzle_loop(puzzle, y + 1, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:61:7 [INFO] [stderr] | [INFO] [stderr] 61 | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `puzzle_loop(puzzle, y, x + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `puzzle` [INFO] [stderr] --> src/puzzle_logic.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | for y in 0..9 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 72 | for (y, ) in puzzle.iter().enumerate().take(9) [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/puzzle_logic.rs:89:7 [INFO] [stderr] | [INFO] [stderr] 89 | if validate_specific_val(puzzle, y, x) == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!validate_specific_val(puzzle, y, x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | if validate_puzzle(puzzle) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `validate_puzzle(puzzle)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:29:7 [INFO] [stderr] | [INFO] [stderr] 29 | if validate_specific_val(puzzle, y, x) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `validate_specific_val(puzzle, y, x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | if puzzle_loop(puzzle, y + 1, 0) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `puzzle_loop(puzzle, y + 1, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `puzzle_loop(puzzle, y, x + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | if puzzle_loop(puzzle, y + 1, 0) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `puzzle_loop(puzzle, y + 1, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzle_logic.rs:61:7 [INFO] [stderr] | [INFO] [stderr] 61 | if puzzle_loop(puzzle, y, x + 1) == true [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `puzzle_loop(puzzle, y, x + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `puzzle` [INFO] [stderr] --> src/puzzle_logic.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | for y in 0..9 [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 72 | for (y, ) in puzzle.iter().enumerate().take(9) [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/puzzle_logic.rs:89:7 [INFO] [stderr] | [INFO] [stderr] 89 | if validate_specific_val(puzzle, y, x) == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!validate_specific_val(puzzle, y, x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "a0edbbb0977877149d27580f6189c1b6c15baebf4f02ea057da2621b546df355"` [INFO] running `"docker" "rm" "-f" "a0edbbb0977877149d27580f6189c1b6c15baebf4f02ea057da2621b546df355"` [INFO] [stdout] a0edbbb0977877149d27580f6189c1b6c15baebf4f02ea057da2621b546df355