[INFO] updating cached repository duythinht/solo.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/duythinht/solo.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/duythinht/solo.rs" "work/ex/clippy-test-run/sources/stable/gh/duythinht/solo.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/duythinht/solo.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/duythinht/solo.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/duythinht/solo.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/duythinht/solo.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 597a6cb30c521faab4fde983b4215a349fa455c5 [INFO] sha for GitHub repo duythinht/solo.rs: 597a6cb30c521faab4fde983b4215a349fa455c5 [INFO] validating manifest of duythinht/solo.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of duythinht/solo.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing duythinht/solo.rs [INFO] finished frobbing duythinht/solo.rs [INFO] frobbed toml for duythinht/solo.rs written to work/ex/clippy-test-run/sources/stable/gh/duythinht/solo.rs/Cargo.toml [INFO] started frobbing duythinht/solo.rs [INFO] finished frobbing duythinht/solo.rs [INFO] frobbed toml for duythinht/solo.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/duythinht/solo.rs/Cargo.toml [INFO] crate duythinht/solo.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting duythinht/solo.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/duythinht/solo.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5f41b712f778e90a55b2066b655ed7799ef77782f970fe23a6329ba97b5d5edb [INFO] running `"docker" "start" "-a" "5f41b712f778e90a55b2066b655ed7799ef77782f970fe23a6329ba97b5d5edb"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking solo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return status == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `status == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return status == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `status == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | if let Ok(_) = f.read_to_string(&mut s) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 39 | | let pid: i32 = match s.trim().parse() { [INFO] [stderr] 40 | | Ok(pid) => pid, [INFO] [stderr] 41 | | Err(err) => { [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_________- help: try this: `if f.read_to_string(&mut s).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | if let Ok(_) = write!(f, "{}", process::id()) {} [INFO] [stderr] | ^^^^^ ------------------------------ help: try this: `if $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:69:28 [INFO] [stderr] | [INFO] [stderr] 69 | if let Some(_) = elm.find(' ') { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 70 | | let mut s = String::from("'"); [INFO] [stderr] 71 | | s.push_str(elm); [INFO] [stderr] 72 | | s.push_str("'"); [INFO] [stderr] ... | [INFO] [stderr] 75 | | elm.to_string() [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____________________- help: try this: `if elm.find(' ').is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | if let Ok(_) = f.read_to_string(&mut s) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 39 | | let pid: i32 = match s.trim().parse() { [INFO] [stderr] 40 | | Ok(pid) => pid, [INFO] [stderr] 41 | | Err(err) => { [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_________- help: try this: `if f.read_to_string(&mut s).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | if let Ok(_) = write!(f, "{}", process::id()) {} [INFO] [stderr] | ^^^^^ ------------------------------ help: try this: `if $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:69:28 [INFO] [stderr] | [INFO] [stderr] 69 | if let Some(_) = elm.find(' ') { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 70 | | let mut s = String::from("'"); [INFO] [stderr] 71 | | s.push_str(elm); [INFO] [stderr] 72 | | s.push_str("'"); [INFO] [stderr] ... | [INFO] [stderr] 75 | | elm.to_string() [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____________________- help: try this: `if elm.find(' ').is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.56s [INFO] running `"docker" "inspect" "5f41b712f778e90a55b2066b655ed7799ef77782f970fe23a6329ba97b5d5edb"` [INFO] running `"docker" "rm" "-f" "5f41b712f778e90a55b2066b655ed7799ef77782f970fe23a6329ba97b5d5edb"` [INFO] [stdout] 5f41b712f778e90a55b2066b655ed7799ef77782f970fe23a6329ba97b5d5edb