[INFO] updating cached repository dustinrohde/rparse
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dustinrohde/rparse
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dustinrohde/rparse" "work/ex/clippy-test-run/sources/stable/gh/dustinrohde/rparse"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dustinrohde/rparse'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dustinrohde/rparse" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dustinrohde/rparse"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dustinrohde/rparse'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ebcea17a297941cf5b1ea2be5716505f1adc7706
[INFO] sha for GitHub repo dustinrohde/rparse: ebcea17a297941cf5b1ea2be5716505f1adc7706
[INFO] validating manifest of dustinrohde/rparse on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dustinrohde/rparse on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dustinrohde/rparse
[INFO] finished frobbing dustinrohde/rparse
[INFO] frobbed toml for dustinrohde/rparse written to work/ex/clippy-test-run/sources/stable/gh/dustinrohde/rparse/Cargo.toml
[INFO] started frobbing dustinrohde/rparse
[INFO] finished frobbing dustinrohde/rparse
[INFO] frobbed toml for dustinrohde/rparse written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dustinrohde/rparse/Cargo.toml
[INFO] crate dustinrohde/rparse has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dustinrohde/rparse against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dustinrohde/rparse:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 50dd5900d642caf0dd12a1047d1e559117c499295d51639361035cfcc7e69291
[INFO] running `"docker" "start" "-a" "50dd5900d642caf0dd12a1047d1e559117c499295d51639361035cfcc7e69291"`
[INFO] [stderr]     Checking rparse v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/stream/impls.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 |         self.first().map(|&t| t)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.first().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/stream/position.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 | /         if let &'\n' = item {
[INFO] [stderr] 121 | |             self.line += 1;
[INFO] [stderr] 122 | |             self.column = 1;
[INFO] [stderr] 123 | |         } else {
[INFO] [stderr] 124 | |             self.column += 1;
[INFO] [stderr] 125 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 120 |         if let '\n' = *item {
[INFO] [stderr]     |                ^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: trait `StreamRange` has a `len` method but no (possibly inherited) `is_empty` method
[INFO] [stderr]   --> src/stream/mod.rs:53:1
[INFO] [stderr]    |
[INFO] [stderr] 53 | / pub trait StreamRange: Stream + PartialEq + Clone + Debug {
[INFO] [stderr] 54 | |     fn len(&self) -> usize;
[INFO] [stderr] 55 | |     fn from_str(s: &'static str) -> Self;
[INFO] [stderr] 56 | |     fn item_from_byte(c: u8) -> Self::Item;
[INFO] [stderr] 57 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `http_version`
[INFO] [stderr]   --> examples/http_parser.rs:22:1
[INFO] [stderr]    |
[INFO] [stderr] 22 | / fn http_version<S>() -> impl Parser<Stream = S, Output = Vec<S::Range>>
[INFO] [stderr] 23 | | where
[INFO] [stderr] 24 | |     S: Stream,
[INFO] [stderr] 25 | | {
[INFO] [stderr] 26 | |     range("HTTP/").then(choice![range("1"), range("1.1"), range("2")])
[INFO] [stderr] 27 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `http_method`
[INFO] [stderr]   --> examples/http_parser.rs:29:1
[INFO] [stderr]    |
[INFO] [stderr] 29 | / fn http_method<S>() -> impl Parser<Stream = S, Output = S::Range>
[INFO] [stderr] 30 | | where
[INFO] [stderr] 31 | |     S: Stream,
[INFO] [stderr] 32 | | {
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |     ]
[INFO] [stderr] 44 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `url_path`
[INFO] [stderr]   --> examples/http_parser.rs:50:1
[INFO] [stderr]    |
[INFO] [stderr] 50 | / fn url_path<S>() -> impl Parser<Stream = S, Output = Vec<S::Item>>
[INFO] [stderr] 51 | | where
[INFO] [stderr] 52 | |     S: Stream,
[INFO] [stderr] 53 | | {
[INFO] [stderr] ...  |
[INFO] [stderr] 61 | |     )
[INFO] [stderr] 62 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `url_segment_part`
[INFO] [stderr]   --> examples/http_parser.rs:64:1
[INFO] [stderr]    |
[INFO] [stderr] 64 | / fn url_segment_part<S>() -> impl Parser<Stream = S, Output = Vec<S::Item>>
[INFO] [stderr] 65 | | where
[INFO] [stderr] 66 | |     S: Stream,
[INFO] [stderr] 67 | | {
[INFO] [stderr] 68 | |     // one or more url-safe characters, or a percent-encoded octets
[INFO] [stderr] 69 | |     many1(url_token()).or(percent_encoded())
[INFO] [stderr] 70 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `url_token`
[INFO] [stderr]   --> examples/http_parser.rs:72:1
[INFO] [stderr]    |
[INFO] [stderr] 72 | / fn url_token<S>() -> impl Parser<Stream = S, Output = S::Item>
[INFO] [stderr] 73 | | where
[INFO] [stderr] 74 | |     S: Stream,
[INFO] [stderr] 75 | | {
[INFO] [stderr] ...  |
[INFO] [stderr] 82 | |     ]
[INFO] [stderr] 83 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `percent_encoded`
[INFO] [stderr]   --> examples/http_parser.rs:85:1
[INFO] [stderr]    |
[INFO] [stderr] 85 | / fn percent_encoded<S>() -> impl Parser<Stream = S, Output = Vec<S::Item>>
[INFO] [stderr] 86 | | where
[INFO] [stderr] 87 | |     S: Stream,
[INFO] [stderr] 88 | | {
[INFO] [stderr] ...  |
[INFO] [stderr] 91 | |         .append(ascii::hexdigit())
[INFO] [stderr] 92 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/stream/impls.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 |         self.first().map(|&t| t)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.first().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/stream/position.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 | /         if let &'\n' = item {
[INFO] [stderr] 121 | |             self.line += 1;
[INFO] [stderr] 122 | |             self.column = 1;
[INFO] [stderr] 123 | |         } else {
[INFO] [stderr] 124 | |             self.column += 1;
[INFO] [stderr] 125 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 120 |         if let '\n' = *item {
[INFO] [stderr]     |                ^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: trait `StreamRange` has a `len` method but no (possibly inherited) `is_empty` method
[INFO] [stderr]   --> src/stream/mod.rs:53:1
[INFO] [stderr]    |
[INFO] [stderr] 53 | / pub trait StreamRange: Stream + PartialEq + Clone + Debug {
[INFO] [stderr] 54 | |     fn len(&self) -> usize;
[INFO] [stderr] 55 | |     fn from_str(s: &'static str) -> Self;
[INFO] [stderr] 56 | |     fn item_from_byte(c: u8) -> Self::Item;
[INFO] [stderr] 57 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/parser/mod.rs:233:25
[INFO] [stderr]     |
[INFO] [stderr] 233 |             .ok_or_else(|| Error::unexpected_eoi())
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::unexpected_eoi`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/parser/mod.rs:249:45
[INFO] [stderr]     |
[INFO] [stderr] 249 |             "\n".as_bytes() => (Ok(b'\n'), ("".as_bytes(), 1));
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/parser/mod.rs:250:46
[INFO] [stderr]     |
[INFO] [stderr] 250 |             "\nx".as_bytes() => (Ok(b'\n'), ("x".as_bytes(), 1));
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"x"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/parser/mod.rs:252:13
[INFO] [stderr]     |
[INFO] [stderr] 252 |             "".as_bytes() => (0, vec![Error::unexpected_eoi()]);
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.87s
[INFO] running `"docker" "inspect" "50dd5900d642caf0dd12a1047d1e559117c499295d51639361035cfcc7e69291"`
[INFO] running `"docker" "rm" "-f" "50dd5900d642caf0dd12a1047d1e559117c499295d51639361035cfcc7e69291"`
[INFO] [stdout] 50dd5900d642caf0dd12a1047d1e559117c499295d51639361035cfcc7e69291