[INFO] updating cached repository dustinm76/ipf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dustinm76/ipf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dustinm76/ipf" "work/ex/clippy-test-run/sources/stable/gh/dustinm76/ipf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dustinm76/ipf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dustinm76/ipf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dustinm76/ipf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dustinm76/ipf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1f8fe043614ab10c1a42c7b4e8991cc8758ebb72 [INFO] sha for GitHub repo dustinm76/ipf: 1f8fe043614ab10c1a42c7b4e8991cc8758ebb72 [INFO] validating manifest of dustinm76/ipf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dustinm76/ipf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dustinm76/ipf [INFO] finished frobbing dustinm76/ipf [INFO] frobbed toml for dustinm76/ipf written to work/ex/clippy-test-run/sources/stable/gh/dustinm76/ipf/Cargo.toml [INFO] started frobbing dustinm76/ipf [INFO] finished frobbing dustinm76/ipf [INFO] frobbed toml for dustinm76/ipf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dustinm76/ipf/Cargo.toml [INFO] crate dustinm76/ipf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dustinm76/ipf against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dustinm76/ipf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d1359ec26d7e3f00320fe2dd7558bae06a4348450dbdcb71b74b7c9b108339cf [INFO] running `"docker" "start" "-a" "d1359ec26d7e3f00320fe2dd7558bae06a4348450dbdcb71b74b7c9b108339cf"` [INFO] [stderr] Checking ipf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/path_reader.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return paths; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/path_reader.rs:17:33 [INFO] [stderr] | [INFO] [stderr] 17 | let lines = input.split("\n"); //TODO if null-input, split on \0 [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/path_reader.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return paths; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/path_reader.rs:17:33 [INFO] [stderr] | [INFO] [stderr] 17 | let lines = input.split("\n"); //TODO if null-input, split on \0 [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "d1359ec26d7e3f00320fe2dd7558bae06a4348450dbdcb71b74b7c9b108339cf"` [INFO] running `"docker" "rm" "-f" "d1359ec26d7e3f00320fe2dd7558bae06a4348450dbdcb71b74b7c9b108339cf"` [INFO] [stdout] d1359ec26d7e3f00320fe2dd7558bae06a4348450dbdcb71b74b7c9b108339cf