[INFO] updating cached repository dtoebe/wc-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dtoebe/wc-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dtoebe/wc-rs" "work/ex/clippy-test-run/sources/stable/gh/dtoebe/wc-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dtoebe/wc-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dtoebe/wc-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dtoebe/wc-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dtoebe/wc-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 05f53c29c731bbd6cccecf5ebb7f7599fa7f8317 [INFO] sha for GitHub repo dtoebe/wc-rs: 05f53c29c731bbd6cccecf5ebb7f7599fa7f8317 [INFO] validating manifest of dtoebe/wc-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dtoebe/wc-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dtoebe/wc-rs [INFO] finished frobbing dtoebe/wc-rs [INFO] frobbed toml for dtoebe/wc-rs written to work/ex/clippy-test-run/sources/stable/gh/dtoebe/wc-rs/Cargo.toml [INFO] started frobbing dtoebe/wc-rs [INFO] finished frobbing dtoebe/wc-rs [INFO] frobbed toml for dtoebe/wc-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dtoebe/wc-rs/Cargo.toml [INFO] crate dtoebe/wc-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dtoebe/wc-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dtoebe/wc-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 56968388d5ebf44342f0907489b37ffa7bb69711bdfeb059eb09d29c59747b23 [INFO] running `"docker" "start" "-a" "56968388d5ebf44342f0907489b37ffa7bb69711bdfeb059eb09d29c59747b23"` [INFO] [stderr] Checking wc-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / let mut none: bool = false; [INFO] [stderr] 60 | | if !m.is_present("words") [INFO] [stderr] 61 | | && !m.is_present("lines") [INFO] [stderr] 62 | | && !m.is_present("bytes") [INFO] [stderr] ... | [INFO] [stderr] 65 | | none = true; [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 59 | let none = if !m.is_present("words") [INFO] [stderr] 60 | && !m.is_present("lines") [INFO] [stderr] 61 | && !m.is_present("bytes") [INFO] [stderr] 62 | && !m.is_present("chars") { true } else { false }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if n <= 0 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using n == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/main.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | let n_lines = bytes.iter().filter(|b| **b == b'\n').count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(bytes, b'\n')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wc-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / let mut none: bool = false; [INFO] [stderr] 60 | | if !m.is_present("words") [INFO] [stderr] 61 | | && !m.is_present("lines") [INFO] [stderr] 62 | | && !m.is_present("bytes") [INFO] [stderr] ... | [INFO] [stderr] 65 | | none = true; [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 59 | let none = if !m.is_present("words") [INFO] [stderr] 60 | && !m.is_present("lines") [INFO] [stderr] 61 | && !m.is_present("bytes") [INFO] [stderr] 62 | && !m.is_present("chars") { true } else { false }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if n <= 0 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using n == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/main.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | let n_lines = bytes.iter().filter(|b| **b == b'\n').count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(bytes, b'\n')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wc-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "56968388d5ebf44342f0907489b37ffa7bb69711bdfeb059eb09d29c59747b23"` [INFO] running `"docker" "rm" "-f" "56968388d5ebf44342f0907489b37ffa7bb69711bdfeb059eb09d29c59747b23"` [INFO] [stdout] 56968388d5ebf44342f0907489b37ffa7bb69711bdfeb059eb09d29c59747b23