[INFO] updating cached repository dtantsur/durak-game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dtantsur/durak-game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dtantsur/durak-game" "work/ex/clippy-test-run/sources/stable/gh/dtantsur/durak-game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dtantsur/durak-game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dtantsur/durak-game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dtantsur/durak-game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dtantsur/durak-game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ac2558a9807cf3a64fd167513631b7c254b28b8d [INFO] sha for GitHub repo dtantsur/durak-game: ac2558a9807cf3a64fd167513631b7c254b28b8d [INFO] validating manifest of dtantsur/durak-game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dtantsur/durak-game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dtantsur/durak-game [INFO] finished frobbing dtantsur/durak-game [INFO] frobbed toml for dtantsur/durak-game written to work/ex/clippy-test-run/sources/stable/gh/dtantsur/durak-game/Cargo.toml [INFO] started frobbing dtantsur/durak-game [INFO] finished frobbing dtantsur/durak-game [INFO] frobbed toml for dtantsur/durak-game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dtantsur/durak-game/Cargo.toml [INFO] crate dtantsur/durak-game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dtantsur/durak-game against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dtantsur/durak-game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd8f2c5ec963347455265d94dda02ccaa62c36e52ad0ec08023626ac9ffd79ad [INFO] running `"docker" "start" "-a" "dd8f2c5ec963347455265d94dda02ccaa62c36e52ad0ec08023626ac9ffd79ad"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking durak v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint `private_no_mangle_fns` has been removed: `no longer an warning, #[no_mangle] functions always exported` [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | private_no_mangle_fns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint `private_no_mangle_statics` has been removed: `no longer an warning, #[no_mangle] statics always exported` [INFO] [stderr] --> src/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | private_no_mangle_statics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | cards: cards, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cards` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | trump: trump, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trump` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | ai: ai, [INFO] [stderr] | ^^^^^^ help: replace it with: `ai` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | deck: deck, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deck` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | computer: computer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `computer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | game: game, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `game` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint `private_no_mangle_fns` has been removed: `no longer an warning, #[no_mangle] functions always exported` [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | private_no_mangle_fns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint `private_no_mangle_statics` has been removed: `no longer an warning, #[no_mangle] statics always exported` [INFO] [stderr] --> src/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | private_no_mangle_statics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | cards: cards, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cards` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | trump: trump, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trump` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | ai: ai, [INFO] [stderr] | ^^^^^^ help: replace it with: `ai` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | deck: deck, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deck` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | computer: computer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `computer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | game: game, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `game` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/game.rs:196:20 [INFO] [stderr] | [INFO] [stderr] 196 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 197 | | if let Some(attack) = self.ai.plan_attack(self) { [INFO] [stderr] 198 | | self.computer.attack_with(attack, &mut self.table); [INFO] [stderr] 199 | | Response::Play(attack) [INFO] [stderr] ... | [INFO] [stderr] 208 | | } [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 196 | } else if let Some(attack) = self.ai.plan_attack(self) { [INFO] [stderr] 197 | self.computer.attack_with(attack, &mut self.table); [INFO] [stderr] 198 | Response::Play(attack) [INFO] [stderr] 199 | } else { [INFO] [stderr] 200 | // No more cards to attack with, yielding. [INFO] [stderr] 201 | self.players_turn = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ui.rs:115:19 [INFO] [stderr] | [INFO] [stderr] 115 | const SEPARATOR: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/game.rs:196:20 [INFO] [stderr] | [INFO] [stderr] 196 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 197 | | if let Some(attack) = self.ai.plan_attack(self) { [INFO] [stderr] 198 | | self.computer.attack_with(attack, &mut self.table); [INFO] [stderr] 199 | | Response::Play(attack) [INFO] [stderr] ... | [INFO] [stderr] 208 | | } [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 196 | } else if let Some(attack) = self.ai.plan_attack(self) { [INFO] [stderr] 197 | self.computer.attack_with(attack, &mut self.table); [INFO] [stderr] 198 | Response::Play(attack) [INFO] [stderr] 199 | } else { [INFO] [stderr] 200 | // No more cards to attack with, yielding. [INFO] [stderr] 201 | self.players_turn = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ui.rs:115:19 [INFO] [stderr] | [INFO] [stderr] 115 | const SEPARATOR: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn beats(&self, other: &Card, trump: Suit) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:81:32 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn beats(&self, other: &Card, trump: Suit) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn compare(&self, other: &Card, trump: Suit) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:89:34 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn compare(&self, other: &Card, trump: Suit) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/card.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | let _ = self.cards.push(deck.draw()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/card.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let _ = self.cards.push(ac); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/card.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | let _ = self.cards.push(c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:198:32 [INFO] [stderr] | [INFO] [stderr] 198 | fn remove(&mut self, card: &Card) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:91:39 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn is_valid_move(&self, card: &Card) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn beats(&self, other: &Card, trump: Suit) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:81:32 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn beats(&self, other: &Card, trump: Suit) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn compare(&self, other: &Card, trump: Suit) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:89:34 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn compare(&self, other: &Card, trump: Suit) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/card.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | let _ = self.cards.push(deck.draw()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/card.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let _ = self.cards.push(ac); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/card.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | let _ = self.cards.push(c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:198:32 [INFO] [stderr] | [INFO] [stderr] 198 | fn remove(&mut self, card: &Card) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:91:39 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn is_valid_move(&self, card: &Card) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.cards.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/ui.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | for card in self.cards.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:223:45 [INFO] [stderr] | [INFO] [stderr] 223 | let c = ::std::char::from_digit((i + 1) as u32, 16).unwrap_or(' '); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(i + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.cards.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/ui.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | for card in self.cards.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ui.rs:223:45 [INFO] [stderr] | [INFO] [stderr] 223 | let c = ::std::char::from_digit((i + 1) as u32, 16).unwrap_or(' '); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(i + 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.98s [INFO] running `"docker" "inspect" "dd8f2c5ec963347455265d94dda02ccaa62c36e52ad0ec08023626ac9ffd79ad"` [INFO] running `"docker" "rm" "-f" "dd8f2c5ec963347455265d94dda02ccaa62c36e52ad0ec08023626ac9ffd79ad"` [INFO] [stdout] dd8f2c5ec963347455265d94dda02ccaa62c36e52ad0ec08023626ac9ffd79ad